From 8e7faf0e673e122e1998028a05be27274419081b Mon Sep 17 00:00:00 2001 From: Ray Molenkamp Date: Mon, 20 Jan 2020 14:03:50 +0100 Subject: [PATCH] Fix failing cycles_render_graph_finalize_test when building with clang The gflags library was not fully configured to be built as a static library, only one of two files was changed. Differential Revision: https://developer.blender.org/D6611 --- extern/gflags/README.blender | 3 +++ extern/gflags/src/gflags/gflags_declare.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/extern/gflags/README.blender b/extern/gflags/README.blender index c57f5ce53ca..be68c310997 100644 --- a/extern/gflags/README.blender +++ b/extern/gflags/README.blender @@ -14,6 +14,9 @@ Local modifications: * Disabeld HAVE_FNMATCH_H * Forced disabled GFLAGS_IS_A_DLL +- gflags_declare.h was modified + * Forced disabled GFLAGS_IS_A_DLL + - Applied some modifications from fork https://github.com/Nazg-Gul/gflags.git (see https://github.com/gflags/gflags/pull/129) diff --git a/extern/gflags/src/gflags/gflags_declare.h b/extern/gflags/src/gflags/gflags_declare.h index 98747f3cda1..3b187bd4153 100644 --- a/extern/gflags/src/gflags/gflags_declare.h +++ b/extern/gflags/src/gflags/gflags_declare.h @@ -51,7 +51,7 @@ // Must be overwritten when this header file is used with the optionally also // built static library instead; set by CMake's INTERFACE_COMPILE_DEFINITIONS. #ifndef GFLAGS_IS_A_DLL -# define GFLAGS_IS_A_DLL 1 +# define GFLAGS_IS_A_DLL 0 #endif // We always want to import the symbols of the gflags library.