From 8f4fccaa3313c30a49f550c825b742e5571a73de Mon Sep 17 00:00:00 2001 From: Jacques Lucke Date: Wed, 2 Aug 2023 15:34:45 +0200 Subject: [PATCH] Creator: move to C++ Also see #103343. Co-authored-by: Hans Goudey Pull Request: https://projects.blender.org/blender/blender/pulls/110539 --- source/creator/CMakeLists.txt | 11 +- source/creator/{creator.c => creator.cc} | 83 ++- .../{creator_args.c => creator_args.cc} | 498 ++++++++---------- .../{creator_signals.c => creator_signals.cc} | 20 +- 4 files changed, 287 insertions(+), 325 deletions(-) rename source/creator/{creator.c => creator.cc} (88%) rename source/creator/{creator_args.c => creator_args.cc} (82%) rename source/creator/{creator_signals.c => creator_signals.cc} (94%) diff --git a/source/creator/CMakeLists.txt b/source/creator/CMakeLists.txt index 7f332fd509a..1d4e1ebf595 100644 --- a/source/creator/CMakeLists.txt +++ b/source/creator/CMakeLists.txt @@ -81,6 +81,11 @@ if(WITH_TBB) endif() endif() +if(WIN32) + # Windows.h will define min/max macros that will collide with the stl versions. + add_definitions(-DNOMINMAX) +endif() + if(WITH_USD) # USD links libMaterialX, when using pre-compiled libraries # ensures `usd_ms` can find `MaterialXRender` and friends. @@ -140,9 +145,9 @@ endif() # Setup the EXE sources and `buildinfo`. set(SRC - creator.c - creator_args.c - creator_signals.c + creator.cc + creator_args.cc + creator_signals.cc creator_intern.h ) diff --git a/source/creator/creator.c b/source/creator/creator.cc similarity index 88% rename from source/creator/creator.c rename to source/creator/creator.cc index 574aeef30e3..3d10057b357 100644 --- a/source/creator/creator.c +++ b/source/creator/creator.cc @@ -120,17 +120,13 @@ * \{ */ /* written to by 'creator_args.c' */ -struct ApplicationState app_state = { - .signal = - { - .use_crash_handler = true, - .use_abort_handler = true, - }, - .exit_code_on_error = - { - .python = 0, - }, -}; +ApplicationState app_state = []() { + ApplicationState app_state{}; + app_state.signal.use_crash_handler = true; + app_state.signal.use_abort_handler = true; + app_state.exit_code_on_error.python = 0; + return app_state; +}(); /** \} */ @@ -159,7 +155,7 @@ struct CreatorAtExitData { #endif #ifdef USE_WIN32_UNICODE_ARGS - const char **argv; + char **argv; int argv_num; #endif @@ -170,12 +166,12 @@ struct CreatorAtExitData { static void callback_main_atexit(void *user_data) { - struct CreatorAtExitData *app_init_data = user_data; + struct CreatorAtExitData *app_init_data = static_cast(user_data); #ifndef WITH_PYTHON_MODULE if (app_init_data->ba) { BLI_args_destroy(app_init_data->ba); - app_init_data->ba = NULL; + app_init_data->ba = nullptr; } #else UNUSED_VARS(app_init_data); /* May be unused. */ @@ -187,7 +183,7 @@ static void callback_main_atexit(void *user_data) free((void *)app_init_data->argv[--app_init_data->argv_num]); } free((void *)app_init_data->argv); - app_init_data->argv = NULL; + app_init_data->argv = nullptr; } #else UNUSED_VARS(app_init_data); /* May be unused. */ @@ -196,7 +192,7 @@ static void callback_main_atexit(void *user_data) static void callback_clg_fatal(void *fp) { - BLI_system_backtrace(fp); + BLI_system_backtrace(static_cast(fp)); } /** \} */ @@ -216,12 +212,12 @@ void main_python_exit(void); /* Rename the 'main' function, allowing Python initialization to call it. */ # define main main_python_enter -static void *evil_C = NULL; +static void *evil_C = nullptr; # ifdef __APPLE__ /* Environment is not available in macOS shared libraries. */ # include -char **environ = NULL; +char **environ = nullptr; # endif /* __APPLE__ */ #endif /* WITH_PYTHON_MODULE */ @@ -241,12 +237,12 @@ void *gmp_alloc(size_t size) { return scalable_malloc(size); } -void *gmp_realloc(void *ptr, size_t UNUSED(old_size), size_t new_size) +void *gmp_realloc(void *ptr, size_t /*old_size*/, size_t new_size) { return scalable_realloc(ptr, new_size); } -void gmp_free(void *ptr, size_t UNUSED(size)) +void gmp_free(void *ptr, size_t /*size*/) { scalable_free(ptr); } @@ -268,6 +264,10 @@ void gmp_blender_init_allocator() /** \name Main Function * \{ */ +#if defined(__APPLE__) +extern "C" int GHOST_HACK_getFirstFile(char buf[]); +#endif + /** * Blender's main function responsibilities are: * - setup subsystems. @@ -277,7 +277,7 @@ void gmp_blender_init_allocator() */ int main(int argc, #ifdef USE_WIN32_UNICODE_ARGS - const char **UNUSED(argv_c) + const char ** /*argv_c*/ #else const char **argv #endif @@ -297,20 +297,20 @@ int main(int argc, /* --- end declarations --- */ /* Ensure we free data on early-exit. */ - struct CreatorAtExitData app_init_data = {NULL}; + struct CreatorAtExitData app_init_data = {nullptr}; BKE_blender_atexit_register(callback_main_atexit, &app_init_data); - /* Un-buffered `stdout` makes `stdout` and `stderr` better synchronized, and helps - * when stepping through code in a debugger (prints are immediately - * visible). However disabling buffering causes lock contention on windows - * see #76767 for details, since this is a debugging aid, we do not enable - * the un-buffered behavior for release builds. */ +/* Un-buffered `stdout` makes `stdout` and `stderr` better synchronized, and helps + * when stepping through code in a debugger (prints are immediately + * visible). However disabling buffering causes lock contention on windows + * see #76767 for details, since this is a debugging aid, we do not enable + * the un-buffered behavior for release builds. */ #ifndef NDEBUG - setvbuf(stdout, NULL, _IONBF, 0); + setvbuf(stdout, nullptr, _IONBF, 0); #endif #ifdef WIN32 - /* We delay loading of OPENMP so we can set the policy here. */ +/* We delay loading of OPENMP so we can set the policy here. */ # if defined(_MSC_VER) _putenv_s("OMP_WAIT_POLICY", "PASSIVE"); # endif @@ -321,7 +321,7 @@ int main(int argc, /* NOTE: Can't use `guardedalloc` allocation here, as it's not yet initialized * (it depends on the arguments passed in, which is what we're getting here!) */ wchar_t **argv_16 = CommandLineToArgvW(GetCommandLineW(), &argc); - argv = malloc(argc * sizeof(char *)); + argv = static_cast(malloc(argc * sizeof(char *))); for (argv_num = 0; argv_num < argc; argv_num++) { argv[argv_num] = alloc_utf_8_from_16(argv_16[argv_num], 0); } @@ -402,7 +402,7 @@ int main(int argc, #endif #ifdef WITH_BINRELOC - br_init(NULL); + br_init(nullptr); #endif #ifdef WITH_LIBMV @@ -420,7 +420,6 @@ int main(int argc, #if defined(__APPLE__) && !defined(WITH_PYTHON_MODULE) && !defined(WITH_HEADLESS) /* Patch to ignore argument finder gives us (PID?) */ if (argc == 2 && STRPREFIX(argv[1], "-psn_")) { - extern int GHOST_HACK_getFirstFile(char buf[]); static char firstfilebuf[512]; argc = 1; @@ -459,7 +458,7 @@ int main(int argc, BKE_callback_global_init(); - /* First test for background-mode (#Global.background) */ +/* First test for background-mode (#Global.background) */ #ifndef WITH_PYTHON_MODULE ba = BLI_args_create(argc, (const char **)argv); /* skip binary path */ @@ -473,7 +472,7 @@ int main(int argc, MEM_use_memleak_detection(false); /* Parse environment handling arguments. */ - BLI_args_parse(ba, ARG_PASS_ENVIRONMENT, NULL, NULL); + BLI_args_parse(ba, ARG_PASS_ENVIRONMENT, nullptr, nullptr); #else /* Using preferences or user startup makes no sense for #WITH_PYTHON_MODULE. */ @@ -492,7 +491,7 @@ int main(int argc, #ifndef WITH_PYTHON_MODULE /* First test for background-mode (#Global.background) */ - BLI_args_parse(ba, ARG_PASS_SETTINGS, NULL, NULL); + BLI_args_parse(ba, ARG_PASS_SETTINGS, nullptr, nullptr); main_signal_setup(); #endif @@ -530,9 +529,9 @@ int main(int argc, #ifndef WITH_PYTHON_MODULE if (G.background == 0) { - BLI_args_parse(ba, ARG_PASS_SETTINGS_GUI, NULL, NULL); + BLI_args_parse(ba, ARG_PASS_SETTINGS_GUI, nullptr, nullptr); } - BLI_args_parse(ba, ARG_PASS_SETTINGS_FORCE, NULL, NULL); + BLI_args_parse(ba, ARG_PASS_SETTINGS_FORCE, nullptr, nullptr); #endif WM_init(C, argc, (const char **)argv); @@ -555,7 +554,7 @@ int main(int argc, FRS_set_context(C); #endif - /* OK we are ready for it */ +/* OK we are ready for it */ #ifndef WITH_PYTHON_MODULE /* Handles #ARG_PASS_FINAL. */ BLI_args_parse(ba, ARG_PASS_FINAL, main_args_handle_load_file, C); @@ -571,14 +570,14 @@ int main(int argc, /* End argument parsing, allow memory leaks to be printed. */ MEM_use_memleak_detection(true); - /* Paranoid, avoid accidental re-use. */ +/* Paranoid, avoid accidental re-use. */ #ifndef WITH_PYTHON_MODULE - ba = NULL; + ba = nullptr; (void)ba; #endif #ifdef USE_WIN32_UNICODE_ARGS - argv = NULL; + argv = nullptr; (void)argv; #endif @@ -606,7 +605,7 @@ int main(int argc, void main_python_exit(void) { WM_exit_ex((bContext *)evil_C, true, false); - evil_C = NULL; + evil_C = nullptr; } #endif diff --git a/source/creator/creator_args.c b/source/creator/creator_args.cc similarity index 82% rename from source/creator/creator_args.c rename to source/creator/creator_args.cc index aa3478196d2..470e689af81 100644 --- a/source/creator/creator_args.c +++ b/source/creator/creator_args.cc @@ -153,7 +153,7 @@ static bool parse_int_relative(const char *str, int *r_value, const char **r_err_msg) { - char *str_end = NULL; + char *str_end = nullptr; long value; errno = 0; @@ -186,17 +186,17 @@ static bool parse_int_relative(const char *str, static const char *parse_int_range_sep_search(const char *str, const char *str_end_test) { - const char *str_end_range = NULL; + const char *str_end_range = nullptr; if (str_end_test) { - str_end_range = memchr(str, '.', (str_end_test - str) - 1); + str_end_range = static_cast(memchr(str, '.', (str_end_test - str) - 1)); if (str_end_range && (str_end_range[1] != '.')) { - str_end_range = NULL; + str_end_range = nullptr; } } else { str_end_range = strstr(str, ".."); if (str_end_range && (str_end_range[2] == '\0')) { - str_end_range = NULL; + str_end_range = nullptr; } } return str_end_range; @@ -268,7 +268,7 @@ static bool parse_int_strict_range(const char *str, int *r_value, const char **r_err_msg) { - char *str_end = NULL; + char *str_end = nullptr; long value; errno = 0; @@ -355,7 +355,7 @@ static int *parse_int_relative_clamp_n( fail: MEM_freeN(values); - return NULL; + return nullptr; } # endif @@ -382,7 +382,7 @@ static int (*parse_int_range_relative_clamp_n(const char *str, } } - int(*values)[2] = MEM_mallocN(sizeof(*values) * len, __func__); + int(*values)[2] = static_cast(MEM_mallocN(sizeof(*values) * len, __func__)); int i = 0; while (true) { const char *str_end_range; @@ -398,7 +398,7 @@ static int (*parse_int_range_relative_clamp_n(const char *str, parse_int_relative_clamp( str, str_end, pos, neg, min, max, &values[i][0], r_err_msg)) { - if (str_end_range == NULL) { + if (str_end_range == nullptr) { values[i][1] = values[i][0]; } i++; @@ -420,7 +420,7 @@ static int (*parse_int_range_relative_clamp_n(const char *str, fail: MEM_freeN(values); - return NULL; + return nullptr; } /** \} */ @@ -447,10 +447,10 @@ static void arg_py_context_backup(bContext *C, c_py->has_win = !BLI_listbase_is_empty(&c_py->wm->windows); if (c_py->has_win) { c_py->win = CTX_wm_window(C); - CTX_wm_window_set(C, c_py->wm->windows.first); + CTX_wm_window_set(C, static_cast(c_py->wm->windows.first)); } else { - c_py->win = NULL; + c_py->win = nullptr; fprintf(stderr, "Python script \"%s\" " "running with missing context data.\n", @@ -462,14 +462,14 @@ static void arg_py_context_restore(bContext *C, struct BlendePyContextStore *c_p { /* script may load a file, check old data is valid before using */ if (c_py->has_win) { - if ((c_py->win == NULL) || ((BLI_findindex(&G_MAIN->wm, c_py->wm) != -1) && - (BLI_findindex(&c_py->wm->windows, c_py->win) != -1))) + if ((c_py->win == nullptr) || ((BLI_findindex(&G_MAIN->wm, c_py->wm) != -1) && + (BLI_findindex(&c_py->wm->windows, c_py->win) != -1))) { CTX_wm_window_set(C, c_py->win); } } - if ((c_py->scene == NULL) || BLI_findindex(&G_MAIN->scenes, c_py->scene) != -1) { + if ((c_py->scene == nullptr) || BLI_findindex(&G_MAIN->scenes, c_py->scene) != -1) { CTX_data_scene_set(C, c_py->scene); } } @@ -540,9 +540,7 @@ static void print_version_short(void) static const char arg_handle_print_version_doc[] = "\n\t" "Print Blender version and exit."; -static int arg_handle_print_version(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_print_version(int /*argc*/, const char ** /*argv*/, void * /*data*/) { print_version_full(); exit(EXIT_SUCCESS); @@ -787,7 +785,7 @@ static void print_help(bArgs *ba, bool all) ATTR_PRINTF_FORMAT(2, 0) static void help_print_ds_fn(void *ds_v, const char *format, va_list args) { - DynStr *ds = ds_v; + DynStr *ds = static_cast(ds_v); BLI_dynstr_vappendf(ds, format, args); } @@ -795,8 +793,8 @@ static char *main_args_help_as_string(bool all) { DynStr *ds = BLI_dynstr_new(); { - bArgs *ba = BLI_args_create(0, NULL); - main_args_setup(NULL, ba, all); + bArgs *ba = BLI_args_create(0, nullptr); + main_args_setup(nullptr, ba, all); BLI_args_print_fn_set(ba, help_print_ds_fn, ds); print_help(ba, all); BLI_args_destroy(ba); @@ -812,7 +810,7 @@ static const char arg_handle_print_help_doc[] = static const char arg_handle_print_help_doc_win32[] = "\n\t" "Print this help text and exit (Windows only)."; -static int arg_handle_print_help(int UNUSED(argc), const char **UNUSED(argv), void *data) +static int arg_handle_print_help(int /*argc*/, const char ** /*argv*/, void *data) { bArgs *ba = (bArgs *)data; @@ -828,9 +826,7 @@ static const char arg_handle_arguments_end_doc[] = "\n\t" "End option processing, following arguments passed unchanged. Access via Python's " "'sys.argv'."; -static int arg_handle_arguments_end(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_arguments_end(int /*argc*/, const char ** /*argv*/, void * /*data*/) { return -1; } @@ -853,7 +849,7 @@ static const char arg_handle_python_set_doc_disable[] = # undef PY_ENABLE_AUTO # undef PY_DISABLE_AUTO -static int arg_handle_python_set(int UNUSED(argc), const char **UNUSED(argv), void *data) +static int arg_handle_python_set(int /*argc*/, const char ** /*argv*/, void *data) { if ((bool)data) { G.f |= G_FLAG_SCRIPT_AUTOEXEC; @@ -868,9 +864,7 @@ static int arg_handle_python_set(int UNUSED(argc), const char **UNUSED(argv), vo static const char arg_handle_crash_handler_disable_doc[] = "\n\t" "Disable the crash handler."; -static int arg_handle_crash_handler_disable(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_crash_handler_disable(int /*argc*/, const char ** /*argv*/, void * /*data*/) { app_state.signal.use_crash_handler = false; return 0; @@ -879,9 +873,7 @@ static int arg_handle_crash_handler_disable(int UNUSED(argc), static const char arg_handle_abort_handler_disable_doc[] = "\n\t" "Disable the abort handler."; -static int arg_handle_abort_handler_disable(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_abort_handler_disable(int /*argc*/, const char ** /*argv*/, void * /*data*/) { app_state.signal.use_abort_handler = false; return 0; @@ -889,17 +881,15 @@ static int arg_handle_abort_handler_disable(int UNUSED(argc), static void clog_abort_on_error_callback(void *fp) { - BLI_system_backtrace(fp); - fflush(fp); + BLI_system_backtrace(static_cast(fp)); + fflush(static_cast(fp)); abort(); } static const char arg_handle_debug_exit_on_error_doc[] = "\n\t" "Immediately exit when internal errors are detected."; -static int arg_handle_debug_exit_on_error(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_exit_on_error(int /*argc*/, const char ** /*argv*/, void * /*data*/) { MEM_enable_fail_on_memleak(); CLG_error_fn_set(clog_abort_on_error_callback); @@ -909,9 +899,7 @@ static int arg_handle_debug_exit_on_error(int UNUSED(argc), static const char arg_handle_background_mode_set_doc[] = "\n\t" "Run in background (often used for UI-less rendering)."; -static int arg_handle_background_mode_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_background_mode_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { print_version_short(); G.background = 1; @@ -922,12 +910,12 @@ static const char arg_handle_log_level_set_doc[] = "\n" "\tSet the logging verbosity level (higher for more details) defaults to 1,\n" "\tuse -1 to log all levels."; -static int arg_handle_log_level_set(int argc, const char **argv, void *UNUSED(data)) +static int arg_handle_log_level_set(int argc, const char **argv, void * /*data*/) { const char *arg_id = "--log-level"; if (argc > 1) { - const char *err_msg = NULL; - if (!parse_int_clamp(argv[1], NULL, -1, INT_MAX, &G.log.level, &err_msg)) { + const char *err_msg = nullptr; + if (!parse_int_clamp(argv[1], nullptr, -1, INT_MAX, &G.log.level, &err_msg)) { fprintf(stderr, "\nError: %s '%s %s'.\n", err_msg, arg_id, argv[1]); } else { @@ -945,9 +933,7 @@ static int arg_handle_log_level_set(int argc, const char **argv, void *UNUSED(da static const char arg_handle_log_show_basename_set_doc[] = "\n\t" "Only show file name in output (not the leading path)."; -static int arg_handle_log_show_basename_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_log_show_basename_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { CLG_output_use_basename_set(true); return 0; @@ -956,9 +942,7 @@ static int arg_handle_log_show_basename_set(int UNUSED(argc), static const char arg_handle_log_show_backtrace_set_doc[] = "\n\t" "Show a back trace for each log message (debug builds only)."; -static int arg_handle_log_show_backtrace_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_log_show_backtrace_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { /* Ensure types don't become incompatible. */ void (*fn)(FILE * fp) = BLI_system_backtrace; @@ -969,9 +953,7 @@ static int arg_handle_log_show_backtrace_set(int UNUSED(argc), static const char arg_handle_log_show_timestamp_set_doc[] = "\n\t" "Show a timestamp for each log message in seconds since start."; -static int arg_handle_log_show_timestamp_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_log_show_timestamp_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { CLG_output_use_timestamp_set(true); return 0; @@ -980,19 +962,19 @@ static int arg_handle_log_show_timestamp_set(int UNUSED(argc), static const char arg_handle_log_file_set_doc[] = "\n" "\tSet a file to output the log to."; -static int arg_handle_log_file_set(int argc, const char **argv, void *UNUSED(data)) +static int arg_handle_log_file_set(int argc, const char **argv, void * /*data*/) { const char *arg_id = "--log-file"; if (argc > 1) { errno = 0; FILE *fp = BLI_fopen(argv[1], "w"); - if (fp == NULL) { + if (fp == nullptr) { const char *err_msg = errno ? strerror(errno) : "unknown"; fprintf(stderr, "\nError: %s '%s %s'.\n", err_msg, arg_id, argv[1]); } else { - if (UNLIKELY(G.log.file != NULL)) { - fclose(G.log.file); + if (UNLIKELY(G.log.file != nullptr)) { + fclose(static_cast(G.log.file)); } G.log.file = fp; CLG_output_set(G.log.file); @@ -1013,7 +995,7 @@ static const char arg_handle_log_set_doc[] = "\tUse \"^\" prefix to ignore, so '--log \"*,^wm.operator.*\"' logs all except for " "'wm.operators.*'\n" "\tUse \"*\" to log everything."; -static int arg_handle_log_set(int argc, const char **argv, void *UNUSED(data)) +static int arg_handle_log_set(int argc, const char **argv, void * /*data*/) { const char *arg_id = "--log"; if (argc > 1) { @@ -1053,7 +1035,7 @@ static const char arg_handle_debug_mode_set_doc[] = "\t* Enables memory error detection\n" "\t* Disables mouse grab (to interact with a debugger in some cases)\n" "\t* Keeps Python's 'sys.stdin' rather than setting it to None"; -static int arg_handle_debug_mode_set(int UNUSED(argc), const char **UNUSED(argv), void *data) +static int arg_handle_debug_mode_set(int /*argc*/, const char ** /*argv*/, void *data) { G.debug |= G_DEBUG; /* std output printf's */ printf("Blender %s\n", BKE_blender_version_string()); @@ -1066,7 +1048,7 @@ static int arg_handle_debug_mode_set(int UNUSED(argc), const char **UNUSED(argv) printf("Build: %s %s %s %s\n", build_date, build_time, build_platform, build_type); # endif - BLI_args_print(data); + BLI_args_print(static_cast(data)); return 0; } @@ -1137,9 +1119,7 @@ static const char arg_handle_debug_mode_generic_set_doc_gpu_disable_ssbo[] = "\n\t" "Disable usage of shader storage buffer objects."; -static int arg_handle_debug_mode_generic_set(int UNUSED(argc), - const char **UNUSED(argv), - void *data) +static int arg_handle_debug_mode_generic_set(int /*argc*/, const char ** /*argv*/, void *data) { G.debug |= POINTER_AS_INT(data); return 0; @@ -1148,9 +1128,7 @@ static int arg_handle_debug_mode_generic_set(int UNUSED(argc), static const char arg_handle_debug_mode_io_doc[] = "\n\t" "Enable debug messages for I/O (Collada, ...)."; -static int arg_handle_debug_mode_io(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_mode_io(int /*argc*/, const char ** /*argv*/, void * /*data*/) { G.debug |= G_DEBUG_IO; return 0; @@ -1159,9 +1137,7 @@ static int arg_handle_debug_mode_io(int UNUSED(argc), static const char arg_handle_debug_mode_all_doc[] = "\n\t" "Enable all debug messages."; -static int arg_handle_debug_mode_all(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_mode_all(int /*argc*/, const char ** /*argv*/, void * /*data*/) { G.debug |= G_DEBUG_ALL; # ifdef WITH_LIBMV @@ -1176,9 +1152,7 @@ static int arg_handle_debug_mode_all(int UNUSED(argc), static const char arg_handle_debug_mode_libmv_doc[] = "\n\t" "Enable debug messages from libmv library."; -static int arg_handle_debug_mode_libmv(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_mode_libmv(int /*argc*/, const char ** /*argv*/, void * /*data*/) { # ifdef WITH_LIBMV libmv_startDebugLogging(); @@ -1189,9 +1163,7 @@ static int arg_handle_debug_mode_libmv(int UNUSED(argc), static const char arg_handle_debug_mode_cycles_doc[] = "\n\t" "Enable debug messages from Cycles."; -static int arg_handle_debug_mode_cycles(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_mode_cycles(int /*argc*/, const char ** /*argv*/, void * /*data*/) { # ifdef WITH_CYCLES_LOGGING CCL_start_debug_logging(); @@ -1202,9 +1174,7 @@ static int arg_handle_debug_mode_cycles(int UNUSED(argc), static const char arg_handle_debug_mode_memory_set_doc[] = "\n\t" "Enable fully guarded memory allocation and debugging."; -static int arg_handle_debug_mode_memory_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_mode_memory_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { MEM_set_memory_debug(); return 0; @@ -1213,13 +1183,13 @@ static int arg_handle_debug_mode_memory_set(int UNUSED(argc), static const char arg_handle_debug_value_set_doc[] = "\n" "\tSet debug value of on startup."; -static int arg_handle_debug_value_set(int argc, const char **argv, void *UNUSED(data)) +static int arg_handle_debug_value_set(int argc, const char **argv, void * /*data*/) { const char *arg_id = "--debug-value"; if (argc > 1) { - const char *err_msg = NULL; + const char *err_msg = nullptr; int value; - if (!parse_int(argv[1], NULL, &value, &err_msg)) { + if (!parse_int(argv[1], nullptr, &value, &err_msg)) { fprintf(stderr, "\nError: %s '%s %s'.\n", err_msg, arg_id, argv[1]); return 1; } @@ -1235,9 +1205,7 @@ static int arg_handle_debug_value_set(int argc, const char **argv, void *UNUSED( static const char arg_handle_debug_gpu_set_doc[] = "\n" "\tEnable GPU debug context and information for OpenGL 4.3+."; -static int arg_handle_debug_gpu_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_gpu_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { /* Also enable logging because that how gl errors are reported. */ const char *gpu_filter = "gpu.*"; @@ -1249,9 +1217,9 @@ static int arg_handle_debug_gpu_set(int UNUSED(argc), static const char arg_handle_debug_gpu_renderdoc_set_doc[] = "\n" "\tEnable Renderdoc integration for GPU frame grabbing and debugging."; -static int arg_handle_debug_gpu_renderdoc_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_gpu_renderdoc_set(int /*argc*/, + const char ** /*argv*/, + void * /*data*/) { # ifdef WITH_RENDERDOC G.debug |= G_DEBUG_GPU_RENDERDOC | G_DEBUG_GPU; @@ -1284,13 +1252,13 @@ static const char arg_handle_gpu_backend_set_doc[] = "'opengl'" # endif "."; -static int arg_handle_gpu_backend_set(int argc, const char **argv, void *UNUSED(data)) +static int arg_handle_gpu_backend_set(int argc, const char **argv, void * /*data*/) { if (argc == 0) { fprintf(stderr, "\nError: GPU backend must follow '--gpu-backend'.\n"); return 0; } - const char *backends_supported[3] = {NULL}; + const char *backends_supported[3] = {nullptr}; int backends_supported_num = 0; eGPUBackendType gpu_backend = GPU_BACKEND_NONE; @@ -1332,9 +1300,7 @@ static int arg_handle_gpu_backend_set(int argc, const char **argv, void *UNUSED( static const char arg_handle_debug_fpe_set_doc[] = "\n\t" "Enable floating-point exceptions."; -static int arg_handle_debug_fpe_set(int UNUSED(argc), - const char **UNUSED(argv), - void *UNUSED(data)) +static int arg_handle_debug_fpe_set(int /*argc*/, const char ** /*argv*/, void * /*data*/) { main_signal_setup_fpe(); return 0; @@ -1343,7 +1309,7 @@ static int arg_handle_debug_fpe_set(int UNUSED(argc), static const char arg_handle_app_template_doc[] = "