griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Extensions: show a dialog when dropping a URL while offline

Browse Source 
The dialog notifies the user that online access is required with a
button to go to the system preferences.

See #120665.
This commit is contained in:
Campbell Barton
2024-05-30 16:05:11 +10:00
parent ed2b8e9c5c
commit 8f97419561
2 changed files with 48 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
source/blender/editors/space_userpref/userpref_ops.cc
View File

@@ -859,18 +859,28 @@ static void PREFERENCES_OT_extension_repo_upgrade(wmOperatorType *ot)
static int preferences_extension_url_drop_invoke(bContext *C, wmOperator *op, const wmEvent *event)
{
char *url = RNA_string_get_alloc(op->ptr, "url", nullptr, 0, nullptr);
const bool url_is_remote = STRPREFIX(url, "http://") || STRPREFIX(url, "https://") ||
STRPREFIX(url, "file://");
const bool url_is_file = STRPREFIX(url, "file://");
const bool url_is_online = STRPREFIX(url, "http://") || STRPREFIX(url, "https://");
const bool url_is_remote = url_is_file | url_is_online;
/* NOTE: searching for hard-coded add-on name isn't great.
* Needed since #WM_dropbox_add expects the operator to exist on startup. */
const char *idname_external = url_is_remote ? "bl_pkg.pkg_install" : "bl_pkg.pkg_install_files";
bool use_url = true;
if (url_is_online && (G.f & G_FLAG_INTERNET_ALLOW) == 0) {
idname_external = "bl_pkg.extensions_show_online_prefs_popup";
use_url = false;
}
wmOperatorType *ot = WM_operatortype_find(idname_external, true);
int retval;
if (ot) {
PointerRNA props_ptr;
WM_operator_properties_create_ptr(&props_ptr, ot);
RNA_string_set(&props_ptr, "url", url);
if (use_url) {
RNA_string_set(&props_ptr, "url", url);
}
WM_operator_name_call_ptr(C, ot, WM_OP_INVOKE_DEFAULT, &props_ptr, event);
WM_operator_properties_free(&props_ptr);
retval = OPERATOR_FINISHED;