From 919d2693c0db438a2bd7d255dc2cf48c3bbdc94b Mon Sep 17 00:00:00 2001
From: Aras Pranckevicius <aras@nesnausk.org>
Date: Wed, 14 May 2025 14:45:40 +0200
Subject: [PATCH] Build: expand Visual Studio natvis file

Expand the natvis file (which VS IDE debugger uses to visualize custom
data types) to handle:
- blender::Map with pointer keys
- blender::Set with both regular and pointer keys

Pull Request: https://projects.blender.org/blender/blender/pulls/138866
---
 tools/utils_ide/natvis/Blender.natvis | 59 +++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/tools/utils_ide/natvis/Blender.natvis b/tools/utils_ide/natvis/Blender.natvis
index ac141879470..ada52cb7eee 100644
--- a/tools/utils_ide/natvis/Blender.natvis
+++ b/tools/utils_ide/natvis/Blender.natvis
@@ -37,6 +37,25 @@
         </ArrayItems>
     </Expand>
   </Type>
+  <!-- visualizer for Map with pointer keys (IntrusiveMapSlot slot type) -->
+  <Type Name="blender::Map&lt;*&gt;" Priority="MediumLow">
+    <DisplayString>Size={occupied_and_removed_slots_ - removed_slots_}</DisplayString>
+    <Expand>
+      <CustomListItems MaxItemsPerView="5000">
+        <Variable Name="slot" InitialValue="slots_.data_"/>
+        <Variable Name="i" InitialValue="0"/>
+        <Loop>
+          <Break Condition="i &gt;= occupied_and_removed_slots_ - removed_slots_"/>
+          <If Condition="(uint64_t)slot-&gt;key_ &lt; 0xfffffffffffffffe">
+            <Item Name="{slot-&gt;key_}">slot-&gt;value_buffer_</Item>
+            <Exec>++i</Exec>
+          </If>
+          <Exec>++slot</Exec>
+        </Loop>
+      </CustomListItems>
+    </Expand>
+  </Type>  
+  <!-- visualizer for regular Map (SimpleMapSlot slot type) -->
   <Type Name="blender::Map&lt;*&gt;">
     <DisplayString>Size={occupied_and_removed_slots_ - removed_slots_}</DisplayString>
     <Expand>
@@ -51,8 +70,48 @@
         </Loop>
       </CustomListItems>
     </Expand>
+  </Type>
+  <!-- visualizer for Set with pointer keys (IntrusiveSetSlot slot type) -->
+  <Type Name="blender::Set&lt;*&gt;" Priority="MediumLow">
+    <DisplayString>Size={occupied_and_removed_slots_ - removed_slots_}</DisplayString>
+    <Expand>
+      <CustomListItems MaxItemsPerView="5000">
+        <Variable Name="slot" InitialValue="slots_.data_"/>
+        <Variable Name="i" InitialValue="0"/>
+        <Loop>
+          <Break Condition="i &gt;= occupied_and_removed_slots_ - removed_slots_"/>
+          <If Condition="(uint64_t)slot-&gt;key_ &lt; 0xfffffffffffffffe">
+            <Item Name="[{i}]">slot-&gt;key_</Item>
+            <Exec>++i</Exec>
+          </If>
+          <Exec>++slot</Exec>
+        </Loop>
+      </CustomListItems>
+    </Expand>
   </Type>  
+  <!-- visualizer for regular Set (SimpleSetSlot slot type) -->
+  <Type Name="blender::Set&lt;*&gt;">
+    <DisplayString>Size={occupied_and_removed_slots_ - removed_slots_}</DisplayString>
+    <Expand>
+      <CustomListItems>
+        <Variable Name="slot" InitialValue="slots_.data_"/>
+        <Variable Name="i" InitialValue="0"/>
+        <Loop>
+          <Break Condition="i &gt;= occupied_and_removed_slots_ - removed_slots_"/>
+          <If Condition="slot-&gt;state_ == 1">
+            <Item Name="[{i}]">slot-&gt;key_buffer_</Item>
+            <Exec>++i</Exec>
+          </If>
+          <Exec>++slot</Exec>
+        </Loop>
+      </CustomListItems>
+    </Expand>
+  </Type>
+
   <Type Name="blender::TypedBuffer&lt;*,*&gt;">
     <DisplayString>{*($T1*)buffer_.buffer_.buffer_}</DisplayString>
+    <Expand>
+      <ExpandedItem>*($T1*)buffer_.buffer_.buffer_,nd</ExpandedItem>
+    </Expand>
   </Type>  
 </AutoVisualizer>
\ No newline at end of file