From b544199c566bbb9529b5925ce96ae2d2abbf04c1 Mon Sep 17 00:00:00 2001 From: Howard Trickey Date: Sun, 22 Jan 2023 10:28:12 -0500 Subject: [PATCH] Fix T102532: bevel spikes with loop slide. There's a compromise of a code parameter called BEVEL_GOOD_ANGLE, and bugs T44961, T86768, T95335, and this one, are all about problems with various values of that parameter. If an angle of an adjacent non-beveled edge is too close to that of the beveled edge, then you get spikes. The BEVEL_GOOD_ANGLE says that if you are within that angle difference, then no bevel happens. If the value is too small then one gets spikes for certain models people build; if the value is too large, then other people are annoyed that no bevel happens. Hopefully this compromise in this commit is the final one I will do before switching to Bevel v2, where none of this should be an issue. --- source/blender/bmesh/tools/bmesh_bevel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/bmesh/tools/bmesh_bevel.c b/source/blender/bmesh/tools/bmesh_bevel.c index d3888e31da6..9e17efb2cd0 100644 --- a/source/blender/bmesh/tools/bmesh_bevel.c +++ b/source/blender/bmesh/tools/bmesh_bevel.c @@ -1506,7 +1506,7 @@ static void offset_meet(BevelParams *bp, * Update: changed again from 0.0001f to fix bug T95335. * Original two bugs remained fixed. */ -#define BEVEL_GOOD_ANGLE 0.001f +#define BEVEL_GOOD_ANGLE 0.1f /** * Calculate the meeting point between e1 and e2 (one of which should have zero offsets),