From baeb314eb7c2d6c47e6def23973da87ef1717052 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Mon, 3 Jul 2023 18:14:45 +0200 Subject: [PATCH] Fix incorrect EXPECT_M4_NEAR Seems to be a copy-paste error: the first 3 columns were only compared as float3, not as float4. Only affected validness of regression tests which might have missed an actual mismatch between matrices. Likely, all tests were valid, and this change did not discover failures. --- tests/gtests/testing/testing.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/gtests/testing/testing.h b/tests/gtests/testing/testing.h index 98d2f15424b..88f8ea47aa5 100644 --- a/tests/gtests/testing/testing.h +++ b/tests/gtests/testing/testing.h @@ -58,9 +58,9 @@ const std::string &flags_test_release_dir(); /* bin/{blender version} in the bui #define EXPECT_M4_NEAR(a, b, eps) \ do { \ - EXPECT_V3_NEAR(a[0], b[0], eps); \ - EXPECT_V3_NEAR(a[1], b[1], eps); \ - EXPECT_V3_NEAR(a[2], b[2], eps); \ + EXPECT_V4_NEAR(a[0], b[0], eps); \ + EXPECT_V4_NEAR(a[1], b[1], eps); \ + EXPECT_V4_NEAR(a[2], b[2], eps); \ EXPECT_V4_NEAR(a[3], b[3], eps); \ } while (false);