From da43c42e40b51683af60b5657c857333203af554 Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Wed, 10 May 2023 15:27:27 -0400 Subject: [PATCH] Cleanup: Avoid redundant attribute adding in extrude node These attributes already exist, not need to use the "or_add" function. --- .../nodes/geometry/nodes/node_geo_extrude_mesh.cc | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc b/source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc index 375720b3058..1f49a0d0d96 100644 --- a/source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc @@ -533,8 +533,7 @@ static void extrude_mesh_edges(Mesh &mesh, if (ELEM(id.name(), ".corner_vert", ".corner_edge", ".edge_verts")) { return true; } - GSpanAttributeWriter attribute = attributes.lookup_or_add_for_write_span( - id, meta_data.domain, meta_data.data_type); + GSpanAttributeWriter attribute = attributes.lookup_for_write_span(id); bke::attribute_math::convert_to_static_type(meta_data.data_type, [&](auto dummy) { using T = decltype(dummy); @@ -934,8 +933,7 @@ static void extrude_mesh_face_regions(Mesh &mesh, if (ELEM(id.name(), ".corner_vert", ".corner_edge", ".edge_verts")) { return true; } - GSpanAttributeWriter attribute = attributes.lookup_or_add_for_write_span( - id, meta_data.domain, meta_data.data_type); + GSpanAttributeWriter attribute = attributes.lookup_for_write_span(id); bke::attribute_math::convert_to_static_type(meta_data.data_type, [&](auto dummy) { using T = decltype(dummy); @@ -1234,8 +1232,7 @@ static void extrude_individual_mesh_faces( if (ELEM(id.name(), ".corner_vert", ".corner_edge", ".edge_verts")) { return true; } - GSpanAttributeWriter attribute = attributes.lookup_or_add_for_write_span( - id, meta_data.domain, meta_data.data_type); + GSpanAttributeWriter attribute = attributes.lookup_for_write_span(id); bke::attribute_math::convert_to_static_type(meta_data.data_type, [&](auto dummy) { using T = decltype(dummy);