griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix 8 memory leaks from bad PyList_Append use

Browse Source
This commit is contained in:
Campbell Barton
2015-01-04 20:33:29 +11:00
parent e0db0f84ac
commit de6b546e15
6 changed files with 33 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/freestyle/intern/python/Interface0D/BPy_SVertex.cpp
View File

@@ -342,13 +342,14 @@ PyDoc_STRVAR(SVertex_normals_doc,
static PyObject *SVertex_normals_get(BPy_SVertex *self, void *UNUSED(closure))
{
PyObject *py_normals;
set< Vec3r > normals;
py_normals = PyList_New(0);
normals = self->sv->normals();
for (set< Vec3r >::iterator set_iterator = normals.begin(); set_iterator != normals.end(); set_iterator++) {
Vec3r v(*set_iterator);
PyList_Append(py_normals, Vector_from_Vec3r(v));
set< Vec3r > normals = self->sv->normals();
set< Vec3r >::iterator it;
py_normals = PyList_New(normals.size());
unsigned int i = 0;
for (it = normals.begin(); it != normals.end(); it++) {
Vec3r v(*it);
PyList_SET_ITEM(py_normals, i++, Vector_from_Vec3r(v));
}
return py_normals;
}