From df6d6c09329e313b963b94673c12bbbfb04e819a Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Thu, 17 Jul 2025 21:14:30 +0200 Subject: [PATCH] Refactor: Cycles: Use logging system for GPU error print Pull Request: https://projects.blender.org/blender/blender/pulls/142257 --- intern/cycles/device/cuda/device_impl.cpp | 5 ++--- intern/cycles/device/hip/device_impl.cpp | 5 ++--- intern/cycles/device/metal/device_impl.mm | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/intern/cycles/device/cuda/device_impl.cpp b/intern/cycles/device/cuda/device_impl.cpp index 583ee5f7b41..eb85b808684 100644 --- a/intern/cycles/device/cuda/device_impl.cpp +++ b/intern/cycles/device/cuda/device_impl.cpp @@ -49,9 +49,8 @@ void CUDADevice::set_error(const string &error) Device::set_error(error); if (first_error) { - fprintf(stderr, "\nRefer to the Cycles GPU rendering documentation for possible solutions:\n"); - fprintf(stderr, - "https://docs.blender.org/manual/en/latest/render/cycles/gpu_rendering.html\n\n"); + LOG_ERROR << "Refer to the Cycles GPU rendering documentation for possible solutions:\n" + "https://docs.blender.org/manual/en/latest/render/cycles/gpu_rendering.html\n"; first_error = false; } } diff --git a/intern/cycles/device/hip/device_impl.cpp b/intern/cycles/device/hip/device_impl.cpp index 7e4535b2922..20bb009313e 100644 --- a/intern/cycles/device/hip/device_impl.cpp +++ b/intern/cycles/device/hip/device_impl.cpp @@ -48,9 +48,8 @@ void HIPDevice::set_error(const string &error) Device::set_error(error); if (first_error) { - fprintf(stderr, "\nRefer to the Cycles GPU rendering documentation for possible solutions:\n"); - fprintf(stderr, - "https://docs.blender.org/manual/en/latest/render/cycles/gpu_rendering.html\n\n"); + LOG_ERROR << "Refer to the Cycles GPU rendering documentation for possible solutions:\n" + "https://docs.blender.org/manual/en/latest/render/cycles/gpu_rendering.html\n"; first_error = false; } } diff --git a/intern/cycles/device/metal/device_impl.mm b/intern/cycles/device/metal/device_impl.mm index 9043fece025..218183a0af4 100644 --- a/intern/cycles/device/metal/device_impl.mm +++ b/intern/cycles/device/metal/device_impl.mm @@ -60,9 +60,8 @@ void MetalDevice::set_error(const string &error) Device::set_error(error); if (!has_error) { - fprintf(stderr, "\nRefer to the Cycles GPU rendering documentation for possible solutions:\n"); - fprintf(stderr, - "https://docs.blender.org/manual/en/latest/render/cycles/gpu_rendering.html\n\n"); + LOG_ERROR << "Refer to the Cycles GPU rendering documentation for possible solutions:\n" + "https://docs.blender.org/manual/en/latest/render/cycles/gpu_rendering.html\n"; has_error = true; } }