From e6f1cd6a29804f383824d2b2ab522ad34d48838f Mon Sep 17 00:00:00 2001 From: Nathan Vegdahl Date: Mon, 6 Oct 2025 03:46:54 +0200 Subject: [PATCH] Anim: remove deprecated `XYZ_TO_RGB` flag on `keyframe_insert()` The `INSERTKEY_XYZ_TO_RGB` flag on `datablock.keyframe_insert()` in Blender's Python API was changed to do nothing in #115297 and #119625, in favor of determining fcurve coloring exclusively from user preferences. This PR removes that now-useless `INSERTKEY_XYZ_TO_RGB` flag entirely. Pull Request: https://projects.blender.org/blender/blender/pulls/147262 --- source/blender/makesrna/intern/rna_animation.cc | 12 ------------ source/blender/python/intern/bpy_rna_anim.cc | 3 --- 2 files changed, 15 deletions(-) diff --git a/source/blender/makesrna/intern/rna_animation.cc b/source/blender/makesrna/intern/rna_animation.cc index 4643a69f5ee..6bbef8d89cd 100644 --- a/source/blender/makesrna/intern/rna_animation.cc +++ b/source/blender/makesrna/intern/rna_animation.cc @@ -50,12 +50,6 @@ const EnumPropertyItem rna_enum_keying_flag_items[] = { 0, "Visual Keying", "Insert keyframes based on 'visual transforms'"}, - {0, - "INSERTKEY_XYZ_TO_RGB", - 0, - "XYZ=RGB Colors (ignored)", - "This flag is no longer in use, and is here so that code that uses it doesn't break. The " - "XYZ=RGB coloring is determined by the animation preferences."}, {0, nullptr, 0, nullptr, nullptr}, }; @@ -71,12 +65,6 @@ const EnumPropertyItem rna_enum_keying_flag_api_items[] = { 0, "Visual Keying", "Insert keyframes based on 'visual transforms'"}, - {0, - "INSERTKEY_XYZ_TO_RGB", - 0, - "XYZ=RGB Colors (ignored)", - "This flag is no longer in use, and is here so that code that uses it doesn't break. The " - "XYZ=RGB coloring is determined by the animation preferences."}, {INSERTKEY_REPLACE, "INSERTKEY_REPLACE", 0, diff --git a/source/blender/python/intern/bpy_rna_anim.cc b/source/blender/python/intern/bpy_rna_anim.cc index b3f6d765d9a..048de7f92fd 100644 --- a/source/blender/python/intern/bpy_rna_anim.cc +++ b/source/blender/python/intern/bpy_rna_anim.cc @@ -314,9 +314,6 @@ char pyrna_struct_keyframe_insert_doc[] = " - ``INSERTKEY_NEEDED`` Only insert keyframes where they're needed in the relevant " "F-Curves.\n" " - ``INSERTKEY_VISUAL`` Insert keyframes based on 'visual transforms'.\n" - " - ``INSERTKEY_XYZ_TO_RGB`` This flag is no longer in use, and is here so that code " - "that uses it doesn't break. The XYZ=RGB coloring is determined by the animation " - "preferences.\n" " - ``INSERTKEY_REPLACE`` Only replace already existing keyframes.\n" " - ``INSERTKEY_AVAILABLE`` Only insert into already existing F-Curves.\n" " - ``INSERTKEY_CYCLE_AWARE`` Take cyclic extrapolation into account "