griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #143534: Grease Pencil: Grid snapping problem with bezier points or proportional editing

Browse Source 
When the median was being calculated, the division was by the total number of transform data, rather than the selected number of transform data.
Under most circumstances this would be the same, but when transforming bezier control points without the handles selected, or when having proportional editing on. This the median calculation would return a wrong result.

Note: This problem could occur almost every object type not just Grease Pencil.

Resolves: #143534

Pull Request: https://projects.blender.org/blender/blender/pulls/144245
This commit is contained in:
Casey Bianco-Davis
2025-08-09 12:28:34 +02:00
committed by Falk David
parent a459556ebd
commit eb651bb243
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/editors/transform/transform_snap.cc
View File

@@ -1402,14 +1402,18 @@ void tranform_snap_target_median_calc(const TransInfo *t, float r_median[3])
float v[3];
zero_v3(v);
tc->foreach_index_selected([&](const int i) { add_v3_v3(v, tc->data[i].center); });
int num_selected = 0;
tc->foreach_index_selected([&](const int i) {
add_v3_v3(v, tc->data[i].center);
num_selected++;
});
if (tc->data_len == 0) {
if (num_selected == 0) {
/* Is this possible? */
continue;
}
mul_v3_fl(v, 1.0 / tc->data_len);
mul_v3_fl(v, 1.0 / num_selected);
if (tc->use_local_mat) {
mul_m4_v3(tc->mat, v);