griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #146250: Some gizmos/widgets are continuously running updates

Browse Source 
Reported for the geometry nodes gizmos, but in general `cage2d`,
`cage3d` and `arrow` were affected (so for example Forcefield arrows, UV
editing transform tool, Lamp angle gizmo, ...)

`gizmo_cage3d_modal`, `gizmo_cage2d_modal` and `gizmo_arrow_modal` add a
`WM_event_add_mousemove` which ... lets the modal run even if the mouse
does **not** move...

This seems to date back to d8f931c9b7 in the arrow gizmo, others
probably just copied from there (not the DialGizmo though), did not do
further git archeology.

Propose to just remove `WM_event_add_mousemove` (even though there
_might_ still be reasons for this -- could not spot any though...)

Pull Request: https://projects.blender.org/blender/blender/pulls/146310
This commit is contained in:
Philipp Oeser
2025-10-17 10:21:01 +02:00
committed by Philipp Oeser
parent 6536fd80fc
commit fca5bcbe46
3 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.cc
View File

@@ -412,7 +412,6 @@ static wmOperatorStatus gizmo_arrow_modal(bContext *C,
/* tag the region for redraw */ /* tag the region for redraw */
ED_region_tag_redraw_editor_overlays(region); ED_region_tag_redraw_editor_overlays(region);
WM_event_add_mousemove(CTX_wm_window(C));
return OPERATOR_RUNNING_MODAL; return OPERATOR_RUNNING_MODAL;
} }

1
source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.cc
View File

@@ -1360,7 +1360,6 @@ static wmOperatorStatus gizmo_cage2d_modal(bContext *C,
/* tag the region for redraw */ /* tag the region for redraw */
ED_region_tag_redraw_editor_overlays(CTX_wm_region(C)); ED_region_tag_redraw_editor_overlays(CTX_wm_region(C));
WM_event_add_mousemove(CTX_wm_window(C));
return OPERATOR_RUNNING_MODAL; return OPERATOR_RUNNING_MODAL;
} }

1
source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.cc
View File

@@ -590,7 +590,6 @@ static wmOperatorStatus gizmo_cage3d_modal(bContext *C,
/* tag the region for redraw */ /* tag the region for redraw */
ED_region_tag_redraw_editor_overlays(CTX_wm_region(C)); ED_region_tag_redraw_editor_overlays(CTX_wm_region(C));
WM_event_add_mousemove(CTX_wm_window(C));
return OPERATOR_RUNNING_MODAL; return OPERATOR_RUNNING_MODAL;
} }