Commit Graph

75472 Commits

Author SHA1 Message Date
Campbell Barton
609d4f5c92 Fix T60354: Paint color shown when not used
Add 'has_color' check to avoid duplicated tool checks.

Also abbreviate text descriptions.
2019-01-10 10:12:23 +11:00
Campbell Barton
eb3886c7ac Cleanup: sort RNA types after ename 2019-01-10 09:58:04 +11:00
Campbell Barton
5100e4419e Cleanup: ensure header guards come first
Causes clang-format not to detect header guards,
indenting all preprocessor lines in the header.
2019-01-10 09:04:44 +11:00
Campbell Barton
5681631109 Cleanup: ensure header guards come first
Causes clang-format not to detect header guards,
indenting all preprocessor lines in the header.
2019-01-10 08:46:38 +11:00
Campbell Barton
f87b93a567 Fix T55336: Crash w/ dyntopo sculpt 2019-01-10 08:03:25 +11:00
Campbell Barton
399fd54f88 Undo System: apply accumulation steps
Apply steps between the active and the undo state being decoded.
2019-01-10 08:03:18 +11:00
Campbell Barton
99d001a10f Fix sculpt redo failing to enable dyntopo 2019-01-10 08:03:09 +11:00
Campbell Barton
7f5bae28db Fix memfile undo decoding creating undo steps
Exiting modes shouldn't be needed since loading the new memfile
will free the old data.

Sculpt mode dynamic topology was adding undo data on exiting the mode
which isn't logical in this case and can be avoided altogether.
2019-01-10 08:02:51 +11:00
Campbell Barton
ea0abf52bf Fix T59165: Text operations fail to undo
Some undo operations encode multiple actions, now all are undone/redone.
2019-01-10 08:01:50 +11:00
Antonioya
513bc5954c Fix T60351: Blender crashes when using fill tool without existent keyframe 2019-01-09 16:39:07 +01:00
Bastien Montagne
90e354fd7a Revert/Redo ugly rBd12b3767f81d commit (i.e. add locked sorting option to UIList).
Too many things done wrong in original rBd12b3767f81d to list them all
here, hopefully nothing bad sneaked in again this time :|

Also cleaned up a little the 'sort by name', even though (since we only
have two options by default, sort by index and by name) we can abuse it
as a binary option for now, this is not a bitflag...
2019-01-09 15:51:46 +01:00
Brecht Van Lommel
1c42f1c5ca Fix T60324: node linking UI bugs with some shader nodes. 2019-01-09 14:35:48 +01:00
Bastien Montagne
56ceaea5b5 Fix T60244: Bisect in mirror modifier doesn't work properly.
That was indeed not working properly, not at all. Except for
the basic case, but as soon as you used another object to define the
mirror plane, it would be utterly broken, in several different ways!
2019-01-09 13:28:34 +01:00
Jacques Lucke
22ddd57363 Fix T60338: Allow user to input units of another system 2019-01-09 10:40:05 +01:00
Campbell Barton
06d1c2f737 Fix T55336: Crash w/ dyntopo sculpt 2019-01-09 20:27:02 +11:00
Campbell Barton
3cbe2a19df Undo System: apply accumulation steps
Apply steps between the active and the undo state being decoded.
2019-01-09 20:21:24 +11:00
Campbell Barton
ef33215bb7 Fix sculpt redo failing to enable dyntopo 2019-01-09 18:10:16 +11:00
Campbell Barton
7e6d7d53cf Fix memfile undo decoding creating undo steps
Exiting modes shouldn't be needed since loading the new memfile
will free the old data.

Sculpt mode dynamic topology was adding undo data on exiting the mode
which isn't logical in this case and can be avoided altogether.
2019-01-09 17:37:13 +11:00
Campbell Barton
9012ad155c Fix T59165: Text operations fail to undo
Some undo operations encode multiple actions, now all are undone/redone.
2019-01-09 16:08:40 +11:00
Campbell Barton
a4d21441f9 Avoid assert w/ recent sculpt changes on undo 2019-01-09 13:25:23 +11:00
Campbell Barton
4069b10be8 Fix swapped active/selected lattice vertex color 2019-01-09 13:09:03 +11:00
Campbell Barton
34143a9e7a WM: add keymap.find_from_operator(...) 2019-01-09 12:26:10 +11:00
Campbell Barton
d615203342 Fix IS_EVENT_ACTIONZONE macro
Caused tweak events not to display.
2019-01-09 12:22:32 +11:00
Campbell Barton
3c3d80ea22 Assert: add check to last commit 2019-01-09 10:33:36 +11:00
Campbell Barton
b536d1b95f Object Mode: only toggle active object mode once
- When toggling a mode that doesn't support multi editing
  only do this once of the active object.

- For sculpt mode create sculpt data since this is needed
  for activating other sculpt objects on reload.
2019-01-09 10:21:51 +11:00
Campbell Barton
1b6b0fbd95 Fix T60044: Sculpting brush is not visible
Same logic as fix from D4153, but only applied when running undo.
2019-01-09 09:12:57 +11:00
Dalai Felinto
583c321334 Revert "Fix T60044: Sculpting brush is not visible on file load"
This reverts commit 4d8ed937f2.

An alternative fix will come soon as a patch, since this introduced an issue.
Rolling back since the original fix (sculpt cursor on load) is less important
than the issue it introduced (crash on weight paint undo/redo).

Fix T60322.
2019-01-08 18:31:36 -02:00
Jacques Lucke
12e9d52882 Fix T60327: Value input with adaptive imperial units not working properly 2019-01-08 19:20:56 +01:00
Brecht Van Lommel
ae2af46920 Fix inconsistent naming and behavior for base visible/selected/editable.
Fixes T60251.
2019-01-08 18:50:44 +01:00
Campbell Barton
369e1d46f0 Fix T56545: Material referencing missing UV crash 2019-01-09 01:05:43 +11:00
Philipp Oeser
22474062b1 Fix T58479: Quick Favorites Lets you add multiple of the same item
Reviewers: brecht

Maniphest Tasks: T58479

Differential Revision: https://developer.blender.org/D4135
2019-01-08 14:47:05 +01:00
Joshua Leung
395120ed72 Typo fixes 2019-01-09 01:41:58 +13:00
Joshua Leung
9d4ed6d03b Fix T59984: Drivers don't update values in UI or show proper errors
We now perform COW -> original data flushing for all the debug values + error
status flags on Drivers/DriverVariables/DriverTargets, as these are only set
when errors are encountered when evaluating drivers.
2019-01-09 01:41:58 +13:00
Campbell Barton
b4bb9d59ee Fix T59450: brush colors flip inactive w/ texture paint 2019-01-08 23:25:36 +11:00
Brecht Van Lommel
152c965b75 Fix T60263: render layer node sockets not showing on file load, for some files. 2019-01-08 13:21:39 +01:00
Sybren A. Stüvel
e11bb77f31 Properly clean up Python when exiting due to --python-exit-code
When BPY_python_end() is not called, there can be buffered data still in
`sys.stdout` or `sys.stderr`. This generally isn't an issue when those are
connected to a terminal, but when they are read by another process (in the case
of rendering with Flamenco, for example) we could miss the actual error message
that's causing the exit in the first place.

The following script demonstrates the issue; before this commit neither the
writes to STDERR and STDOUT nor the traceback of the NameError were shown.

    #!/bin/bash

    cat > file-with-errors.py <<EOT
    import sys
    print('THIS IS STDERR', file=sys.stderr)
    print('THIS IS STDOUT', file=sys.stdout)
    nonexisting.monkey = 3
    EOT

    blender --enable-autoexec -noaudio --background \
	any-existing-blendfile.blend \
	--python-exit-code 42 \
	--python file-with-errors.py 2>&1 | cat

Reviewers: campbellbarton, mont29

Reviewed By: campbellbarton, mont29

Subscribers: fsiddi

Differential Revision: https://developer.blender.org/D4168
2019-01-08 12:00:18 +01:00
Sergey Sharybin
68b4c57ba5 Merge branch 'blender2.7' 2019-01-08 11:47:35 +01:00
Sergey Sharybin
1e386d98ce Make DNA and RNA errors more meaningful and friendly 2019-01-08 11:43:15 +01:00
Philipp Oeser
a0d456daf8 Vertex Paint: support vertex masking
Working in 2.7x, was just disabled in 2.8x.

Fixes T60256
2019-01-08 15:18:28 +11:00
Campbell Barton
91a155833e Cleanup: comments causing bad clang-format output 2019-01-08 10:37:43 +11:00
Sergey Sharybin
b2a0ffc95f Fix bad enum value since 299ff7dcd1
This is why out-sourcing things to a production-tested formatters
is a very very good idea.
2019-01-07 17:18:33 +01:00
Sergey Sharybin
8e35a968c5 Subdiv: Use defined order of corner/edge vertices
This switches evaluation of vertices which are on the boundaries
of PTex faces to a single threaded one. While this introduces
some slowdown it fixes ambiguity of PTex index used to evaluate
particular vertex.

Possible alternative solutions would be:
- Do some pre-calculation of index, then do evaluation in threads.
- Try using Gregory patches and see if that makes any affect.

Fix T60235: Flickering of object instances
2019-01-07 17:14:19 +01:00
Sergey Sharybin
e637e8dcc6 Subdiv: Move single threaded code to a single function
Allows to more easily add more passes which are supposed to be run
from a single thread.
2019-01-07 17:14:19 +01:00
Sergey Sharybin
1b15eb7e71 Subdiv: Cleanup, de-duplicate code 2019-01-07 17:14:19 +01:00
Alexander Gavrilov
43a2a73fdb Fix missing updates when muting/soloing/reordering NLA tracks. 2019-01-07 17:35:51 +03:00
Campbell Barton
299ff7dcd1 Cleanup: corrections to last commit 2019-01-08 01:00:40 +11:00
Campbell Barton
5a43406e1b Cleanup: move DNA comments before struct members
Needed for clang-format in some cases, see: T53211
2019-01-08 00:43:00 +11:00
Bastien Montagne
0215caeac2 Cleanup: fix typo. 2019-01-07 14:30:45 +01:00
Howard Trickey
b786416106 Fix T59151 Bevel modifier has bad input width for percent.
The units scaling was inappropriate when the bevel value was
to be interpreted as a percent, so added a separate rna property
for "Width Percent" and made UI show the width appropriate for
current offset_type.
2019-01-07 07:29:54 -05:00
Bastien Montagne
cfeffa7529 Fix T60247: app.handlers.undo_post calls undo_pre's function.
Undo and redo post were actually calling respective pre funcs...
2019-01-07 09:53:46 +01:00