Commit Graph

60 Commits

Author SHA1 Message Date
Jeroen Bakker
ac5a735e3f * FIX for
- [#31777] Border Crop gives black 
   - [#31768] Crash when connecting a Math node to a translate node in Tiles comp
   - [#31638] View node in new node compo system crashes when inside a group
 * make sure a very fast vignette can be made by using a EliipseMask + Fast Gaussian blur
2012-06-12 04:23:21 +00:00
Campbell Barton
5248ec57d9 minor fixes
- new compositor could use uninitialized var
- profile conversion could use uninitialized var
- set better warnings for clang+cmake.
- remove picky warnings from sphinx doc gen shell script.
2012-06-11 12:13:41 +00:00
Jeroen Bakker
8a5252c1cb * Blur node had some irregularities at the edge of the screen
only visible when doing large size blurs.
 also solved the catcom/mitch filter that didn't work at low/medium quality

 PS never use BokehBlur Gausian filter as it is 99%+ identicat as non bokeh <= top for sergey- :)
2012-06-11 08:28:04 +00:00
Campbell Barton
9c504f6db2 correct freeing C++ arrays. 2012-06-10 20:14:15 +00:00
Lukas Toenne
7496a58cfb Applied and completed a compositor patch by Brecht to use signalling and waiting in scheduling and worker threads instead of continuous loops with sleep times. This should help reduce unnecessary wait times in Tile. 2012-06-10 12:26:33 +00:00
Lukas Toenne
18a966293e Fix for Tile group nodes with internally unconnected outputs, this was crashing due to missing constant value operations for such outputs. The SocketProxyNode now checks connection of the input socket on conversion, so this also simplifies usage of proxy nodes quite a bit. 2012-06-10 09:30:31 +00:00
Campbell Barton
8e7d7d5ea5 code cleanup: reduce float/double promotion 2012-06-09 19:57:14 +00:00
Jeroen Bakker
de7fe937ff * Added OpenCL kernel for bokeh blur
* Uncomment COM_OPENCL_ENABLED from COM_defines.h to test
2012-06-08 09:17:07 +00:00
Campbell Barton
bdf9e02346 new sequence strip type for masks. 2012-06-07 18:24:36 +00:00
Campbell Barton
5189356d58 style cleanup 2012-06-04 20:11:09 +00:00
Jeroen Bakker
5024996eea * modified vieweroperation to not calculate based on the DO_NODE_OUTPUT
flag of the editorbNode.
2012-06-04 18:07:29 +00:00
Campbell Barton
68a9dd54ec mask mode for clip editor developed by Sergey Sharybin, Pete Larabell and myself.
see:
http://wiki.blender.org/index.php/User:Nazg-gul/MaskEditor


note - mask editing tools need continued development, feather option is not working 100%
2012-06-04 16:42:58 +00:00
Campbell Barton
489fa2d108 remaining mask files from tomato. these wont get svn history carried over. 2012-06-04 15:49:58 +00:00
Sergey Sharybin
f53a52ba1c Fix #31697: Blender crashes when using several viewer nodes in tile
Issue was caused by fact that viewer node might re-size ImBuf used for
viewer node result, so if several viewer nodes are running for inputs
with different resolutions it'll result in a crash,

Now copied behavior or pre-tile compositor -- execute viewer node which
has NODE_DO_OUTPUT flag, so no several nodes would be calculated at once.

Should be pretty ok because calculation of several viewers doesn't actually
make sense because there's only one buffer they might use and it's getting
re-calculated when changing active viewer node.
2012-06-04 13:19:17 +00:00
Sergey Sharybin
0f2b4d4dff Fix for relative blur size for non-fast gaussian blur methods.
Call base blur's initExecution from GaussianBokehBlurOperation and GaussianXBlurOperation
2012-06-04 10:51:00 +00:00
Campbell Barton
5e424cacb5 minor optimizations to compositor, avoid indirections when operating array members multiple times 2012-06-03 16:23:47 +00:00
Thomas Dinges
c66f357168 Bugfix for [#31692] Blur Node (Flat) X size affects Y size, Y size does nothing
* GaussianYBlurOperation accessed sizex instead of sizey.
2012-06-03 15:44:11 +00:00
Campbell Barton
07ce209c64 code cleanup: warnings 2012-06-01 14:59:06 +00:00
Monique Dewanchand
5fbeda7efd Optimize Gaussian blurs 2012-06-01 11:50:32 +00:00
Jeroen Bakker
e9093c7011 Fixed crash
Previous patch allocated temporarily buffers.
2012-06-01 10:37:38 +00:00
Monique Dewanchand
285a24b3e0 Replaced tile based memory manager with a single aligned buffer
- should increase speed with large node setups
 - enables caching of buffers in the node editor (in the future)
 - OpenCL part still needs some work
2012-06-01 10:20:24 +00:00
Jeroen Bakker
a78dca27a2 Removed unused files in compositor 2012-06-01 08:01:04 +00:00
Monique Dewanchand
13714e621d Fix for [#31662] Compositing: No Alpha if image/color connected to second input of math node 2012-05-31 20:26:42 +00:00
Campbell Barton
02b927b8c4 style cleanup 2012-05-31 18:40:06 +00:00
Jeroen Bakker
b04cd3a765 Fix for [#31602] Node Glare: Ghosts effect 2012-05-31 13:05:00 +00:00
Jeroen Bakker
31a94e4003 Fix for [#31542] Tiles Compositor: Image sequences broken 2012-05-31 11:55:05 +00:00
Jeroen Bakker
a9c4f76a6a * Added new dilate/erode function 2012-05-31 10:38:11 +00:00
Monique Dewanchand
722ce85ff6 Fix for
[#31562] New compositor crashes due to incorrect opencl initialization
2012-05-30 21:09:50 +00:00
Jeroen Bakker
ada8dbe12a * fixed memory leak in compositor operation.
- leaked when render result could not be received.
2012-05-30 13:07:55 +00:00
Campbell Barton
27c6ab9857 fix incorrect delete usage in the compositor. 2012-05-30 09:15:02 +00:00
Jeroen Bakker
feb3dc926a Compositor filter node
* edges (x=0, x=width-1, y = 0 y=height-1) were not taken into acount
correctly
used CLAMP function to limit the filter operation to existing pixels
2012-05-29 14:38:28 +00:00
Jeroen Bakker
87d433d16c * Compositor Alpha channel was not effected by the ConvolutionFilters
(Filter:Sharpen, Filter:Soften, etc)
2012-05-29 14:25:28 +00:00
Jeroen Bakker
8a30382a8a * Compositor fix for OpenCL [OpenCL platform installed, but no
available devices]
   - could happen when having laptops with a hard switch between video
cards (intel/NVidia switch)
   - or when an opencl platform was installed on a machine without any
OpenCL compatible GPU
2012-05-29 14:13:08 +00:00
Sergey Sharybin
8c51ecaf90 Use BKE_movieclip_get_size rather than BKE_movieclip_get_ibuf and use ibuf's resolution in tile's Movie Clip node 2012-05-27 14:30:45 +00:00
Sergey Sharybin
2a7b4adedc Fix mistmatch in usage of delete vs. delete [] in tiles reported by valgrind profiler. 2012-05-27 14:17:34 +00:00
Brecht Van Lommel
09344fb102 Fix new compositor color to value/bw conversion working different than it did
before. It doesn't make much sense to always multiply with alpha, especially
if it's a premul image that already has it multiplied in.

Patch by Irie Shinsuke.
2012-05-24 14:19:20 +00:00
Jeroen Bakker
5f677f995d * removed clamp from color correction 2012-05-24 06:16:05 +00:00
Campbell Barton
7505102668 style cleanup: also correct comment 2012-05-23 17:26:49 +00:00
Jeroen Bakker
9b45f607c9 cleanup relink code 2012-05-23 12:45:07 +00:00
Jeroen Bakker
a4257c8880 * Stopped flickering of preview images
* Solved crash when first input socket of brightness node is not
connected
2012-05-23 10:31:16 +00:00
Jeroen Bakker
dbd70c05f7 * Composite result is updated when editing (preview were already
calculated, now the final result is also updated in the image space
 * default texture size when not connected to any resolution depended
operation defaults to render size
2012-05-22 09:54:08 +00:00
Sergey Sharybin
d3067dfaa2 Fix imbuf users leak in MovieClip tiles node
Leak was caused by not calling IMB_freeImBuf for result of BKE_movieclip_get_ibuf
2012-05-22 09:15:05 +00:00
Sergey Sharybin
1ae3929138 Fix for movie distoriton node in tiles
Now it works in the same way as non-tiles node in cases when image's
resolution is not equal to resolution used for calibration.

Also add some additional checks for distortion cache, so now it should
be updating properly when camera intrinsics are changing.

Potentially added support of overscan, but currently all needed computation
is commented out.
2012-05-22 09:15:01 +00:00
Campbell Barton
72f38b4f09 style cleanup: brace placement. 2012-05-22 06:29:46 +00:00
Jeroen Bakker
564711418d Fix for [#31418] Code review: OpenCL initialization
* Moved OpenCL initialization to first use
 * cleaned up build files
 * display some debug lines only when debugging is enabled.
2012-05-21 19:31:29 +00:00
Jeroen Bakker
081f3dd9fa fix for [#31543] Nodes use array past bounds 2012-05-21 16:05:45 +00:00
Jeroen Bakker
c55bb6eae2 * Bokeh Image angle now has rnge from -720 to +720 degrees 2012-05-21 14:05:47 +00:00
Jeroen Bakker
998a850f9f Added switch in dilate/erode between old (Step) and new (Distance)
algorithm

Connected the Glare Fog Flow to use Fast Gaussian in stead of Bokeh blur
2012-05-21 10:20:30 +00:00
Peter Schlaile
f8c1a71f24 == Compositor ==
This fixes occasional crashes on uninitialized memory, when we open a blend 
file which has movie or image input nodes pointing to none existent 
source files.
2012-05-20 21:24:08 +00:00
Campbell Barton
ed679693c9 style cleanup: whitespace/indentation 2012-05-19 13:55:54 +00:00