Commit Graph

1299 Commits

Author SHA1 Message Date
Joshua Leung
ff6bf133ad Fix T37811: Delete key shortcut missing for deleting markers
The keymap here used WM_keymap_verify_item(), which only allows for a
single hotkey to be bound to an operator. In most cases, this really
isn't justified.
2013-12-14 13:42:42 +13:00
Campbell Barton
ac38f2584f Code Cleanup: replace ABS() with fabsf() when used with float expressions. 2013-12-01 13:11:12 +11:00
Brecht Van Lommel
cedc90b607 Fix errors and inconsistencies in confirmation popup removal.
* Improve some clip editor messages
* Remove popup for metastrips, seems unnecessary
* Renamed some variables for consistency
* Avoid unnecessary call to CTX_DATA_COUNT

Reviewed By: sergey, campbellbarton, aligorith

Differential Revision: http://developer.blender.org/D44
2013-11-29 17:49:01 +01:00
Campbell Barton
63caaa2b12 Code Cleanup: rename vars for detecting change to be more consistent
rename change/is_change/is_changed/modified -> changed
also use bools over int/short/char and once accidental float.
2013-11-26 06:39:14 +11:00
Emanuel Claesson
3ca4387bc8 UI: remove unnecessary confirmation popups
This makes a number of operators no longer ask for confirmation, rather it will
show an info message after performing the operation. Ref T37422 for decision. In
particular, these were changed:

* Delete objects, bones, keyframes, masks, mask curves, motion tracks, markers.
* Clear and delete keyframes in the 3D view.
* Align bone to parents.
* Separate bones from armature.
* Group/ungroup metastrips in sequencer.
* Copy/paste objects to/from buffer.

Reviewed By: brecht, dingto

Differential Revision: http://developer.blender.org/D35
2013-11-25 12:21:45 +01:00
Joshua Leung
1d33098314 More short->bool refactoring work for anim channel type define callbacks
Changed the "neg" flag for acf.setting_flag() to be a bool
2013-11-23 18:59:21 +13:00
Joshua Leung
ff66f3d3ad Anim Editors: Refactored animchannel type definition callbacks to use bools
Changes:
- acf.name_prop() and acf.has_setting() now return bools instead of shorts
- Renamed a few name_prop() callbacks whose names ended in "_nameprop"
  instead of "_name_prop", which made it difficult to safely find all
  such instances
2013-11-23 18:59:21 +13:00
Joshua Leung
efdd4894e9 NLA Channel Drawing Refactor: Remove rest of old drawing code for NLA Track channels
NLA Track drawing has now been ported over to use the UI widgets
like the rest of the anim channels do in the DopeSheet and Graph
Editors. The main benefit of this for users is that these buttons
will now show tooltips when you hover over them. Hopefully this
will help make the "solo" buttons more discoverable.

I've decided to postpone porting the "Action Line" channels to the
widget system for now, since there are quite a few more issues there
which need quite a bit more time to work through.
2013-11-21 01:33:02 +13:00
Joshua Leung
905085228f Anim Editors: Ensure that "solo" flag doesn't get accidentally handled on channels which don't support it 2013-11-21 01:33:02 +13:00
Joshua Leung
96a4ee725e Anim Editors: Improve some tooltips to be more accurate for the type of editor/data they're shown for
This commit fixes some problems where some tooltips were not adapting
as intended when used for different channel types in different places.
2013-11-21 01:33:02 +13:00
Joshua Leung
be971959bc Added button callback so that toggling solo mode on NLA Tracks now works correctly 2013-11-21 01:33:02 +13:00
Joshua Leung
5efad6f6c6 Ported code for setting colour of NLA Track anim channel 2013-11-21 01:33:02 +13:00
Joshua Leung
eb72712485 Ported over logic for which animchannel settings are supported by NLA Tracks 2013-11-21 01:33:02 +13:00
Joshua Leung
2f88fc35de Skeleton of type defines for NlaTrack animchannel 2013-11-21 01:33:01 +13:00
Joshua Leung
c4bb2e9774 Updating icons for NLA Track "solo" button (as used in standard widgets) 2013-11-21 01:33:01 +13:00
Joshua Leung
a8a4431fcf Bugfix [#36687] Animation channels can't be grouped in action editor
Internal filtering flags used to obtain AnimData blocks as result were not
working correctly in Action and ShapeKey modes. Instead, in these modes, they
were often returning F-Curves instead, which lead to the grouping operating
failing (and perhaps other unidentified bugs)
2013-11-02 13:11:06 +00:00
Campbell Barton
f9d5bccb06 code cleanup: spelling 2013-10-31 23:52:44 +00:00
Campbell Barton
beae4f498d code cleanup: spelling 2013-10-31 14:10:01 +00:00
Campbell Barton
7267221715 remove return argument from wmOperatorType->cancel, was only ever returning OPERATOR_CANCELLED. 2013-10-30 23:08:53 +00:00
Campbell Barton
bced18155f fix for uninitialized value use in newly added fcurve normalized view.
also quiet warning without openmp.
2013-10-30 22:13:28 +00:00
Sergey Sharybin
16d13e0db9 Project Pampa request: FCurves normalized display
Added two options to a header of FCurve editor:

- Normalize which makes it so every individual
  curve is fit into -1..1 space.

- Auto-normalize, which probably is to be called
  "Lock" which "locks" curve normalization scale.
  This is useful to prevent curves from jumping
  around when tweaking it.

It's debatable whether it need to be a button to
normalize curves n purpose only, and it's fully
depends on animator's workflow.

Here during Project Pampa we've got Francesco
who get used to auto-renormalization and Hjalti
who prefers locked behavior.

Docs are to be ready soon by Francesco.
Thanks Brecht for the review!
2013-10-29 18:10:52 +00:00
Sergey Sharybin
f6e504cee9 Make anim system safer for threading
Remove usages of ANIM_unit_mapping_apply_fcurve in favor of
runtime scale factor apply.

There're still calls to ANIM_nla_mapping_apply_fcurve are
hanging around, they're the next t be cleaned up!
2013-10-29 18:10:48 +00:00
Campbell Barton
304a32bf1f style cleanup 2013-10-23 02:52:27 +00:00
Bastien Montagne
67e262069a Minor UI messages fixes. 2013-10-22 08:21:00 +00:00
Joshua Leung
2454793190 DopeSheet Group Select => Bone Select Tweak: Don't change selection status of
bones if "Only Selected" dopesheet filter is enabled.

When this was enabled, it would be too easy to accidentally change the selected
bones, causing the keyframes you were just editing to disappear
2013-10-22 06:24:47 +00:00
Bastien Montagne
5d132e722e Followup to r60857: code was assuming markers were sorted, which is not guaranted. Also heavily simplified it (previous code was supposed to have optimizations, but ended just looping twice over the markers' list...).
Many thanks to Brecht and Sergey for noting the quirk and reviews! :)
2013-10-21 14:40:14 +00:00
Sergey Sharybin
f023fcf535 Project Pampa request: show curves for node grupps
It was not implemented in anim filter yet.

it's strictly speaking not so much clear how
"selected only" mode is expected to work when
having multiple node trees editing at the same
time. For now all the animation data from
selected group will be displayed.
2013-10-20 17:53:29 +00:00
Bastien Montagne
e401fef6b7 Fix [#37146] Dopesheet / Graph editor, select columns between markers doesn't appear to work.
Init min/max values were just switched...
2013-10-19 13:39:27 +00:00
Joshua Leung
1263a0891c Project Pampa Request: Selecting groups in animation editors selects
corresponding bones
2013-10-17 14:19:03 +00:00
Bastien Montagne
ef765b3606 Fix [#37077] User prefs > Input and Outliner Keymaps mismatch in representation.
Remove KeyMap mode from outliner, was an old half-finished features redondant with user preferences settings...

Also moved key map item's "event type to map type" and map type defines at WM level, this is too much generic to be at RNA level.

Also added a check in versionning code to convert all outdated outliner modes to a valid one (seems old 'verse' ones were not handled as well).

Thanks to Brecht for reviews and advices!
2013-10-15 13:55:06 +00:00
Sergey Sharybin
ee63ef7af1 Project Pampa request: option to lock frame selection to the range
This means when you've got "Lock Frame Selection" option (which is
in the timeline next to the preview range button) you're not able
to go to the frames which are out of current frame range with your
mouse.

TODO: Make it so current frame slider also respects this setting?
      Not so much important for tonight.
2013-10-13 20:46:02 +00:00
Campbell Barton
de3f6b3ec1 re-enable activating the text input field for new popup dialog boxes,
I'd disabled this for 2.68 since it caused bug [#36109].

This fix now only enabled text activation for popups. (so the toolbar textboxes are skipped)
2013-10-09 14:35:25 +00:00
Campbell Barton
ba01e5e3eb fix [#36919] Cannot delete keyframe of animated simulation parameter if simulation has been disabled 2013-10-02 16:37:47 +00:00
Joshua Leung
8e70db78f4 Bugfix: All actions created when keyframing now have their "id-root" set appropriately
This means that it will no longer be possible to accidentally load a nodetree action in
the Action Editor (object-level actions only), resulting in F-Curves getting 
invalidated/disabled.
2013-10-02 12:14:50 +00:00
Campbell Barton
f1f7648d4c fix for error setting vector handles to free when both vector handles were selected but not the mid-point.
only one of the handles would be changed to the HD_FREE.

effected curves and fcurves.
2013-10-01 08:18:43 +00:00
Campbell Barton
b6ea073af2 more fixes relating to [#36878], freestyle was only checking for NULL linestyles in some places. 2013-09-30 09:28:43 +00:00
Campbell Barton
abb37f4152 replace RNA_property_array_length with RNA_property_array_check where the length of the array is only used to check if the property is an array or not.
(this isnt reliable since arrays can be zero length).
2013-09-16 01:35:52 +00:00
Brecht Van Lommel
9c4eaa9b72 Fix metaball f-curves not showing up in graph editor. 2013-09-05 16:15:01 +00:00
Tamito Kajiyama
af9a6aad99 Fix for redundant multiple animation data items of the same line style in DopeSheet.
This could happen when a line style is shared by multiple linesets within a scene.
2013-09-04 00:21:27 +00:00
Tamito Kajiyama
972c4640dc Fix #36649: Drivers for Freestyle parameters in Render Layer panel don't appear in Graph Editor.
The channels define code in ANIM_init_channel_typeinfo_data() was not synchronized with the
definition of channel types (eAnim_ChannelType) in ED_anim_api.h.
2013-09-03 22:49:30 +00:00
Joshua Leung
bebaa41047 Tweaks to New Driver creation behaviour
* 'Show Debug' now enabled for all newly created drivers. For most users, it is
useful to be able to see this to help figure out what's going on

* Removed failed experiment of creating new drivers with Generator FModifiers. I
had hoped that this would make it easier to create drivers that doubled or
halved the input values, but that has proved to not be the case, and instead
made harder for most users to set things up (as they'd have to remove these
first).

Now, when adding drivers from the UI, these get created with two keyframes (at
(0,0) and (1,1) for a 1-1 mapping), which can be easily tweaked normally.

However, for backwards compatability of scripts (notably rigify, and perhaps
some others out there), when creating drivers from scripts, they will still get
created with Generator FModifiers for now. We can review this situation again
for 2.7, but for now it seems ok.
2013-09-03 00:28:23 +00:00
Campbell Barton
bbce51d116 replace hashes with sets where possible. 2013-08-25 20:03:45 +00:00
Campbell Barton
f97a4bd254 code cleanup: more zero as NULL pointers. 2013-08-07 03:36:05 +00:00
Campbell Barton
fc4a777511 use '_exec' suffix for operator execute callbacks, also picky change to sizeof() use in BLI_array.h 2013-07-28 17:06:31 +00:00
Joshua Leung
59fabbb4f7 Style Cleanup for r.58659
Use proper RNA API function that was designed to be used in this case instead of
using ugly syntax
2013-07-27 11:54:52 +00:00
Campbell Barton
96dbc60e2d fix for possible use of uninitialized variable in pastebuf_match_path_property()
wasn't checking if RNA_path_resolve() succeeded.
2013-07-27 09:38:34 +00:00
Campbell Barton
d68917cb86 code cleanup: typos 2013-07-27 07:02:27 +00:00
Campbell Barton
7db1d6556d code cleanup: add break statements in switch ()'s, (even at the last case). 2013-07-21 08:16:37 +00:00
Campbell Barton
397da50002 style cleanup: switch statements, include break statements within braces & indent.
also indent case's within the switch (we already did both of these almost everywhere)
2013-07-19 15:23:42 +00:00
Campbell Barton
1c15beb6b2 remove NULL checks on fixed size arrays, also was calling BLI_testextensie_glob every time in the file selector with a blank string. 2013-07-13 14:16:59 +00:00