griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
2aba7ec80256061ba4fa8b04c13ad962abba2634
test2/source/blender/modifiers/intern
History
Philipp Oeser 457cccd964 Fix #139782: USD MeshSequenceCache modifier using the wrong frame 
It would run into using the same frame twice, looking like "freeze
frames"

Apparently we had a similar issue before, see 3f8ec963e3

Just a PoC to show that this looks like a precision/rounding issue when
getting a "working" `UsdTimeCode`.
In the modifier code, we are doing a roundtrip going from frame >> time
(in seconds -- via `BKE_cachefile_time_offset`) and then back to frame
before we store that in `USDMeshReadParams`.

To avoid the precision loss, this PR introduces
`BKE_cachefile_frame_offset` to stay in the "frame" domain and
circumvent going through FPS alltogether.

There might be better ways to let USD handle the "sightly off"
`UsdTimeCode` better though.

Pull Request: https://projects.blender.org/blender/blender/pulls/139793
2025-06-04 11:04:37 +02:00
..
lineart
Refactor: Depsgraph: simplify query API further
2025-05-02 15:08:29 +02:00
MOD_armature.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_array.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_bevel.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_boolean.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_build.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_cast.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_cloth.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_collision.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_correctivesmooth.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_curve.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_datatransfer.cc
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_decimate.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_displace.cc
Cleanup: Grammar: Fallback vs. fall back
2025-06-02 17:13:56 -04:00
MOD_dynamicpaint.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_edgesplit.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_explode.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_fluid.cc
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_grease_pencil_armature.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_array.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_build.cc
Cleanup: Grammar: Fallback vs. fall back
2025-06-02 17:13:56 -04:00
MOD_grease_pencil_color.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_dash.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_envelope.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_hook.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_lattice.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_length.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_mirror.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_multiply.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_noise.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_offset.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_opacity.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_outline.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_shrinkwrap.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_simplify.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_smooth.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_subdiv.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_texture.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_thickness.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_time.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_tint.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_util.cc
Cleanup: Grammar: Fallback vs. fall back
2025-06-02 17:13:56 -04:00
MOD_grease_pencil_util.hh
Fix: GPv3: Some modifiers not working with non-poly curves
2024-11-05 16:35:16 +01:00
MOD_grease_pencil_weight_angle.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_grease_pencil_weight_proximity.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_hook.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_laplaciandeform.cc
Cleanup: add inline array size comments and minor corrections
2025-05-23 14:03:20 +10:00
MOD_laplaciansmooth.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_lattice.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_lineart.cc
Refactor: UI: Remove uiItemBooleanO API
2025-05-23 01:07:12 +02:00
MOD_mask.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_mesh_to_volume.cc
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_meshcache_mdd.cc
Cleanup: Various clang-tidy warnings in modifiers
2025-01-31 17:03:17 +01:00
MOD_meshcache_pc2.cc
Cleanup: use "r_" prefixed return arguments
2024-08-23 13:09:20 +10:00
MOD_meshcache_util.cc
Cleanup: Various clang-tidy warnings in modifiers
2025-01-31 17:03:17 +01:00
MOD_meshcache_util.hh
Refactor: Make header files more clangd and clang-tidy friendly
2025-01-07 12:39:13 +01:00
MOD_meshcache.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_meshdeform.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_meshsequencecache.cc
Fix #139782: USD MeshSequenceCache modifier using the wrong frame
2025-06-04 11:04:37 +02:00
MOD_mirror.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_multires.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_nodes.cc
Refactor: Nodes: change int to enum for bNodeSocketType.type
2025-06-02 13:50:07 +02:00
MOD_none.cc
Cleanup: Various clang-tidy warnings in modifiers
2025-01-31 17:03:17 +01:00
MOD_normal_edit.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_ocean.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_particleinstance.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_particlesystem.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_remesh.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_screw.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_shapekey.cc
Cleanup: Various clang-tidy warnings in modifiers
2025-01-31 17:03:17 +01:00
MOD_shrinkwrap.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_simpledeform.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_skin.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_smooth.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_softbody.cc
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_solidify_extrude.cc
Refactor: Use more typed MEM_calloc<>, avoid unnecessary size_t cast
2025-04-21 17:59:41 +02:00
MOD_solidify_nonmanifold.cc
Cleanup: modifiers: Replace 'void' MEM_[cm]allocN with templated, type-safe MEM_[cm]allocN<T>.
2025-03-12 15:43:33 +01:00
MOD_solidify_util.hh
Refactor: Make header files more clangd and clang-tidy friendly
2025-01-07 12:39:13 +01:00
MOD_solidify.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_subsurf.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_surface.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_surfacedeform.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_triangulate.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_ui_common.cc
Refactor: UI: Remove uiItemStringO API
2025-05-28 14:38:54 +02:00
MOD_ui_common.hh
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_util.cc
Cleanup: Directly include DNA_userdef_types.h and BLI_listbase.h
2025-02-12 23:01:08 +01:00
MOD_util.hh
Cleanup: Move depsgraph headers to C++
2023-09-22 03:18:17 +02:00
MOD_uvproject.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_uvwarp.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_volume_displace.cc
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_volume_to_mesh.cc
Cleanup: Modifiers: rename function to draw modifier error message
2025-05-13 17:27:30 +02:00
MOD_warp.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_wave.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_weighted_normal.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_weightvg_util.cc
Refactor: UI: Replace uiItemR with class method uiLayout::prop
2025-05-08 20:45:37 +02:00
MOD_weightvg_util.hh
Refactor: Make header files more clangd and clang-tidy friendly
2025-01-07 12:39:13 +01:00
MOD_weightvgedit.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_weightvgmix.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_weightvgproximity.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_weld.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00
MOD_wireframe.cc
Revert "Refactor: Add and use MEMCPY_STRUCT_AFTER_CHECKED"
2025-05-20 17:32:49 +02:00