4d85c03815
EEVEE writes wrong Cryptomatte meta data layer name. The view layer name
is always prepended to the Cryptomatte layer name, which can cause the
view layer name to be duplicated or the existence of view layer name
where it shouldn't be.
Old: cryptomatte/{hash}/name: string 'ViewLayer.ViewLayer.CryptoObject'
New: cryptomatte/{hash}/name: string 'ViewLayer.CryptoObject'
Pull Request: https://projects.blender.org/blender/blender/pulls/125515
174 lines
8.2 KiB
C++
174 lines
8.2 KiB
C++
/* SPDX-FileCopyrightText: 2021 Blender Authors
|
||
*
|
||
* SPDX-License-Identifier: GPL-2.0-or-later */
|
||
|
||
#include "testing/testing.h"
|
||
|
||
#include "BLI_string.h"
|
||
|
||
#include "BKE_cryptomatte.h"
|
||
#include "BKE_cryptomatte.hh"
|
||
#include "BKE_image.h"
|
||
|
||
#include "RE_pipeline.h"
|
||
|
||
#include "MEM_guardedalloc.h"
|
||
|
||
namespace blender::bke::cryptomatte::tests {
|
||
|
||
TEST(cryptomatte, meta_data_key)
|
||
{
|
||
ASSERT_EQ("cryptomatte/c7dbf5e/key",
|
||
BKE_cryptomatte_meta_data_key("ViewLayer.CryptoMaterial", "key"));
|
||
ASSERT_EQ("cryptomatte/b990b65/𝓴𝓮𝔂",
|
||
BKE_cryptomatte_meta_data_key("𝖚𝖓𝖎𝖈𝖔𝖉𝖊.CryptoMaterial", "𝓴𝓮𝔂"));
|
||
}
|
||
|
||
TEST(cryptomatte, extract_layer_name)
|
||
{
|
||
ASSERT_EQ("ViewLayer.CryptoMaterial",
|
||
BKE_cryptomatte_extract_layer_name("ViewLayer.CryptoMaterial00"));
|
||
ASSERT_EQ("𝖚𝖓𝖎𝖈𝖔𝖉𝖊", BKE_cryptomatte_extract_layer_name("𝖚𝖓𝖎𝖈𝖔𝖉𝖊13"));
|
||
ASSERT_EQ("NoTrailingSampleNumber",
|
||
BKE_cryptomatte_extract_layer_name("NoTrailingSampleNumber"));
|
||
ASSERT_EQ("W1thM1dd13Numb3rs", BKE_cryptomatte_extract_layer_name("W1thM1dd13Numb3rs09"));
|
||
ASSERT_EQ("", BKE_cryptomatte_extract_layer_name("0123"));
|
||
ASSERT_EQ("", BKE_cryptomatte_extract_layer_name(""));
|
||
}
|
||
|
||
TEST(cryptomatte, layer)
|
||
{
|
||
blender::bke::cryptomatte::CryptomatteLayer layer;
|
||
ASSERT_EQ("{}", layer.manifest());
|
||
|
||
layer.add_hash("Object", 123);
|
||
ASSERT_EQ("{\"Object\":\"0000007b\"}", layer.manifest());
|
||
|
||
layer.add_hash("Object2", 123245678);
|
||
ASSERT_EQ("{\"Object\":\"0000007b\",\"Object2\":\"0758946e\"}", layer.manifest());
|
||
}
|
||
|
||
TEST(cryptomatte, layer_quoted)
|
||
{
|
||
blender::bke::cryptomatte::CryptomatteLayer layer;
|
||
layer.add_hash("\"Object\"", 123);
|
||
ASSERT_EQ("{\"\\\"Object\\\"\":\"0000007b\"}", layer.manifest());
|
||
}
|
||
|
||
static void test_cryptomatte_manifest(std::string expected, std::string manifest)
|
||
{
|
||
EXPECT_EQ(expected,
|
||
blender::bke::cryptomatte::CryptomatteLayer::read_from_manifest(manifest)->manifest());
|
||
}
|
||
|
||
TEST(cryptomatte, layer_from_manifest)
|
||
{
|
||
test_cryptomatte_manifest("{}", "{}");
|
||
test_cryptomatte_manifest(R"({"Object":"12345678"})", R"({"Object": "12345678"})");
|
||
test_cryptomatte_manifest(R"({"Object":"12345678","Object2":"87654321"})",
|
||
R"({"Object":"12345678","Object2":"87654321"})");
|
||
test_cryptomatte_manifest(R"({"Object":"12345678","Object2":"87654321"})",
|
||
R"( { "Object" : "12345678" , "Object2" : "87654321" } )");
|
||
test_cryptomatte_manifest(R"({"Object\"01\"":"12345678"})", R"({"Object\"01\"": "12345678"})");
|
||
test_cryptomatte_manifest(
|
||
R"({"Object\"01\"":"12345678","Object":"12345678","Object2":"87654321"})",
|
||
R"({"Object\"01\"":"12345678","Object":"12345678", "Object2":"87654321"})");
|
||
}
|
||
|
||
TEST(cryptomatte, extract_layer_hash_from_metadata_key)
|
||
{
|
||
EXPECT_EQ("eb4c67b",
|
||
blender::bke::cryptomatte::CryptomatteStampDataCallbackData::extract_layer_hash(
|
||
"cryptomatte/eb4c67b/conversion"));
|
||
EXPECT_EQ("qwerty",
|
||
blender::bke::cryptomatte::CryptomatteStampDataCallbackData::extract_layer_hash(
|
||
"cryptomatte/qwerty/name"));
|
||
/* Check if undefined behaviors are handled. */
|
||
EXPECT_EQ("",
|
||
blender::bke::cryptomatte::CryptomatteStampDataCallbackData::extract_layer_hash(
|
||
"cryptomatte/name"));
|
||
EXPECT_EQ("",
|
||
blender::bke::cryptomatte::CryptomatteStampDataCallbackData::extract_layer_hash(
|
||
"cryptomatte/"));
|
||
}
|
||
|
||
static void validate_cryptomatte_session_from_stamp_data(void * /*data*/,
|
||
const char *propname,
|
||
char *propvalue,
|
||
int /*propvalue_maxncpy*/)
|
||
{
|
||
blender::StringRefNull prop_name(propname);
|
||
if (!prop_name.startswith("cryptomatte/")) {
|
||
return;
|
||
}
|
||
|
||
if (prop_name == "cryptomatte/67da54b/name") {
|
||
EXPECT_STREQ("layer1", propvalue);
|
||
}
|
||
else if (prop_name == "cryptomatte/67da54b/hash") {
|
||
EXPECT_STREQ("MurmurHash3_32", propvalue);
|
||
}
|
||
else if (prop_name == "cryptomatte/67da54b/conversion") {
|
||
EXPECT_STREQ("uint32_to_float32", propvalue);
|
||
}
|
||
else if (prop_name == "cryptomatte/67da54b/manifest") {
|
||
EXPECT_STREQ(R"({"Object":"12345678"})", propvalue);
|
||
}
|
||
|
||
else if (prop_name == "cryptomatte/79b2306/name") {
|
||
EXPECT_STREQ("layer2", propvalue);
|
||
}
|
||
else if (prop_name == "cryptomatte/79b2306/hash") {
|
||
EXPECT_STREQ("MurmurHash3_32", propvalue);
|
||
}
|
||
else if (prop_name == "cryptomatte/79b2306/conversion") {
|
||
EXPECT_STREQ("uint32_to_float32", propvalue);
|
||
}
|
||
else if (prop_name == "cryptomatte/79b2306/manifest") {
|
||
EXPECT_STREQ(R"({"Object2":"87654321"})", propvalue);
|
||
}
|
||
|
||
else {
|
||
EXPECT_EQ("Unhandled", std::string(propname) + ": " + propvalue);
|
||
}
|
||
}
|
||
|
||
TEST(cryptomatte, session_from_stamp_data)
|
||
{
|
||
/* Create CryptomatteSession from stamp data. */
|
||
RenderResult *render_result = static_cast<RenderResult *>(
|
||
MEM_callocN(sizeof(RenderResult), __func__));
|
||
BKE_render_result_stamp_data(render_result, "cryptomatte/qwerty/name", "layer1");
|
||
BKE_render_result_stamp_data(
|
||
render_result, "cryptomatte/qwerty/manifest", R"({"Object":"12345678"})");
|
||
BKE_render_result_stamp_data(render_result, "cryptomatte/uiop/name", "layer2");
|
||
BKE_render_result_stamp_data(
|
||
render_result, "cryptomatte/uiop/manifest", R"({"Object2":"87654321"})");
|
||
CryptomatteSessionPtr session(BKE_cryptomatte_init_from_render_result(render_result));
|
||
EXPECT_NE(session.get(), nullptr);
|
||
RE_FreeRenderResult(render_result);
|
||
|
||
/* Create StampData from CryptomatteSession. */
|
||
RenderResult *render_result2 = static_cast<RenderResult *>(
|
||
MEM_callocN(sizeof(RenderResult), __func__));
|
||
BKE_cryptomatte_store_metadata(session.get(), render_result2);
|
||
|
||
/* Validate StampData. */
|
||
BKE_stamp_info_callback(
|
||
nullptr, render_result2->stamp_data, validate_cryptomatte_session_from_stamp_data, false);
|
||
|
||
RE_FreeRenderResult(render_result2);
|
||
}
|
||
|
||
/**
|
||
* Test method that contains known malformed manifests and makes sure that these can be parsed as
|
||
* best as possible. */
|
||
TEST(cryptomatte, parsing_malformed_manifests)
|
||
{
|
||
/* Manifest from `multilayer.exr` in the cryptomatte git-repository. */
|
||
test_cryptomatte_manifest(
|
||
R"({"/obj/instance1:instances:0":"0d54c6cc","/obj/instance1:instances:1":"293d9340","/obj/instance1:instances:110":"ccb9e1f2","/obj/instance1:instances:111":"f8dd3a48","/obj/instance1:instances:112":"a99e07a8","/obj/instance1:instances:113":"e75599a4","/obj/instance1:instances:114":"794200f3","/obj/instance1:instances:115":"2a3a1728","/obj/instance1:instances:116":"478544a1","/obj/instance1:instances:117":"b2bd969a","/obj/instance1:instances:10":"3a0c8681","/obj/instance1:instances:11":"01e5970d","/obj/box:polygons:1":"9d416418","/obj/instance1:instances:100":"2dcd2966","/obj/instance1:instances:101":"9331cd82","/obj/instance1:instances:102":"df50fccb","/obj/instance1:instances:103":"97f8590d","/obj/instance1:instances:104":"bbcd220d","/obj/instance1:instances:105":"4ae06139","/obj/instance1:instances:106":"8873d5ea","/obj/instance1:instances:107":"39d8af8d","/obj/instance1:instances:108":"bb11bd4e","/obj/instance1:instances:109":"a32bba35"})",
|
||
R"({"\/obj\/box:polygons:1":"9d416418","\/obj\/instance1:instances:0":"0d54c6cc","\/obj\/instance1:instances:1":"293d9340","\/obj\/instance1:instances:10":"3a0c8681","\/obj\/instance1:instances:100":"2dcd2966","\/obj\/instance1:instances:101":"9331cd82","\/obj\/instance1:instances:102":"df50fccb","\/obj\/instance1:instances:103":"97f8590d","\/obj\/instance1:instances:104":"bbcd220d","\/obj\/instance1:instances:105":"4ae06139","\/obj\/instance1:instances:106":"8873d5ea","\/obj\/instance1:instances:107":"39d8af8d","\/obj\/instance1:instances:108":"bb11bd4e","\/obj\/instance1:instances:109":"a32bba35","\/obj\/instance1:instances:11":"01e5970d","\/obj\/instance1:instances:110":"ccb9e1f2","\/obj\/instance1:instances:111":"f8dd3a48","\/obj\/instance1:instances:112":"a99e07a8","\/obj\/instance1:instances:113":"e75599a4","\/obj\/instance1:instances:114":"794200f3","\/obj\/instance1:instances:115":"2a3a1728","\/obj\/instance1:instances:116":"478544a1","\/obj\/instance1:instances:117":"b2bd969a","\/obj\/instance1:instance)");
|
||
}
|
||
} // namespace blender::bke::cryptomatte::tests
|