99d73565d6
This fixes #127629. It's still a bit slower than it used to be when there are lots of instances, but that fixes the main bottleneck that was introduced in #116582. The issue was that we iterated over all attributes of all instances, but it should only be necessary to iterate over the instances of each unique geometry only once. There is still quite some optimization potential in the Realize Instances code for the case when realizing lots of instances. Especially the code to gather all geometries that should be realized can still be made more efficient by reducing redundant work and using multi-threading. Pull Request: https://projects.blender.org/blender/blender/pulls/128699
74 lines
2.5 KiB
C++
74 lines
2.5 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#pragma once
|
|
|
|
#include "BKE_geometry_set.hh"
|
|
|
|
namespace blender::geometry {
|
|
|
|
/**
|
|
* General options for realize_instances.
|
|
*/
|
|
struct RealizeInstancesOptions {
|
|
/**
|
|
* The default is to generate new ids for every element (when there was any id attribute in the
|
|
* input). This avoids having a geometry that contains the same id many times.
|
|
* When this is `true` the ids on the original geometries are kept unchanged and ids on instances
|
|
* are ignored. Ids are zero initialized when the original geometry did not have an id.
|
|
*/
|
|
bool keep_original_ids = false;
|
|
/**
|
|
* When `true` the output geometry will contain all the generic attributes that existed on
|
|
* instances. Otherwise, instance attributes are ignored.
|
|
*/
|
|
bool realize_instance_attributes = true;
|
|
|
|
std::reference_wrapper<const bke::AttributeFilter> attribute_filter =
|
|
bke::AttributeFilter::default_filter();
|
|
};
|
|
|
|
/**
|
|
* Allow the user to choice which instances to realize and to what depth.
|
|
*/
|
|
struct VariedDepthOptions {
|
|
/**
|
|
* Selection of top-level instances to realize.
|
|
*/
|
|
IndexMask selection;
|
|
|
|
/**
|
|
* Depth of realize instances for each selected top-level instance.
|
|
*/
|
|
VArray<int> depths;
|
|
|
|
/**
|
|
* Use this value to realize the instance completely
|
|
*/
|
|
static constexpr int MAX_DEPTH = -1;
|
|
};
|
|
|
|
/**
|
|
* Join all instances into a single geometry component for each geometry type. For example, all
|
|
* mesh instances (including the already realized mesh) are joined into a single mesh. The output
|
|
* geometry set does not contain any instances. If the input did not contain any instances, it is
|
|
* returned directly.
|
|
*
|
|
* The `id` attribute has special handling. If there is an id attribute on any component, the
|
|
* output will contain an `id` attribute as well. The output id is generated by mixing/hashing ids
|
|
* of instances and of the instanced geometry data.
|
|
*/
|
|
bke::GeometrySet realize_instances(bke::GeometrySet geometry_set,
|
|
const RealizeInstancesOptions &options);
|
|
|
|
/**
|
|
* Same #realize_instances but will realize only the instances chosen by
|
|
* varied_depth_option to there chosen depth.
|
|
*/
|
|
bke::GeometrySet realize_instances(bke::GeometrySet geometry_set,
|
|
const RealizeInstancesOptions &options,
|
|
const VariedDepthOptions &varied_depth_option);
|
|
|
|
} // namespace blender::geometry
|