Files
test2/source/blender/blenkernel/intern/pbvh_pixels.cc
Hans Goudey 52bf292349 Sculpt: Split BVH nodes structs by geometry type
In order to make per-BVH-node overhead smaller and also to improve
type safety and code clarity, split the `pbvh::Node` struct into four classes:
a base class, and a class for each sculpt geometry type.

The size of a mesh BVH node changes from 408 to 176 bytes. For multires
the nodes are smaller at 96 bytes. This gives us leeway to make nodes smaller
to benefit more from spacial locality, etc. It also just reduces memory usage.

Using a `std::variant` makes the change quite simple actually. For the few
places that actually need to process the node types separately given their
different types, we use `std::visit`. Elsewhere we use `IndexMask` to retrieve
selections of nodes from the vector instead, though most code will be
refactored to that pattern separately. The new function `search_nodes`
is the equivalent of the existing `gather_nodes` that returns an `IndexMask`
instead of a vector of node pointers.

Part of #118145.

Pull Request: https://projects.blender.org/blender/blender/pulls/126873
2024-08-28 15:18:21 +02:00

514 lines
17 KiB
C++

/* SPDX-FileCopyrightText: 2022 Blender Authors
*
* SPDX-License-Identifier: GPL-2.0-or-later */
#include "BKE_attribute.hh"
#include "BKE_customdata.hh"
#include "BKE_mesh.hh"
#include "BKE_pbvh_api.hh"
#include "BKE_pbvh_pixels.hh"
#include "DNA_image_types.h"
#include "DNA_object_types.h"
#include "BLI_listbase.h"
#include "BLI_math_geom.h"
#include "BLI_math_vector.h"
#include "BLI_task.h"
#include "BKE_global.hh"
#include "BKE_image_wrappers.hh"
#include "BKE_paint.hh"
#include "pbvh_intern.hh"
#include "pbvh_pixels_copy.hh"
#include "pbvh_uv_islands.hh"
namespace blender::bke::pbvh::pixels {
/**
* Calculate the delta of two neighbor UV coordinates in the given image buffer.
*/
static float2 calc_barycentric_delta(const float2 uvs[3],
const float2 start_uv,
const float2 end_uv)
{
float3 start_barycentric;
barycentric_weights_v2(uvs[0], uvs[1], uvs[2], start_uv, start_barycentric);
float3 end_barycentric;
barycentric_weights_v2(uvs[0], uvs[1], uvs[2], end_uv, end_barycentric);
float3 barycentric = end_barycentric - start_barycentric;
return float2(barycentric.x, barycentric.y);
}
static float2 calc_barycentric_delta_x(const ImBuf *image_buffer,
const float2 uvs[3],
const int x,
const int y)
{
const float2 start_uv(float(x) / image_buffer->x, float(y) / image_buffer->y);
const float2 end_uv(float(x + 1) / image_buffer->x, float(y) / image_buffer->y);
return calc_barycentric_delta(uvs, start_uv, end_uv);
}
/**
* During debugging this check could be enabled.
* It will write to each image pixel that is covered by the Tree.
*/
constexpr bool USE_WATERTIGHT_CHECK = false;
static void extract_barycentric_pixels(UDIMTilePixels &tile_data,
const ImBuf *image_buffer,
const uv_islands::UVIslandsMask &uv_mask,
const int uv_island_index,
const int uv_primitive_index,
const float2 uvs[3],
const float2 tile_offset,
const int minx,
const int miny,
const int maxx,
const int maxy)
{
for (int y = miny; y < maxy; y++) {
bool start_detected = false;
PackedPixelRow pixel_row;
pixel_row.uv_primitive_index = uv_primitive_index;
pixel_row.num_pixels = 0;
int x;
for (x = minx; x < maxx; x++) {
float2 uv((float(x) + 0.5f) / image_buffer->x, (float(y) + 0.5f) / image_buffer->y);
float3 barycentric_weights;
barycentric_weights_v2(uvs[0], uvs[1], uvs[2], uv, barycentric_weights);
const bool is_inside = barycentric_inside_triangle_v2(barycentric_weights);
const bool is_masked = uv_mask.is_masked(uv_island_index, uv + tile_offset);
if (!start_detected && is_inside && is_masked) {
start_detected = true;
pixel_row.start_image_coordinate = ushort2(x, y);
pixel_row.start_barycentric_coord = float2(barycentric_weights.x, barycentric_weights.y);
}
else if (start_detected && (!is_inside || !is_masked)) {
break;
}
}
if (!start_detected) {
continue;
}
pixel_row.num_pixels = x - pixel_row.start_image_coordinate.x;
tile_data.pixel_rows.append(pixel_row);
}
}
/** Update the geometry primitives of the pbvh. */
static void update_geom_primitives(Tree &pbvh, const uv_islands::MeshData &mesh_data)
{
PBVHData &pbvh_data = data_get(pbvh);
pbvh_data.vert_tris.reinitialize(mesh_data.corner_tris.size());
bke::mesh::vert_tris_from_corner_tris(
mesh_data.corner_verts, mesh_data.corner_tris, pbvh_data.vert_tris);
}
struct UVPrimitiveLookup {
struct Entry {
uv_islands::UVPrimitive *uv_primitive;
uint64_t uv_island_index;
Entry(uv_islands::UVPrimitive *uv_primitive, uint64_t uv_island_index)
: uv_primitive(uv_primitive), uv_island_index(uv_island_index)
{
}
};
Vector<Vector<Entry>> lookup;
UVPrimitiveLookup(const uint64_t geom_primitive_len, uv_islands::UVIslands &uv_islands)
{
lookup.append_n_times(Vector<Entry>(), geom_primitive_len);
uint64_t uv_island_index = 0;
for (uv_islands::UVIsland &uv_island : uv_islands.islands) {
for (VectorList<uv_islands::UVPrimitive>::UsedVector &uv_primitives :
uv_island.uv_primitives)
{
for (uv_islands::UVPrimitive &uv_primitive : uv_primitives) {
lookup[uv_primitive.primitive_i].append_as(Entry(&uv_primitive, uv_island_index));
}
}
uv_island_index++;
}
}
};
static void do_encode_pixels(const uv_islands::MeshData &mesh_data,
const uv_islands::UVIslandsMask &uv_masks,
const UVPrimitiveLookup &uv_prim_lookup,
Image &image,
ImageUser &image_user,
MeshNode &node)
{
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
LISTBASE_FOREACH (ImageTile *, tile, &image.tiles) {
image::ImageTileWrapper image_tile(tile);
image_user.tile = image_tile.get_tile_number();
ImBuf *image_buffer = BKE_image_acquire_ibuf(&image, &image_user, nullptr);
if (image_buffer == nullptr) {
continue;
}
UDIMTilePixels tile_data;
tile_data.tile_number = image_tile.get_tile_number();
float2 tile_offset = float2(image_tile.get_tile_offset());
for (const int geom_prim_index : node.prim_indices_) {
for (const UVPrimitiveLookup::Entry &entry : uv_prim_lookup.lookup[geom_prim_index]) {
uv_islands::UVBorder uv_border = entry.uv_primitive->extract_border();
float2 uvs[3] = {
entry.uv_primitive->get_uv_vertex(mesh_data, 0)->uv - tile_offset,
entry.uv_primitive->get_uv_vertex(mesh_data, 1)->uv - tile_offset,
entry.uv_primitive->get_uv_vertex(mesh_data, 2)->uv - tile_offset,
};
const float minv = clamp_f(min_fff(uvs[0].y, uvs[1].y, uvs[2].y), 0.0f, 1.0f);
const int miny = floor(minv * image_buffer->y);
const float maxv = clamp_f(max_fff(uvs[0].y, uvs[1].y, uvs[2].y), 0.0f, 1.0f);
const int maxy = min_ii(ceil(maxv * image_buffer->y), image_buffer->y);
const float minu = clamp_f(min_fff(uvs[0].x, uvs[1].x, uvs[2].x), 0.0f, 1.0f);
const int minx = floor(minu * image_buffer->x);
const float maxu = clamp_f(max_fff(uvs[0].x, uvs[1].x, uvs[2].x), 0.0f, 1.0f);
const int maxx = min_ii(ceil(maxu * image_buffer->x), image_buffer->x);
/* TODO: Perform bounds check */
int uv_prim_index = node_data->uv_primitives.size();
node_data->uv_primitives.append(geom_prim_index);
UVPrimitivePaintInput &paint_input = node_data->uv_primitives.last();
/* Calculate barycentric delta */
paint_input.delta_barycentric_coord_u = calc_barycentric_delta_x(
image_buffer, uvs, minx, miny);
/* Extract the pixels. */
extract_barycentric_pixels(tile_data,
image_buffer,
uv_masks,
entry.uv_island_index,
uv_prim_index,
uvs,
tile_offset,
minx,
miny,
maxx,
maxy);
}
}
BKE_image_release_ibuf(&image, image_buffer, nullptr);
if (tile_data.pixel_rows.is_empty()) {
continue;
}
node_data->tiles.append(tile_data);
}
}
static bool should_pixels_be_updated(const Node &node)
{
if ((node.flag_ & (PBVH_Leaf | PBVH_TexLeaf)) == 0) {
return false;
}
if (node.children_offset_ != 0) {
return false;
}
if ((node.flag_ & PBVH_RebuildPixels) != 0) {
return true;
}
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
if (node_data != nullptr) {
return false;
}
return true;
}
static int count_nodes_to_update(Tree &pbvh)
{
int result = 0;
for (Node &node : pbvh.nodes<MeshNode>()) {
if (should_pixels_be_updated(node)) {
result++;
}
}
return result;
}
/**
* Find the nodes that needs to be updated.
*
* The nodes that require updated are added to the r_nodes_to_update parameter.
* Will fill in r_visited_polygons with polygons that are owned by nodes that do not require
* updates.
*
* returns if there were any nodes found (true).
*/
static bool find_nodes_to_update(Tree &pbvh, Vector<MeshNode *> &r_nodes_to_update)
{
int nodes_to_update_len = count_nodes_to_update(pbvh);
if (nodes_to_update_len == 0) {
return false;
}
/* Init or reset Tree pixel data when changes detected. */
if (pbvh.pixels_ == nullptr) {
PBVHData *pbvh_data = MEM_new<PBVHData>(__func__);
pbvh.pixels_ = pbvh_data;
}
else {
PBVHData *pbvh_data = static_cast<PBVHData *>(pbvh.pixels_);
pbvh_data->clear_data();
}
r_nodes_to_update.reserve(nodes_to_update_len);
for (MeshNode &node : pbvh.nodes<MeshNode>()) {
if (!should_pixels_be_updated(node)) {
continue;
}
r_nodes_to_update.append(&node);
node.flag_ = static_cast<PBVHNodeFlags>(node.flag_ | PBVH_RebuildPixels);
if (node.pixels_ == nullptr) {
NodeData *node_data = MEM_new<NodeData>(__func__);
node.pixels_ = node_data;
}
else {
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
node_data->clear_data();
}
}
return true;
}
static void apply_watertight_check(Tree &pbvh, Image &image, ImageUser &image_user)
{
ImageUser watertight = image_user;
LISTBASE_FOREACH (ImageTile *, tile_data, &image.tiles) {
image::ImageTileWrapper image_tile(tile_data);
watertight.tile = image_tile.get_tile_number();
ImBuf *image_buffer = BKE_image_acquire_ibuf(&image, &watertight, nullptr);
if (image_buffer == nullptr) {
continue;
}
for (Node &node : pbvh.nodes<MeshNode>()) {
if ((node.flag_ & PBVH_Leaf) == 0) {
continue;
}
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
UDIMTilePixels *tile_node_data = node_data->find_tile_data(image_tile);
if (tile_node_data == nullptr) {
continue;
}
for (PackedPixelRow &pixel_row : tile_node_data->pixel_rows) {
int pixel_offset = pixel_row.start_image_coordinate.y * image_buffer->x +
pixel_row.start_image_coordinate.x;
for (int x = 0; x < pixel_row.num_pixels; x++) {
if (image_buffer->float_buffer.data) {
copy_v4_fl(&image_buffer->float_buffer.data[pixel_offset * 4], 1.0);
}
if (image_buffer->byte_buffer.data) {
uint8_t *dest = &image_buffer->byte_buffer.data[pixel_offset * 4];
copy_v4_uchar(dest, 255);
}
pixel_offset += 1;
}
}
}
BKE_image_release_ibuf(&image, image_buffer, nullptr);
}
BKE_image_partial_update_mark_full_update(&image);
}
static bool update_pixels(const Depsgraph &depsgraph,
const Object &object,
Tree &pbvh,
Image &image,
ImageUser &image_user)
{
Vector<MeshNode *> nodes_to_update;
if (!find_nodes_to_update(pbvh, nodes_to_update)) {
return false;
}
const Mesh &mesh = *static_cast<const Mesh *>(object.data);
const StringRef active_uv_name = CustomData_get_active_layer_name(&mesh.corner_data,
CD_PROP_FLOAT2);
if (active_uv_name.is_empty()) {
return false;
}
const AttributeAccessor attributes = mesh.attributes();
const VArraySpan uv_map = *attributes.lookup<float2>(active_uv_name, AttrDomain::Corner);
uv_islands::MeshData mesh_data(mesh.corner_tris(),
mesh.corner_verts(),
uv_map,
bke::pbvh::vert_positions_eval(depsgraph, object));
uv_islands::UVIslands islands(mesh_data);
uv_islands::UVIslandsMask uv_masks;
ImageUser tile_user = image_user;
LISTBASE_FOREACH (ImageTile *, tile_data, &image.tiles) {
image::ImageTileWrapper image_tile(tile_data);
tile_user.tile = image_tile.get_tile_number();
ImBuf *tile_buffer = BKE_image_acquire_ibuf(&image, &tile_user, nullptr);
if (tile_buffer == nullptr) {
continue;
}
uv_masks.add_tile(float2(image_tile.get_tile_x_offset(), image_tile.get_tile_y_offset()),
ushort2(tile_buffer->x, tile_buffer->y));
BKE_image_release_ibuf(&image, tile_buffer, nullptr);
}
uv_masks.add(mesh_data, islands);
uv_masks.dilate(image.seam_margin);
islands.extract_borders();
islands.extend_borders(mesh_data, uv_masks);
update_geom_primitives(pbvh, mesh_data);
UVPrimitiveLookup uv_primitive_lookup(mesh_data.corner_tris.size(), islands);
threading::parallel_for(nodes_to_update.index_range(), 1, [&](const IndexRange range) {
for (const int i : range) {
do_encode_pixels(
mesh_data, uv_masks, uv_primitive_lookup, image, image_user, *nodes_to_update[i]);
}
});
if (USE_WATERTIGHT_CHECK) {
apply_watertight_check(pbvh, image, image_user);
}
/* Add solution for non-manifold parts of the model. */
copy_update(pbvh, image, image_user, mesh_data);
/* Rebuild the undo regions. */
for (Node *node : nodes_to_update) {
NodeData *node_data = static_cast<NodeData *>(node->pixels_);
node_data->rebuild_undo_regions();
}
/* Clear the UpdatePixels flag. */
for (Node *node : nodes_to_update) {
node->flag_ = static_cast<PBVHNodeFlags>(node->flag_ & ~PBVH_RebuildPixels);
}
/* Add PBVH_TexLeaf flag */
for (Node &node : pbvh.nodes<MeshNode>()) {
if (node.flag_ & PBVH_Leaf) {
node.flag_ = (PBVHNodeFlags)(int(node.flag_) | int(PBVH_TexLeaf));
}
}
// #define DO_PRINT_STATISTICS
#ifdef DO_PRINT_STATISTICS
/* Print some statistics about compression ratio. */
{
int compressed_data_len = 0;
int num_pixels = 0;
for (int n = 0; n < pbvh->totnode; n++) {
Node *node = &pbvh->nodes[n];
if ((node->flag & PBVH_Leaf) == 0) {
continue;
}
NodeData *node_data = static_cast<NodeData *>(node->pixels.node_data);
for (const UDIMTilePixels &tile_data : node_data->tiles) {
compressed_data_len += tile_data.encoded_pixels.size() * sizeof(PackedPixelRow);
for (const PackedPixelRow &encoded_pixels : tile_data.encoded_pixels) {
num_pixels += encoded_pixels.num_pixels;
}
}
}
printf("Encoded %lld pixels in %lld bytes (%f bytes per pixel)\n",
num_pixels,
compressed_data_len,
float(compressed_data_len) / num_pixels);
}
#endif
return true;
}
NodeData &node_data_get(Node &node)
{
BLI_assert(node.pixels_ != nullptr);
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
return *node_data;
}
PBVHData &data_get(Tree &pbvh)
{
BLI_assert(pbvh.pixels_ != nullptr);
PBVHData *data = static_cast<PBVHData *>(pbvh.pixels_);
return *data;
}
void mark_image_dirty(Node &node, Image &image, ImageUser &image_user)
{
BLI_assert(node.pixels_ != nullptr);
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
if (node_data->flags.dirty) {
ImageUser local_image_user = image_user;
LISTBASE_FOREACH (ImageTile *, tile, &image.tiles) {
image::ImageTileWrapper image_tile(tile);
local_image_user.tile = image_tile.get_tile_number();
ImBuf *image_buffer = BKE_image_acquire_ibuf(&image, &local_image_user, nullptr);
if (image_buffer == nullptr) {
continue;
}
node_data->mark_region(image, image_tile, *image_buffer);
BKE_image_release_ibuf(&image, image_buffer, nullptr);
}
node_data->flags.dirty = false;
}
}
void collect_dirty_tiles(Node &node, Vector<image::TileNumber> &r_dirty_tiles)
{
NodeData *node_data = static_cast<NodeData *>(node.pixels_);
node_data->collect_dirty_tiles(r_dirty_tiles);
}
} // namespace blender::bke::pbvh::pixels
namespace blender::bke::pbvh {
void build_pixels(const Depsgraph &depsgraph, Object &object, Image &image, ImageUser &image_user)
{
SculptSession &ss = *object.sculpt;
Tree &pbvh = *ss.pbvh;
pixels::update_pixels(depsgraph, object, pbvh, image, image_user);
}
void node_pixels_free(Node *node)
{
pixels::NodeData *node_data = static_cast<pixels::NodeData *>(node->pixels_);
if (!node_data) {
return;
}
MEM_delete(node_data);
node->pixels_ = nullptr;
}
void pixels_free(Tree *pbvh)
{
pixels::PBVHData *pbvh_data = static_cast<pixels::PBVHData *>(pbvh->pixels_);
MEM_delete(pbvh_data);
pbvh->pixels_ = nullptr;
}
} // namespace blender::bke::pbvh