b19696c0b8
- Tangent calculation functions no longer use the CustomData struct as an input and output. - The "orco" and UV map calculations are exposed as separate API functions to avoid a confusing internal choice between the two - Redundancy in the API is removed, function names are clarified - Code is moved to C++ namespace - The "orco" case is clarified in the mesh draw tangent VBO extraction - CD_TANGENT layers are not stored in CustomData anymore, so some of that infrastructure is removed. - Broken logic for caching tangents in CustomData is removed. That hasn't worked for many years, if it every worked. We could investigate adding caching again later if that's helpful. Overall the change is motivated by the need to move away from CustomData for #122398. But the changes should be a general improvement that makes the code easier to understand either way. Testing for this PR included using the default render UV in materials, referencing specific UV tangents by name, using the spherical position- based tangents in a material, and baking textures (multires and normal baking). Pull Request: https://projects.blender.org/blender/blender/pulls/141799
97 lines
3.3 KiB
C++
97 lines
3.3 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#include "DNA_mesh_types.h"
|
|
#include "DNA_meshdata_types.h"
|
|
|
|
#include "BLI_task.hh"
|
|
|
|
#include "BKE_attribute.hh"
|
|
#include "BKE_attribute_math.hh"
|
|
#include "BKE_customdata.hh"
|
|
#include "BKE_mesh.hh"
|
|
|
|
namespace blender::bke {
|
|
|
|
template<typename T>
|
|
static void flip_corner_data(const OffsetIndices<int> faces,
|
|
const IndexMask &face_selection,
|
|
MutableSpan<T> data)
|
|
{
|
|
face_selection.foreach_index(GrainSize(1024),
|
|
[&](const int i) { data.slice(faces[i].drop_front(1)).reverse(); });
|
|
}
|
|
|
|
template<typename T>
|
|
static void flip_custom_data_type(const OffsetIndices<int> faces,
|
|
CustomData &corner_data,
|
|
const IndexMask &face_selection,
|
|
const eCustomDataType data_type)
|
|
{
|
|
BLI_assert(sizeof(T) == CustomData_sizeof(data_type));
|
|
for (const int i : IndexRange(CustomData_number_of_layers(&corner_data, data_type))) {
|
|
T *data = static_cast<T *>(
|
|
CustomData_get_layer_n_for_write(&corner_data, data_type, i, faces.total_size()));
|
|
flip_corner_data(faces, face_selection, MutableSpan(data, faces.total_size()));
|
|
}
|
|
}
|
|
|
|
void mesh_flip_faces(Mesh &mesh, const IndexMask &selection)
|
|
{
|
|
if (mesh.faces_num == 0 || selection.is_empty()) {
|
|
return;
|
|
}
|
|
|
|
const OffsetIndices faces = mesh.faces();
|
|
MutableSpan<int> corner_verts = mesh.corner_verts_for_write();
|
|
MutableSpan<int> corner_edges = mesh.corner_edges_for_write();
|
|
|
|
selection.foreach_index(GrainSize(1024), [&](const int i) {
|
|
const IndexRange face = faces[i];
|
|
for (const int j : IndexRange(face.size() / 2)) {
|
|
const int a = face[j + 1];
|
|
const int b = face.last(j);
|
|
std::swap(corner_verts[a], corner_verts[b]);
|
|
std::swap(corner_edges[a - 1], corner_edges[b]);
|
|
}
|
|
});
|
|
|
|
flip_custom_data_type<float4>(faces, mesh.corner_data, selection, CD_MLOOPTANGENT);
|
|
flip_custom_data_type<GridPaintMask>(faces, mesh.corner_data, selection, CD_GRID_PAINT_MASK);
|
|
flip_custom_data_type<OrigSpaceLoop>(faces, mesh.corner_data, selection, CD_ORIGSPACE_MLOOP);
|
|
flip_custom_data_type<MDisps>(faces, mesh.corner_data, selection, CD_MDISPS);
|
|
if (MDisps *mdisp = static_cast<MDisps *>(
|
|
CustomData_get_layer_for_write(&mesh.corner_data, CD_MDISPS, mesh.corners_num)))
|
|
{
|
|
selection.foreach_index(GrainSize(512), [&](const int i) {
|
|
for (const int corner : faces[i]) {
|
|
BKE_mesh_mdisp_flip(&mdisp[corner], true);
|
|
}
|
|
});
|
|
}
|
|
|
|
MutableAttributeAccessor attributes = mesh.attributes_for_write();
|
|
attributes.foreach_attribute([&](const AttributeIter &iter) {
|
|
if (iter.data_type == bke::AttrType::String) {
|
|
return;
|
|
}
|
|
if (iter.domain != AttrDomain::Corner) {
|
|
return;
|
|
}
|
|
if (ELEM(iter.name, ".corner_vert", ".corner_edge")) {
|
|
return;
|
|
}
|
|
GSpanAttributeWriter attribute = attributes.lookup_for_write_span(iter.name);
|
|
attribute_math::convert_to_static_type(iter.data_type, [&](auto dummy) {
|
|
using T = decltype(dummy);
|
|
flip_corner_data(faces, selection, attribute.span.typed<T>());
|
|
});
|
|
attribute.finish();
|
|
});
|
|
|
|
mesh.tag_face_winding_changed();
|
|
}
|
|
|
|
} // namespace blender::bke
|