aaa25bc882
Instead of storing a boolean "update tag" for every vertex, just recalculate the normals of all the faces and vertices in affected PBVH nodes. This avoids the overhead of tracking position updates at the vertex level, and simplifies the normal calculation, since we can just calculate values for all the normals in a node. The main way we gain performance is avoiding building a `VectorSet` for all vertices and faces that need updates in the entire mesh. That process had to be single threaded, and was a large bottleneck when many vertices were affected at a time. That `VectorSet` was necessary for thread safety deduplication of work though, because neighboring nodes can't calculate the normals of the same faces or vertices at the same time. (Normals need to be calculated for all faces connected to moved vertices and all vertices connected to those faces). In this PR, we only build a set of the *boundary* faces and vertices. We calculate those in a separate step, which duplicates work from the non-boundary calculations, but at least it's threadsafe. I measured normal recalculation timing when sculpting on a 16 million vertex mesh. The removal of the `vert_bitmap` array also saves 16 MB of memory. | Nodes | Affected Vertices | Before (ms) | After (ms) | | ----- | ------------ | ----------- | ---------- | | 4 | 15625 | 0.208 | 0.304 | | 35 | 136281 | 2.98 | 0.988 | | 117 | 457156 | 15.0 | 3.21 | | 2455 | 9583782 | 566 | 84.0 | Pull Request: https://projects.blender.org/blender/blender/pulls/116209
260 lines
8.1 KiB
C++
260 lines
8.1 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#pragma once
|
|
|
|
#include "BLI_array.hh"
|
|
#include "BLI_bounds_types.hh"
|
|
#include "BLI_math_vector_types.hh"
|
|
#include "BLI_set.hh"
|
|
#include "BLI_span.hh"
|
|
#include "BLI_vector.hh"
|
|
|
|
/** \file
|
|
* \ingroup bke
|
|
*/
|
|
|
|
namespace blender::draw::pbvh {
|
|
struct PBVHBatches;
|
|
}
|
|
|
|
struct PBVHGPUFormat;
|
|
struct BMVert;
|
|
struct BMFace;
|
|
|
|
/* NOTE: this structure is getting large, might want to split it into
|
|
* union'd structs */
|
|
struct PBVHNode {
|
|
/* Opaque handle for drawing code */
|
|
blender::draw::pbvh::PBVHBatches *draw_batches = nullptr;
|
|
|
|
/* Voxel bounds */
|
|
blender::Bounds<blender::float3> vb = {};
|
|
blender::Bounds<blender::float3> orig_vb = {};
|
|
|
|
/* For internal nodes, the offset of the children in the PBVH
|
|
* 'nodes' array. */
|
|
int children_offset = 0;
|
|
|
|
/* List of primitives for this node. Semantics depends on
|
|
* PBVH type:
|
|
*
|
|
* - PBVH_FACES: Indices into the #PBVH::corner_tris array.
|
|
* - PBVH_GRIDS: Multires grid indices.
|
|
* - PBVH_BMESH: Unused. See PBVHNode.bm_faces.
|
|
*
|
|
* NOTE: This is a pointer inside of PBVH.prim_indices; it
|
|
* is not allocated separately per node.
|
|
*/
|
|
blender::Span<int> prim_indices;
|
|
|
|
/* Array of indices into the mesh's vertex array. Contains the
|
|
* indices of all vertices used by faces that are within this
|
|
* node's bounding box.
|
|
*
|
|
* Note that a vertex might be used by a multiple faces, and
|
|
* these faces might be in different leaf nodes. Such a vertex
|
|
* will appear in the vert_indices array of each of those leaf
|
|
* nodes.
|
|
*
|
|
* In order to support cases where you want access to multiple
|
|
* nodes' vertices without duplication, the vert_indices array
|
|
* is ordered such that the first part of the array, up to
|
|
* index 'uniq_verts', contains "unique" vertex indices. These
|
|
* vertices might not be truly unique to this node, but if
|
|
* they appear in another node's vert_indices array, they will
|
|
* be above that node's 'uniq_verts' value.
|
|
*
|
|
* Used for leaf nodes in a mesh-based PBVH (not multires.)
|
|
*/
|
|
blender::Array<int, 0> vert_indices;
|
|
int uniq_verts = 0;
|
|
int face_verts = 0;
|
|
|
|
/* Array of indices into the Mesh's corner array.
|
|
* PBVH_FACES only.
|
|
*/
|
|
blender::Array<int, 0> loop_indices;
|
|
|
|
/* An array mapping face corners into the vert_indices
|
|
* array. The array is sized to match 'totprim', and each of
|
|
* the face's corners gets an index into the vert_indices
|
|
* array, in the same order as the corners in the original
|
|
* triangle.
|
|
*
|
|
* Used for leaf nodes in a mesh-based PBVH (not multires.)
|
|
*/
|
|
blender::Array<blender::int3, 0> face_vert_indices;
|
|
|
|
/* Indicates whether this node is a leaf or not; also used for
|
|
* marking various updates that need to be applied. */
|
|
PBVHNodeFlags flag = PBVHNodeFlags(0);
|
|
|
|
/* Used for ray-casting: how close the bounding-box is to the ray point. */
|
|
float tmin = 0.0f;
|
|
|
|
blender::Vector<PBVHProxyNode> proxies;
|
|
|
|
/* Dyntopo */
|
|
|
|
/* Set of pointers to the BMFaces used by this node.
|
|
* NOTE: PBVH_BMESH only. Faces are always triangles
|
|
* (dynamic topology forcibly triangulates the mesh).
|
|
*/
|
|
blender::Set<BMFace *, 0> bm_faces;
|
|
blender::Set<BMVert *, 0> bm_unique_verts;
|
|
blender::Set<BMVert *, 0> bm_other_verts;
|
|
|
|
/* Deprecated. Stores original coordinates of triangles. */
|
|
float (*bm_orco)[3] = nullptr;
|
|
int (*bm_ortri)[3] = nullptr;
|
|
BMVert **bm_orvert = nullptr;
|
|
int bm_tot_ortri = 0;
|
|
|
|
/* Used to store the brush color during a stroke and composite it over the original color */
|
|
PBVHColorBufferNode color_buffer;
|
|
PBVHPixelsNode pixels;
|
|
|
|
/* Used to flash colors of updated node bounding boxes in
|
|
* debug draw mode (when G.debug_value / bpy.app.debug_value is 889).
|
|
*/
|
|
int debug_draw_gen = 0;
|
|
};
|
|
|
|
struct PBVH {
|
|
PBVHPublic header;
|
|
|
|
blender::Vector<PBVHNode> nodes;
|
|
|
|
/* Memory backing for PBVHNode.prim_indices. */
|
|
blender::Array<int> prim_indices;
|
|
int totprim;
|
|
int totvert;
|
|
|
|
int leaf_limit;
|
|
int pixel_leaf_limit;
|
|
int depth_limit;
|
|
|
|
/* Mesh data. The evaluated deform mesh for mesh sculpting, and the base mesh for grids. */
|
|
Mesh *mesh;
|
|
|
|
/** Local array used when not sculpting base mesh positions directly. */
|
|
blender::Array<blender::float3> vert_positions_deformed;
|
|
/** Local array used when not sculpting base mesh positions directly. */
|
|
blender::Array<blender::float3> vert_normals_deformed;
|
|
/** Local array used when not sculpting base mesh positions directly. */
|
|
blender::Array<blender::float3> face_normals_deformed;
|
|
|
|
blender::MutableSpan<blender::float3> vert_positions;
|
|
blender::Span<blender::float3> vert_normals;
|
|
blender::Span<blender::float3> face_normals;
|
|
|
|
/** Only valid for polygon meshes. */
|
|
blender::OffsetIndices<int> faces;
|
|
blender::Span<int> corner_verts;
|
|
/* Owned by the #PBVH, because after deformations they have to be recomputed. */
|
|
blender::Array<blender::int3> corner_tris;
|
|
blender::Span<int> corner_tri_faces;
|
|
|
|
/* Grid Data */
|
|
CCGKey gridkey;
|
|
SubdivCCG *subdiv_ccg;
|
|
|
|
#ifdef PERFCNTRS
|
|
int perf_modified;
|
|
#endif
|
|
|
|
/* flag are verts/faces deformed */
|
|
bool deformed;
|
|
|
|
/* Dynamic topology */
|
|
float bm_max_edge_len;
|
|
float bm_min_edge_len;
|
|
int cd_vert_node_offset;
|
|
int cd_face_node_offset;
|
|
|
|
float planes[6][4];
|
|
int num_planes;
|
|
|
|
BMLog *bm_log;
|
|
|
|
blender::GroupedSpan<int> vert_to_face_map;
|
|
|
|
CustomDataLayer *color_layer;
|
|
blender::bke::AttrDomain color_domain;
|
|
|
|
/* Initialize this to true, instead of waiting for a draw engine
|
|
* to set it. Prevents a crash in draw manager instancing code.
|
|
* TODO: This is fragile, another solution should be found. */
|
|
bool is_drawing = true;
|
|
|
|
/* Used by DynTopo to invalidate the draw cache. */
|
|
bool draw_cache_invalid = true;
|
|
|
|
PBVHGPUFormat *vbo_id;
|
|
|
|
PBVHPixels pixels;
|
|
};
|
|
|
|
/* pbvh.cc */
|
|
|
|
namespace blender::bke::pbvh {
|
|
|
|
bool ray_face_intersection_quad(const float ray_start[3],
|
|
IsectRayPrecalc *isect_precalc,
|
|
const float t0[3],
|
|
const float t1[3],
|
|
const float t2[3],
|
|
const float t3[3],
|
|
float *depth);
|
|
bool ray_face_intersection_tri(const float ray_start[3],
|
|
IsectRayPrecalc *isect_precalc,
|
|
const float t0[3],
|
|
const float t1[3],
|
|
const float t2[3],
|
|
float *depth);
|
|
|
|
bool ray_face_nearest_quad(const float ray_start[3],
|
|
const float ray_normal[3],
|
|
const float t0[3],
|
|
const float t1[3],
|
|
const float t2[3],
|
|
const float t3[3],
|
|
float *r_depth,
|
|
float *r_dist_sq);
|
|
bool ray_face_nearest_tri(const float ray_start[3],
|
|
const float ray_normal[3],
|
|
const float t0[3],
|
|
const float t1[3],
|
|
const float t2[3],
|
|
float *r_depth,
|
|
float *r_dist_sq);
|
|
|
|
/* pbvh_bmesh.cc */
|
|
|
|
bool bmesh_node_raycast(PBVHNode *node,
|
|
const float ray_start[3],
|
|
const float ray_normal[3],
|
|
IsectRayPrecalc *isect_precalc,
|
|
float *dist,
|
|
bool use_original,
|
|
PBVHVertRef *r_active_vertex,
|
|
float *r_face_normal);
|
|
bool bmesh_node_nearest_to_ray(PBVHNode *node,
|
|
const float ray_start[3],
|
|
const float ray_normal[3],
|
|
float *depth,
|
|
float *dist_sq,
|
|
bool use_original);
|
|
|
|
void bmesh_normals_update(Span<PBVHNode *> nodes);
|
|
|
|
/* pbvh_pixels.hh */
|
|
|
|
void node_pixels_free(PBVHNode *node);
|
|
void pixels_free(PBVH *pbvh);
|
|
void free_draw_buffers(PBVH &pbvh, PBVHNode *node);
|
|
|
|
} // namespace blender::bke::pbvh
|