griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
c4d413fdadd9c46a2b00a9cc1e8065cd1ce4db8b
test2/source/blender/blenlib/intern
History
Bastien Montagne dd3222d2f8 BLI math: Do not use BLI_ASSERT_ C-style checks in modern cpp code. 
The old C-style `BLI_ASSERT_UNIT_V...` assert macros have a few issues:
* They are named `unit`, but also consider a zero-length vector as valid.
* They use a fairly high epsilon value, which was defined because
  vertex normals used to be stored as shorts.

Fortunately, these are used only in one place in the modern BLI_math C++
code AFAICS, which is `math::rotate_direction_around_axis`.

This commit adds some utils to check for vectors being (almost) unit
or zero length, using more modern bases for epsilon values (from
`std::numeric_limits`).
* `is_zero` keeps its existing default arror of `0` (i.e. strictly null
  vector by default). That way, current behavior is not changed, and in
  most cases null vectors are explicitely created as exactly null.
* `is_unit` uses a default 10 times the type's epsilon, as a zero
  epsilon would virtually never succeed here.

And it modifies `rotate_direction_around_axis` to:
* Assert that `axis` is a unit vector.
* Early-out in case given `direction` is a null vector, or rotating
  angle is zero.
* Assert about `direction` being a unit vector otherwise.

Note that this will make `rotate_direction_around_axis` use much
stricter epsilon error factors. This does not seem to affect any of the
files that triggered asserts prior to recent fix in e18dd894b8 though.

Pull Request: https://projects.blender.org/blender/blender/pulls/122482
2024-05-31 10:58:19 +02:00
..
array_store_utils.cc
Cleanup: use const pointer arguments
2024-04-03 10:22:05 +11:00
array_store.cc
Cleanup: various non functional C++ changes
2024-04-20 13:46:14 +10:00
array_utils.c
Cleanup: declare arrays as const where possible
2024-03-28 22:57:57 +11:00
array_utils.cc
Geometry Nodes: Sort Elements node
2024-01-12 14:30:34 +01:00
astar.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
atomic_disjoint_set.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
bit_ref.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
bit_span.cc
Cleanup: fewer iostreams related includes from BLI/BKE headers
2023-08-16 09:51:37 +02:00
bitmap_draw_2d.cc
Cleanup: various non-functional C++ changes
2024-03-06 14:47:29 +11:00
bitmap.c
Cleanup: Add a copyright notice to files and use SPDX format
2023-05-31 16:19:06 +02:00
BLI_args.c
Cleanup: use const pointer arguments
2024-03-28 20:57:50 +11:00
BLI_array.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
BLI_assert.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_color.cc
Cleanup: fewer iostreams related includes from BLI/BKE headers
2023-08-16 09:51:37 +02:00
BLI_dial_2d.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
BLI_dynstr.c
BLI_dynstr: remove workaround for vsnprintf on WIN32
2023-07-03 17:01:32 +10:00
BLI_filelist.cc
Cleanup: use const args & variables, remove redundant checks
2024-04-15 09:50:47 +10:00
BLI_ghash_utils.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_ghash.c
Cleanup: use const pointer arguments
2024-04-23 16:09:45 +10:00
BLI_heap_simple.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_heap.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_index_range.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_kdopbvh.c
Cleanup: Remove unused BVH tree function
2024-04-04 14:49:01 -04:00
BLI_linklist_lockfree.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_linklist.c
Cleanup: use const pointer arguments
2024-04-23 16:09:45 +10:00
BLI_memarena.c
Cleanup: use const args & variables, remove redundant checks
2024-04-15 09:50:47 +10:00
BLI_memblock.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_memiter.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
BLI_mempool_private.h
Cleanup: resolve cppcheck funcArgNamesDifferent warnings in blenlib
2024-05-07 13:07:02 +10:00
BLI_mempool.c
Cleanup: use const pointer arguments
2024-04-23 16:09:45 +10:00
BLI_mmap.c
Cleanup: use const args & variables, remove redundant checks
2024-04-15 09:50:47 +10:00
BLI_timer.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
boxpack_2d.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
buffer.c
Cleanup: use const args & variables, remove redundant checks
2024-04-15 09:50:47 +10:00
cache_mutex.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
compute_context.cc
Fix #120579: incorrect compute context hashes
2024-04-14 13:20:32 +02:00
convexhull_2d.cc
Cleanup: remove redundant variables & assignments
2024-04-09 13:52:41 +10:00
cpp_type.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
cpp_types.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
delaunay_2d.cc
Cleanup: back-tick quote file extensions in code-comments
2024-05-04 15:06:46 +10:00
DLRB_tree.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
dot_export.cc
Cleanup: fewer iostreams related includes from BLI/BKE headers
2023-08-16 09:51:37 +02:00
dynlib.cc
Cleanup: apply clang-tidy modernize-deprecated-headers
2024-01-08 11:32:49 +11:00
easing.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
endian_switch.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
expr_pylike_eval.c
Cleanup: use const pointers
2024-04-20 12:41:23 +10:00
fftw.cc
Cleanup: clarify doc-strings for BLI_fftw
2024-05-20 10:29:22 +10:00
fileops_c.cc
Cleanup: resolve cppcheck funcArgNamesDifferent warnings in blenlib
2024-05-07 13:07:02 +10:00
fileops.cc
Revert changes from main commits that were merged into blender-v4.0-release
2023-10-30 21:40:35 +01:00
filereader_file.c
Fix build error on Windows after BLI_read changes
2023-10-10 15:36:15 +02:00
filereader_gzip.c
Fix build error on Windows after BLI_read changes
2023-10-10 15:36:15 +02:00
filereader_memory.c
Revert changes from main commits that were merged into blender-v4.0-release
2023-10-30 21:40:35 +01:00
filereader_zstd.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
fnmatch.c
Cleanup: comment block formatting
2024-01-08 11:31:43 +11:00
generic_vector_array.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
generic_virtual_array.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
generic_virtual_vector_array.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
gsqueue.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
hash_md5.cc
Cleanup: spacing around C-style comment blocks
2024-03-09 23:40:57 +11:00
hash_mm2a.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
hash_mm3.cc
Cleanup: move hash and ghash utils to C++
2024-02-02 19:55:06 +01:00
hash_tables.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
implicit_sharing.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
index_mask_expression.cc
Cleanup: spelling in comments
2024-03-21 10:02:53 +11:00
index_mask.cc
BLI: Add IndexMask::from_bools_inverse utility
2024-04-30 13:03:26 -04:00
index_range.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
jitter_2d.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
kdtree_1d.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
kdtree_2d.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
kdtree_3d.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
kdtree_4d.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
kdtree_impl.h
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
lasso_2d.cc
Cleanup: Use C++ Array, Span, int2 for lasso coords
2024-03-05 11:29:04 -05:00
lazy_threading.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
length_parameterize.cc
Cleanup: resolve cppcheck funcArgNamesDifferent warnings in blenlib
2024-05-07 13:07:02 +10:00
list_sort_impl.h
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
listbase.cc
Cleanup: resolve cppcheck funcArgNamesDifferent warnings in blenlib
2024-05-07 13:07:02 +10:00
math_base_inline.c
ImBuf: Refactor pixel interpolation functions
2024-01-25 11:45:24 +01:00
math_base_safe_inline.c
Cleanup: Replace MIN/MAX macros with C++ functions
2024-01-22 15:58:18 +01:00
math_base.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
math_basis_types.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
math_bits_inline.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
math_boolean.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
math_color_blend_inline.c
Cleanup: spelling in comments
2024-04-27 11:58:02 +10:00
math_color_inline.c
BLI: Make color sRGB<->Linear non-SIMD fallback path use the same approximation
2024-05-03 12:05:56 +02:00
math_color.cc
Cleanup: various non functional changes
2024-05-28 14:09:40 +10:00
math_geom_inline.c
Cleanup: remove unused spherical harmonics functions
2023-11-07 21:16:47 +02:00
math_geom.cc
Cleanup: resolve cppcheck funcArgNamesDifferent warnings in blenlib
2024-05-07 13:07:02 +10:00
math_interp.cc
Refactor: Require C++ for users of BLI_simd.h
2024-05-02 16:22:19 +02:00
math_matrix_c.cc
Cleanup: various non functional changes
2024-05-28 14:09:40 +10:00
math_matrix.cc
Refactor: Require C++ for users of BLI_simd.h
2024-05-02 16:22:19 +02:00
math_rotation.c
Cleanup: use const pointers, quiet cppcheck unreadVariable warning
2024-04-17 11:36:38 +10:00
math_rotation.cc
BLI math: Do not use BLI_ASSERT_ C-style checks in modern cpp code.
2024-05-31 10:58:19 +02:00
math_solvers.c
Cleanup: remove redundant checks & assignments
2024-04-11 20:47:07 +10:00
math_statistics.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
math_time.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
math_vec.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
math_vector_inline.c
Cleanup: Replace most used of SWAP macro with std::swap
2024-01-31 21:12:16 -05:00
math_vector.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
memory_utils.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
mesh_boolean.cc
Cleanup: back-tick quote file extensions in code-comments
2024-05-04 15:06:46 +10:00
mesh_intersect.cc
Cleanup: use const args & variables, remove redundant checks
2024-04-15 09:50:47 +10:00
noise.c
Clang Format: bump to version 17
2024-01-03 13:38:14 +01:00
noise.cc
Fix #121969: Noise texture outputs 0 with coordinates beyond 8.40*10^6
2024-05-27 12:48:15 +02:00
offset_indices.cc
BLI: speedup memory bandwidth bound tasks by reducing threading
2024-03-19 18:23:56 +01:00
ordered_edge.cc
Mesh: add index-independent test for mesh equality
2023-11-27 16:10:43 +01:00
path_util.cc
Cleanup: quiet unused variable warnings
2024-04-25 12:09:31 +10:00
polyfill_2d_beautify.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
polyfill_2d.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
quadric.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
rand.cc
Cleanup: use const pointer arguments
2024-03-28 20:57:50 +11:00
rct.c
Cleanup: utility function to multiple rctf/rcti
2023-07-07 15:42:07 +10:00
resource_scope.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
scanfill_utils.c
Cleanup: Grammar in comments: Fix uses of "own"
2024-03-07 16:23:35 -05:00
scanfill.c
Cleanup: use const arguments & variables
2024-04-04 10:55:10 +11:00
serialize.cc
Refactor: Simplify BLI_serialize.hh for asset indexer
2024-03-13 14:52:57 -04:00
session_uid.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
smaa_textures.c
Cleanup: Add a copyright notice to files and use SPDX format
2023-05-31 16:19:06 +02:00
sort_utils.c
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
sort.c
Cleanup: spelling in comments
2024-03-27 10:25:31 +11:00
stack.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
storage_apple.mm
Cleanup: format
2024-05-11 14:42:34 +03:00
storage.cc
Cleanup: various non-functional changes for C++
2024-02-02 10:43:18 +11:00
string_cursor_utf8.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
string_ref.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
string_search.cc
BLI: use float instead of int for weights in string search
2024-04-12 14:34:17 +02:00
string_utf8.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
string_utils.cc
Cleanup: back-tick quote file extensions in code-comments
2024-05-04 15:06:46 +10:00
string.c
Cleanup: resolve cppcheck funcArgNamesDifferent warnings in blenlib
2024-05-07 13:07:02 +10:00
system_win32.c
Windows: Add ARM64 support
2024-03-06 16:14:34 +01:00
system.c
Cleanup: use C-style comments for descriptive text
2024-04-11 17:44:27 +10:00
task_graph.cc
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
task_iterator.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
task_pool.cc
Cleanup: use C-style comment blocks
2024-04-26 13:55:38 +10:00
task_range.cc
Unbreak build WITH_TBB=OFF
2024-04-30 12:12:02 +10:00
task_scheduler.cc
License Headers: Set copyright to "Blender Authors", add AUTHORS
2023-08-16 00:20:26 +10:00
tempfile.c
Cleanup: remove temporary directory creation
2024-03-05 09:54:49 +11:00
threads.cc
Windows: Add ARM64 support
2024-03-06 16:14:34 +01:00
time.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
timecode.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
timeit.cc
BLI: add count to ScopedTimerAveraged
2024-05-18 15:41:12 +02:00
uuid.cc
Cleanup: Add method to get UUID as std::string
2024-02-20 15:20:11 +01:00
uvproject.cc
Cleanup: use const pointers where camera data isn't modified
2024-03-08 17:15:08 +11:00
vector.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
virtual_array.cc
License headers: attribute copyright to "Blender Authors"
2023-11-07 15:42:52 +11:00
voxel.c
Revert changes from main commits that were merged into blender-v4.1-release
2024-02-19 15:59:59 +01:00
winstuff_dir.cc
Revert changes from main commits that were merged into blender-v4.0-release
2023-10-30 21:40:35 +01:00
winstuff_registration.cc
Fix #114906 invalid reuse of shell_link
2023-11-15 18:32:45 +01:00
winstuff.cc
Merge remote-tracking branch 'origin/blender-v4.0-release'
2023-10-31 18:51:26 -06:00