e24e58f293
This PR adds recycling of descriptor pools. Currently descriptor pools are discarded when full or context is flushed. This PR allows descriptor pools to be discarded for reuse. It is also more conservative and only discard Descriptor pools when they are full or fragmented. When using the Vulkan backend a small amount of descriptor memory can leak. Even when we clean up all resources, drivers can still keep data around on the GPU. Eventually this can lead to out of memory issues depending on how the GPU driver actually manages descriptor sets. When the descriptor sets of the descriptor pool aren't used anymore the VKDiscardPool will recycle the pools back to its original VKDescriptorPools. It needs to be the same instance as descriptor pools/sets are owned by a single thread. Pull Request: https://projects.blender.org/blender/blender/pulls/144992
77 lines
2.3 KiB
C++
77 lines
2.3 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup gpu
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "BLI_vector.hh"
|
|
|
|
#include "vk_descriptor_set.hh"
|
|
|
|
namespace blender::gpu {
|
|
class VKDevice;
|
|
|
|
/**
|
|
* List of VkDescriptorPools.
|
|
*
|
|
* In Vulkan a pool is constructed with a fixed size per resource type. When more resources are
|
|
* needed it a next pool should be created. VKDescriptorPools will keep track of those pools and
|
|
* construct new pools when the previous one is exhausted.
|
|
*/
|
|
class VKDescriptorPools {
|
|
/**
|
|
* Pool sizes to use. When one descriptor pool is requested to allocate a descriptor but isn't
|
|
* able to do so, it will fail.
|
|
*
|
|
* See VKDescriptorSetTracker::upload_descriptor_sets for rebalancing the pool sizes.
|
|
*/
|
|
static constexpr uint32_t POOL_SIZE_STORAGE_BUFFER = 1000;
|
|
static constexpr uint32_t POOL_SIZE_DESCRIPTOR_SETS = 250;
|
|
static constexpr uint32_t POOL_SIZE_STORAGE_IMAGE = 250;
|
|
static constexpr uint32_t POOL_SIZE_COMBINED_IMAGE_SAMPLER = 250;
|
|
static constexpr uint32_t POOL_SIZE_UNIFORM_BUFFER = 500;
|
|
static constexpr uint32_t POOL_SIZE_UNIFORM_TEXEL_BUFFER = 100;
|
|
static constexpr uint32_t POOL_SIZE_INPUT_ATTACHMENT = 100;
|
|
|
|
/**
|
|
* Unused recycled pools.
|
|
*
|
|
* When a pool is full it is being discarded (for reuse). After all descriptor sets of the pool
|
|
* are unused the descriptor pool can be reused.
|
|
* Note: descriptor pools/sets are pinned to a single thread so the pools should always return to
|
|
* the instance it was created on.
|
|
*/
|
|
Vector<VkDescriptorPool> recycled_pools_;
|
|
/** Active descriptor pool. Should always be a valid handle. */
|
|
VkDescriptorPool vk_descriptor_pool_ = VK_NULL_HANDLE;
|
|
Mutex mutex_;
|
|
|
|
public:
|
|
~VKDescriptorPools();
|
|
|
|
void init(const VKDevice &vk_device);
|
|
|
|
/**
|
|
* Allocate a new descriptor set.
|
|
*
|
|
* When the active descriptor pool is full it is discarded and another descriptor pool is
|
|
* ensured.
|
|
*/
|
|
VkDescriptorSet allocate(const VkDescriptorSetLayout descriptor_set_layout);
|
|
|
|
/**
|
|
* Recycle a previous discarded descriptor pool.
|
|
*/
|
|
void recycle(VkDescriptorPool vk_descriptor_pool);
|
|
|
|
private:
|
|
void add_new_pool(const VKDevice &device);
|
|
void discard_active_pool(VKContext &vk_context);
|
|
void ensure_pool(const VKDevice &device);
|
|
};
|
|
} // namespace blender::gpu
|