Fix #109840: Select similar crease broken after generic conversion

Thanks to Jesse Yurkovich for finding the issue, which was an incorrect
fallthrough that caused bevel weights to be used instead.
This commit is contained in:
Hans Goudey
2023-07-12 12:41:07 -04:00
parent a635f8bbf7
commit 12d7f8e7c1

View File

@@ -766,7 +766,15 @@ static int similar_edge_select_exec(bContext *C, wmOperator *op)
case SIMEDGE_CREASE: {
has_custom_data_layer = CustomData_has_layer_named(
&bm->edata, CD_PROP_FLOAT, "crease_edge");
ATTR_FALLTHROUGH;
if (!has_custom_data_layer) {
/* Proceed only if we have to select all the edges that have custom data value of 0.0f.
* In this case we will just select all the edges.
* Otherwise continue the for loop. */
if (!ED_select_similar_compare_float_tree(tree_1d, 0.0f, thresh, eSimilarCmp(compare))) {
continue;
}
}
break;
}
case SIMEDGE_BEVEL: {
has_custom_data_layer = CustomData_has_layer_named(
@@ -779,6 +787,7 @@ static int similar_edge_select_exec(bContext *C, wmOperator *op)
continue;
}
}
break;
}
}