griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: struct member name wasn't descriptive

Browse Source
This commit is contained in:
Campbell Barton
2019-08-27 15:06:53 +10:00
parent 2b618b0f2d
commit 13f54f65c4
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
source/blender/editors/mesh/editmesh_select.c
View File

@@ -204,8 +204,12 @@ struct EDBMSplitEdge {
struct EDBMSplitBestFaceData {
BMEdge **edgenet;
int edgenet_len;
float average;
/**
* Track the range of vertices on the faces normal,
* find the lowest since it's most likely to be most co-planar with the face.
*/
float best_face_range_on_normal_axis;
BMFace *r_best_face;
};
@@ -245,9 +249,9 @@ static bool edbm_vert_pair_share_best_splittable_face_cb(BMFace *f,
verts[1] = (*e_iter)->v2;
}
float average = max - min;
if (average < data->average) {
data->average = average;
const float test_face_range_on_normal_axis = max - min;
if (test_face_range_on_normal_axis < data->best_face_range_on_normal_axis) {
data->best_face_range_on_normal_axis = test_face_range_on_normal_axis;
data->r_best_face = f;
}
@@ -321,7 +325,7 @@ static void edbm_automerge_weld_linked_wire_edges_into_linked_faces(BMesh *bm,
struct EDBMSplitBestFaceData data = {
.edgenet = edgenet,
.edgenet_len = edgenet_len,
.average = FLT_MAX,
.best_face_range_on_normal_axis = FLT_MAX,
.r_best_face = NULL,
};
BM_vert_pair_shared_face_cb(