griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Compositor: Crash in Movie Distortion node with extreme distortions (again)

Browse Source 
Second version of 2dff457a7c, now without breaking negative deltas.
Thanks to @OmarEmaraDev for the suggestion.
This commit is contained in:
Lukas Stockner
2025-04-15 13:36:33 +02:00
parent ed91a298c0
commit 160c5e7b44
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/compositor/cached_resources/intern/distortion_grid.cc
View File

@@ -73,10 +73,16 @@ DistortionGrid::DistortionGrid(
&bottom_delta,
&top_delta);
/* Clamp deltas to avoid excessive memory requirements in case of extreme distortion. */
right_delta = math::min(right_delta, size.x);
left_delta = math::min(left_delta, size.x);
bottom_delta = math::min(bottom_delta, size.y);
top_delta = math::min(top_delta, size.y);
/* Extend the size by the deltas of the bounds. */
const int2 extended_size = size + int2(right_delta + left_delta, bottom_delta + top_delta);
distortion_grid_ = Array<float2>(extended_size.x * extended_size.y);
distortion_grid_ = Array<float2>(int64_t(extended_size.x) * extended_size.y);
parallel_for(extended_size, [&](const int2 texel) {
/* The tracking distortion functions expect the coordinates to be in the space of the image
* where the tracking camera was calibrated. So we first remap the coordinates into that space,
@@ -98,7 +104,8 @@ DistortionGrid::DistortionGrid(
/* Note that we should remap the coordinates back into the original size by dividing by the
* calibration size and multiplying by the size, however, we skip the latter to store the
* coordinates in normalized form, since this is what the shader expects. */
distortion_grid_[texel.y * extended_size.x + texel.x] = coordinates / float2(calibration_size);
distortion_grid_[texel.y * int64_t(extended_size.x) + texel.x] = coordinates /
float2(calibration_size);
});
BKE_tracking_distortion_free(distortion);