griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #143161: Armature select crashes with over 65k objects

Browse Source 
Add null check to resolve crash when a "base" can't be retrieved
from the GPU selection index.
This commit is contained in:
Campbell Barton
2025-07-25 14:57:15 +10:00
parent b92b47f628
commit 19b59ccaab
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/editors/space_view3d/view3d_select.cc
View File

@@ -2753,6 +2753,9 @@ static bool ed_object_select_pick(bContext *C,
/* Special case, even when there are no hits, pose logic may de-select all bones. */
((gpu->hits == 0) && has_pose_old))
{
/* Regarding the `basact` null checks.
* While it's unlikely there are GPU hits *without* `basact` being found,
* it's possible looking up the selection index fails, see: #143161. */
if (basact && (gpu->has_bones && (basact->object->type == OB_CAMERA))) {
MovieClip *clip = BKE_object_movieclip_get(scene, basact->object, false);
@@ -2774,7 +2777,8 @@ static bool ed_object_select_pick(bContext *C,
}
}
}
else if (ED_armature_pose_select_pick_with_buffer(scene,
else if ((basact || oldbasact) &&
ED_armature_pose_select_pick_with_buffer(scene,
view_layer,
v3d,
basact ? basact : (Base *)oldbasact,