griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

UI: show a more useful error when attempting to "Join" faces

Browse Source 
Joining faces isn't supported.
This commit is contained in:
Campbell Barton
2025-10-03 15:15:05 +10:00
parent 04a499bc5a
commit 1fedb0707d
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/editors/mesh/editmesh_tools.cc
View File

@@ -1544,6 +1544,7 @@ static wmOperatorStatus edbm_vert_connect_path_exec(bContext *C, wmOperator *op)
uint failed_selection_order_len = 0;
uint failed_connect_len = 0;
bool has_select_history_mixed = false;
bool has_select_history_face = false;
const Vector<Object *> objects = BKE_view_layer_array_from_objects_in_edit_mode_unique_data(
scene, view_layer, CTX_wm_view3d(C));
@@ -1572,6 +1573,12 @@ static wmOperatorStatus edbm_vert_connect_path_exec(bContext *C, wmOperator *op)
failed_selection_order_len++;
continue;
}
/* Faces are not supported, this check is only done to show a more useful error. */
if (htype_selected & BM_FACE) {
has_select_history_face = true;
failed_selection_order_len++;
continue;
}
if (bm->selected.first) {
BMEditSelection *ese = static_cast<BMEditSelection *>(bm->selected.first);
@@ -1609,6 +1616,9 @@ static wmOperatorStatus edbm_vert_connect_path_exec(bContext *C, wmOperator *op)
if (has_select_history_mixed) {
BKE_report(op->reports, RPT_ERROR, "Could not connect mixed selection types");
}
else if (has_select_history_face) {
BKE_report(op->reports, RPT_ERROR, "Could not connect a face selection");
}
else {
BKE_report(op->reports, RPT_ERROR, "Invalid selection order");
}