griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: remove unused perspective argument to off-screen drawing

Browse Source 
Some callers were passing in dummy values, this can be accessed from
`RegionView3D.is_persp` can be used to check this.
This commit is contained in:
Campbell Barton
2020-11-20 12:03:22 +11:00
parent 25266caa45
commit 219c3aa653
4 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/editors/include/ED_view3d_offscreen.h
View File

@@ -52,7 +52,6 @@ void ED_view3d_draw_offscreen(struct Depsgraph *depsgraph,
const float winmat[4][4],
bool is_image_render,
bool do_sky,
bool is_persp,
const char *viewname,
const bool do_color_management,
struct GPUOffScreen *ofs,
@@ -70,7 +69,6 @@ void ED_view3d_draw_offscreen_simple(struct Depsgraph *depsgraph,
float clip_end,
bool is_image_render,
bool do_sky,
bool is_persp,
const char *viewname,
const bool do_color_management,
struct GPUOffScreen *ofs,

4
source/blender/editors/space_view3d/view3d_draw.c
View File

@@ -1667,7 +1667,6 @@ void ED_view3d_draw_offscreen(Depsgraph *depsgraph,
const float winmat[4][4],
bool is_image_render,
bool do_sky,
bool UNUSED(is_persp),
const char *viewname,
const bool do_color_management,
GPUOffScreen *ofs,
@@ -1761,7 +1760,6 @@ void ED_view3d_draw_offscreen_simple(Depsgraph *depsgraph,
float clip_end,
bool is_image_render,
bool do_sky,
bool is_persp,
const char *viewname,
const bool do_color_management,
GPUOffScreen *ofs,
@@ -1825,7 +1823,6 @@ void ED_view3d_draw_offscreen_simple(Depsgraph *depsgraph,
winmat,
is_image_render,
do_sky,
is_persp,
viewname,
do_color_management,
ofs,
@@ -1943,7 +1940,6 @@ ImBuf *ED_view3d_draw_offscreen_imbuf(Depsgraph *depsgraph,
winmat,
true,
draw_sky,
!is_ortho,
viewname,
do_color_management,
ofs,

1
source/blender/python/gpu/gpu_py_offscreen.c
View File

@@ -265,7 +265,6 @@ static PyObject *bpygpu_offscreen_draw_view3d(BPyGPUOffScreen *self,
(float(*)[4])py_mat_projection->matrix,
true,
true,
true,
"",
false,
self->ofs,

1
source/blender/windowmanager/xr/intern/wm_xr_draw.c
View File

@@ -142,7 +142,6 @@ void wm_xr_draw_view(const GHOST_XrDrawViewInfo *draw_view, void *customdata)
settings->clip_end,
false,
true,
true,
NULL,
false,
surface_data->offscreen,