griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix use-after free while transforming sequence strips

Browse Source 
Resolve use after free & potential double-free introduced in [0].

[0]: fd51d2f97c
This commit is contained in:
Campbell Barton
2023-07-05 14:57:38 +10:00
parent 28c3a0a980
commit 3195a4cef1
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/sequencer/intern/image_cache.c
View File

@@ -671,10 +671,9 @@ void seq_cache_cleanup_sequence(Scene *scene,
BLI_ghash_remove(cache->hash, key, seq_cache_keyfree, seq_cache_valfree);
}
if (key->type & invalidate_source && key->seq == seq &&
key->timeline_frame >= SEQ_time_left_handle_frame_get(scene, seq_changed) &&
key->timeline_frame <= SEQ_time_right_handle_frame_get(scene, seq_changed))
else if (key->type & invalidate_source && key->seq == seq &&
key->timeline_frame >= SEQ_time_left_handle_frame_get(scene, seq_changed) &&
key->timeline_frame <= SEQ_time_right_handle_frame_get(scene, seq_changed))
{
if (key->link_next || key->link_prev) {
seq_cache_relink_keys(key->link_next, key->link_prev);