griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

LibOverride: avoid unnecessary GHash lookup

Browse Source 
In my test file with many bones (very few of which have an override) this leads
to a 5-10% speedup when saving the file.

Pull Request: https://projects.blender.org/blender/blender/pulls/117803
This commit is contained in:
Jacques Lucke
2024-02-06 13:53:03 +01:00
parent 74971e06f0
commit 49f4b643b9
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
source/blender/makesrna/intern/rna_access_compare_override.cc
View File

@@ -779,12 +779,13 @@ bool RNA_struct_override_matches(Main *bmain,
CLOG_INFO(&LOG, 5, "Override Checking %s", rna_path->c_str());
IDOverrideLibraryProperty *op = BKE_lib_override_library_property_find(liboverride,
rna_path->c_str());
if (ignore_overridden && op != nullptr) {
BKE_lib_override_library_operations_tag(op, LIBOVERRIDE_PROP_OP_TAG_UNUSED, false);
continue;
if (ignore_overridden) {
IDOverrideLibraryProperty *op = BKE_lib_override_library_property_find(liboverride,
rna_path->c_str());
if (op != nullptr) {
BKE_lib_override_library_operations_tag(op, LIBOVERRIDE_PROP_OP_TAG_UNUSED, false);
continue;
}
}
#ifdef DEBUG_OVERRIDE_TIMEIT
@@ -819,7 +820,8 @@ bool RNA_struct_override_matches(Main *bmain,
if (diff != 0) {
/* XXX TODO: refine this for per-item overriding of arrays... */
op = BKE_lib_override_library_property_find(liboverride, rna_path->c_str());
IDOverrideLibraryProperty *op = BKE_lib_override_library_property_find(liboverride,
rna_path->c_str());
IDOverrideLibraryPropertyOperation *opop = static_cast<IDOverrideLibraryPropertyOperation *>(
op ? op->operations.first : nullptr);