griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix T70033: Crash editing keymap operator

Browse Source 
Expanding operator names could buffer overrun.
This commit is contained in:
Campbell Barton
2019-09-19 17:15:19 +10:00
parent 86590b90aa
commit 4e9aadac5e
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/windowmanager/intern/wm_operators.c
View File

@@ -140,13 +140,13 @@ void WM_operator_bl_idname(char *to, const char *from)
if (from) {
const char *sep = strchr(from, '.');
if (sep) {
int ofs = (sep - from);
int from_len;
if (sep && (from_len = strlen(from)) < OP_MAX_TYPENAME - 3) {
const int ofs = (sep - from);
memcpy(to, from, sizeof(char) * ofs);
BLI_str_toupper_ascii(to, ofs);
strcpy(to + ofs, "_OT_");
strcpy(to + (ofs + 4), sep + 1);
memcpy(to + ofs, "_OT_", 4);
memcpy(to + (ofs + 4), sep + 1, (from_len - ofs));
}
else {
/* should not happen but support just in case */