griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor: Remove friend class from Cycles viewport parameters

Browse Source 
Such pattern should only be used when it is really needed. Otherwise
just stick to a more regular design, without worrying who is the user
of the class. Otherwise it will be annoying to subclass or unit test.
This commit is contained in:
Sergey Sharybin
2021-05-27 11:07:58 +02:00
parent bf7a67c5c6
commit 4ea7742973
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
intern/cycles/blender/blender_viewport.h
View File

@@ -28,7 +28,7 @@
CCL_NAMESPACE_BEGIN
class BlenderViewportParameters {
private:
public:
bool use_scene_world;
bool use_scene_lights;
float studiolight_rotate_z;
@@ -37,13 +37,11 @@ class BlenderViewportParameters {
ustring studiolight_path;
BlenderViewportParameters();
BlenderViewportParameters(BL::SpaceView3D &b_v3d);
explicit BlenderViewportParameters(BL::SpaceView3D &b_v3d);
const bool modified(const BlenderViewportParameters &other) const;
const bool custom_viewport_parameters() const;
friend class BlenderSync;
public:
/* Retrieve the render pass type that needs to be displayed on the given `SpaceView3D`
* When the `b_v3d` parameter is not given `PASS_NONE` will be returned. */
static PassType get_render_pass(BL::SpaceView3D &b_v3d);