griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix bug #2006:

Browse Source 
Floating point imprecision made MT_Quaternion::angle return NaN, since acos(x) is NaN for |x| > 1.

Because of the way NaN's propagate through float math, the view pos would be set to [NaN, NaN, NaN] resulting in a grey screen.
This commit is contained in:
Kester Maddock
2005-01-09 00:06:45 +00:00
parent 5ea2ed38e7
commit 4f2e57a541
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
intern/moto/include/MT_Quaternion.inl
View File

@@ -64,13 +64,19 @@ GEN_INLINE MT_Scalar MT_Quaternion::angle(const MT_Quaternion& q) const
{
MT_Scalar s = sqrt(length2() * q.length2());
assert(s != MT_Scalar(0.0));
return acos(dot(q) / s);
s = dot(q) / s;
s = MT_clamp(s, -1.0, 1.0);
return acos(s);
}
GEN_INLINE MT_Quaternion MT_Quaternion::slerp(const MT_Quaternion& q, const MT_Scalar& t) const
{
MT_Scalar theta = angle(q);
if (theta != MT_Scalar(0.0))
if (!MT_fuzzyZero(theta))
{
MT_Scalar d = MT_Scalar(1.0) / sin(theta);
MT_Scalar s0 = sin((MT_Scalar(1.0) - t) * theta);

8
intern/moto/include/MT_Scalar.h
View File

@@ -83,5 +83,13 @@ inline MT_Scalar MT_random() {
return MT_Scalar(MT_rand()) / MT_Scalar(MT_RAND_MAX);
}
inline MT_Scalar MT_clamp(const MT_Scalar x, const MT_Scalar min, const MT_Scalar max)
{
if (x < min)
return min;
else if (x > max)
return max;
return x;
}
#endif