griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: VSE: Tweaking strip with selected handle

Browse Source 
Originally, `element_already_selected` would always return `true`
as long as the user clicked on a strip that was already selected,
regardless of its handle selection state.

This led to unexpected behavior when trying to tweak a strip:
E.g. taking a strip, selecting its left handle, then trying to tweak
the strip itself would actually tweak the left handle unexpectedly, even
though the cursor would be far enough away that this does not make sense.
This commit is contained in:
John Kiril Swenson
2025-05-19 02:16:52 -05:00
committed by John Kiril Swenson
parent 98090e0400
commit 50321bac99
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/editors/space_sequencer/sequencer_select.cc
View File

@@ -843,12 +843,16 @@ static bool element_already_selected(const StripSelection &selection)
if (selection.strip1 == nullptr) {
return false;
}
const bool strip1_already_selected = ((selection.strip1->flag & SELECT) != 0);
if (selection.strip2 == nullptr) {
const bool handle_already_selected = handle_is_selected(selection.strip1, selection.handle) ||
selection.handle == STRIP_HANDLE_NONE;
return strip1_already_selected && handle_already_selected;
if (selection.handle == STRIP_HANDLE_NONE) {
return strip1_already_selected && !(selection.strip1->flag & (SEQ_LEFTSEL | SEQ_RIGHTSEL));
}
return strip1_already_selected && handle_is_selected(selection.strip1, selection.handle);
}
/* If we are here, the strip selection is dual handle. */
const bool strip2_already_selected = ((selection.strip2->flag & SELECT) != 0);
const int strip1_handle = selection.strip1->flag & (SEQ_RIGHTSEL | SEQ_LEFTSEL);
const int strip2_handle = selection.strip2->flag & (SEQ_RIGHTSEL | SEQ_LEFTSEL);