griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: EEVEE: Depth Of Field: Tile artifact on noisy input

Browse Source 
This was caused by the denoiser of the slight out of focus
pass having too much influence at low CoC values.

Making the transition start at 0.5 fixes the issue.

Fixes #123822
This commit is contained in:
Clément Foucault
2024-06-29 17:08:14 +02:00
parent 49491bc541
commit 53cb73ecea
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/draw/engines/eevee_next/shaders/eevee_depth_of_field_resolve_comp.glsl
View File

@@ -20,11 +20,6 @@ shared uint shared_max_slight_focus_abs_coc;
*/
float dof_slight_focus_coc_tile_get(vec2 frag_coord)
{
if (gl_LocalInvocationIndex == 0u) {
shared_max_slight_focus_abs_coc = floatBitsToUint(0.0);
}
barrier();
float local_abs_max = 0.0;
/* Sample in a cross (X) pattern. This covers all pixels over the whole tile, as long as
* dof_max_slight_focus_radius is less than the group size. */
@@ -37,6 +32,11 @@ float dof_slight_focus_coc_tile_get(vec2 frag_coord)
local_abs_max = max(local_abs_max, abs(coc));
}
}
if (gl_LocalInvocationIndex == 0u) {
shared_max_slight_focus_abs_coc = floatBitsToUint(0.0);
}
barrier();
/* Use atomic reduce operation. */
atomicMax(shared_max_slight_focus_abs_coc, floatBitsToUint(local_abs_max));
/* "Broadcast" result across all threads. */
@@ -76,7 +76,7 @@ vec3 dof_neighborhood_clamp(vec2 frag_coord, vec3 color, float center_coc, float
neighbor_max += abs(neighbor_min) * padding;
neighbor_min -= abs(neighbor_min) * padding;
/* Progressively apply the clamp to avoid harsh transition. Also mask by weight. */
float fac = saturate(square(center_coc) * 4.0) * weight;
float fac = saturate(square(max(0.0, abs(center_coc) - 0.5)) * 4.0) * weight;
/* Clamp in YCoCg space to avoid too much color drift. */
color = colorspace_YCoCg_from_scene_linear(color);
color = mix(color, clamp(color, neighbor_min, neighbor_max), fac);