griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #139022: Cycles: Mix Color Node using socket values when constant folded

Browse Source 
If Mix Color node clamps the result, we do not bypass the node, but
disconnect other inputs. However, for the case where both inputs were the
same, the disconnected one would use the stored socket value instead, so
set the factor to 0 to only use the intended input.

Pull Request: https://projects.blender.org/blender/blender/pulls/139098
This commit is contained in:
Weizhen Huang
2025-05-20 12:30:20 +02:00
committed by Weizhen Huang
parent ecfd9ec2d7
commit 54e748852a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
intern/cycles/scene/constant_fold.cpp
View File

@@ -330,7 +330,10 @@ void ConstantFolder::fold_mix_color(NodeMix type, bool clamp_factor, bool clamp)
/* remove useless mix colors nodes */
if (color1_in->link && color2_in->link) {
if (color1_in->link == color2_in->link) {
try_bypass_or_make_constant(color1_in, clamp);
if (!try_bypass_or_make_constant(color1_in, clamp)) {
/* If can't bypass, set `fac` to 0 to only use `color1_in`. */
fac_in->set(0.0f);
}
break;
}
}