griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

EEVEE: Fix incorrect texture usage DoF

Browse Source 
The color textures in the DoF module are also bound in gather
framebuffer but didn't got the correct usage flags resulting in
validation errors.

Pull Request: https://projects.blender.org/blender/blender/pulls/123650
This commit is contained in:
Jeroen Bakker
2024-06-24 10:08:10 +02:00
parent d8fafad704
commit 560b36ac8d
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/draw/engines/eevee_next/eevee_depth_of_field.cc
View File

@@ -564,8 +564,10 @@ void DepthOfField::render(View &view,
Manager &drw = *inst_.manager;
eGPUTextureUsage usage_readwrite = GPU_TEXTURE_USAGE_SHADER_READ |
GPU_TEXTURE_USAGE_SHADER_WRITE;
constexpr eGPUTextureUsage usage_readwrite = GPU_TEXTURE_USAGE_SHADER_READ |
GPU_TEXTURE_USAGE_SHADER_WRITE;
constexpr eGPUTextureUsage usage_readwrite_attach = usage_readwrite |
GPU_TEXTURE_USAGE_ATTACHMENT;
{
DRW_stats_group_start("Setup");
{
@@ -678,7 +680,7 @@ void DepthOfField::render(View &view,
PassSimple &filter_ps = is_background ? filter_bg_ps_ : filter_fg_ps_;
PassSimple &scatter_ps = is_background ? scatter_bg_ps_ : scatter_fg_ps_;
color_tx.current().acquire(half_res, GPU_RGBA16F, usage_readwrite);
color_tx.current().acquire(half_res, GPU_RGBA16F, usage_readwrite_attach);
weight_tx.current().acquire(half_res, GPU_R16F, usage_readwrite);
occlusion_tx_.acquire(half_res, GPU_RG16F);
@@ -689,7 +691,7 @@ void DepthOfField::render(View &view,
color_tx.swap();
weight_tx.swap();
color_tx.current().acquire(half_res, GPU_RGBA16F, usage_readwrite);
color_tx.current().acquire(half_res, GPU_RGBA16F, usage_readwrite_attach);
weight_tx.current().acquire(half_res, GPU_R16F, usage_readwrite);
drw.submit(filter_ps, view);