griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Anim: pose mode Select Mirrored keep unmirrorables selected

Browse Source 
The pose mode Select Mirrored operator now keeps bones selected when
they cannot be mirrored.

This means that you can now select the spine and the left arm, mirror
the selection, and it'll have the spine and the right arm selected.
Before this change, all non-mirrorable bones (like the spine) would
always get deselected.

I also snuck in a little bugfix, where locked-for-selection bones could
still get selected.

Pull Request: https://projects.blender.org/blender/blender/pulls/136836
This commit is contained in:
Sybren A. Stüvel
2025-04-01 15:00:45 +02:00
parent 442fba3889
commit 57fdaadebb
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/editors/armature/pose_select.cc
View File

@@ -1139,7 +1139,10 @@ static wmOperatorStatus pose_select_mirror_exec(bContext *C, wmOperator *op)
/* Remember the pre-mirroring selection flags of the bones. */
blender::Map<bPoseChannel *, eBone_Flag> old_selection_flags;
LISTBASE_FOREACH (bPoseChannel *, pchan, &ob->pose->chanbase) {
old_selection_flags.add_new(pchan, eBone_Flag(pchan->bone->flag));
/* Treat invisible bones as deselected. */
const int flags = PBONE_VISIBLE(arm, pchan->bone) ? pchan->bone->flag : 0;
old_selection_flags.add_new(pchan, eBone_Flag(flags));
}
LISTBASE_FOREACH (bPoseChannel *, pchan, &ob->pose->chanbase) {
@@ -1148,8 +1151,10 @@ static wmOperatorStatus pose_select_mirror_exec(bContext *C, wmOperator *op)
}
bPoseChannel *pchan_mirror = BKE_pose_channel_get_mirrored(ob->pose, pchan->name);
if (!pchan_mirror || !PBONE_VISIBLE(arm, pchan_mirror->bone)) {
set_bone_selection_flags(pchan, eBone_Flag(0));
if (!pchan_mirror) {
/* If a bone cannot be mirrored, keep its flags as-is. This makes it possible to select
* the spine and an arm, and still flip the selection to the other arm (without losing
* the selection on the spine). */
continue;
}
@@ -1157,7 +1162,7 @@ static wmOperatorStatus pose_select_mirror_exec(bContext *C, wmOperator *op)
pchan_mirror_act = pchan_mirror;
}
/* Skip all but the active or its mirror. */
/* If active-only, don't touch unrelated bones. */
if (active_only && !ELEM(arm->act_bone, pchan->bone, pchan_mirror->bone)) {
continue;
}