griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #131134: EEVEE: Playback performance degrades over time

Browse Source 
Ensure `object_steps_usage` is properly reset to prevent `object_steps`
from growing every frame.

Pull Request: https://projects.blender.org/blender/blender/pulls/131165
This commit is contained in:
Miguel Pozo
2024-12-03 16:24:04 +01:00
parent a265b591be
commit 5ffa4c4ffb
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/draw/engines/eevee_next/eevee_velocity.cc
View File

@@ -167,7 +167,8 @@ bool VelocityModule::step_object_sync(ObjectKey &object_key,
object_steps[STEP_PREVIOUS]->get_or_resize(
vel.obj.ofs[STEP_PREVIOUS]) = ob->object_to_world();
}
if (vel.obj.ofs[STEP_NEXT] == -1) {
/* STEP_NEXT is not used in viewport. */
if (vel.obj.ofs[STEP_NEXT] == -1 && !inst_.is_viewport()) {
vel.obj.ofs[STEP_NEXT] = object_steps_usage[STEP_NEXT]++;
object_steps[STEP_NEXT]->get_or_resize(vel.obj.ofs[STEP_NEXT]) = ob->object_to_world();
}
@@ -216,11 +217,11 @@ bool VelocityModule::step_object_sync(ObjectKey &object_key,
if (step_ == STEP_CURRENT && has_motion == true && has_deform == false) {
const float4x4 &obmat_curr = (*object_steps[STEP_CURRENT])[vel.obj.ofs[STEP_CURRENT]];
const float4x4 &obmat_prev = (*object_steps[STEP_PREVIOUS])[vel.obj.ofs[STEP_PREVIOUS]];
const float4x4 &obmat_next = (*object_steps[STEP_NEXT])[vel.obj.ofs[STEP_NEXT]];
if (inst_.is_viewport()) {
has_motion = (obmat_curr != obmat_prev);
}
else {
const float4x4 &obmat_next = (*object_steps[STEP_NEXT])[vel.obj.ofs[STEP_NEXT]];
has_motion = (obmat_curr != obmat_prev || obmat_curr != obmat_next);
}
}
@@ -313,6 +314,7 @@ void VelocityModule::step_swap()
std::swap(geometry_steps[step_a], geometry_steps[step_b]);
std::swap(camera_steps[step_a], camera_steps[step_b]);
std::swap(step_time[step_a], step_time[step_b]);
std::swap(object_steps_usage[step_a], object_steps_usage[step_b]);
for (VelocityObjectData &vel : velocity_map.values()) {
vel.obj.ofs[step_a] = vel.obj.ofs[step_b];
@@ -343,6 +345,9 @@ void VelocityModule::begin_sync()
step_ = STEP_CURRENT;
step_camera_sync();
object_steps_usage[step_] = 0;
/* STEP_NEXT is not used for viewport. (See #131134) */
BLI_assert(!inst_.is_viewport() || object_steps_usage[STEP_NEXT] == 0);
}
void VelocityModule::end_sync()