griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Vulkan: Reduce Pipeline Logging

Browse Source 
Pipeline pool could log to much information that confused developers who
are not up to date what pipelines are. This PR will hide the confusing
messages. When working on Vulkan these messages can still be shown by
raising the log level.

See !128254

Pull Request: https://projects.blender.org/blender/blender/pulls/128352
This commit is contained in:
Jeroen Bakker
2024-09-30 08:46:17 +02:00
parent b6aa4a3142
commit 6ec35c619f
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/gpu/vulkan/vk_pipeline_pool.cc
View File

@@ -691,7 +691,7 @@ static std::string pipeline_cache_filepath_get()
std::string cache_dir = std::string(tmp_dir_buffer) + "vk-pipeline-cache" + SEP_STR;
BLI_dir_create_recursive(cache_dir.c_str());
std::string cache_file = cache_dir + "static-shaders.bin";
std::string cache_file = cache_dir + "static.bin";
return cache_file;
}
#endif
@@ -729,14 +729,15 @@ void VKPipelinePool::read_from_disk()
* [https://medium.com/@zeuxcg/creating-a-robust-pipeline-cache-with-vulkan-961d09416cda]
*/
MEM_freeN(buffer);
CLOG_WARN(&LOG,
CLOG_INFO(&LOG,
1,
"Pipeline cache on disk [%s] is ignored as it was written by a different driver or "
"Blender version.",
"Blender version. Cache will be overwritten when exiting.",
cache_file.c_str());
return;
}
CLOG_INFO(&LOG, 0, "Initialize static pipeline cache from disk [%s].", cache_file.c_str());
CLOG_INFO(&LOG, 1, "Initialize static pipeline cache from disk [%s].", cache_file.c_str());
VKDevice &device = VKBackend::get().device;
VkPipelineCacheCreateInfo create_info = {};
create_info.sType = VK_STRUCTURE_TYPE_PIPELINE_CACHE_CREATE_INFO;
@@ -767,7 +768,7 @@ void VKPipelinePool::write_to_disk()
vkGetPipelineCacheData(device.vk_handle(), vk_pipeline_cache_static_, &data_size, buffer);
std::string cache_file = pipeline_cache_filepath_get();
CLOG_INFO(&LOG, 0, "Writing static pipeline cache to disk [%s].", cache_file.c_str());
CLOG_INFO(&LOG, 1, "Writing static pipeline cache to disk [%s].", cache_file.c_str());
fstream file(cache_file, std::ios::binary | std::ios::out);