griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: wrong pivot point output in String to Curves node

Browse Source 
The issue was that using `curves.bounds_min_max` included the radius
which does not make sense in this context.
This commit is contained in:
Jacques Lucke
2022-12-05 13:20:16 +01:00
parent 44ab02fc5c
commit 83077d3683
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/nodes/geometry/nodes/node_geo_string_to_curves.cc
View File

@@ -9,6 +9,7 @@
#include "BKE_instances.hh"
#include "BKE_vfont.h"
#include "BLI_bounds.hh"
#include "BLI_hash.h"
#include "BLI_string_utf8.h"
#include "BLI_task.hh"
@@ -109,12 +110,14 @@ static float3 get_pivot_point(GeoNodeExecParams &params, bke::CurvesGeometry &cu
const GeometryNodeStringToCurvesPivotMode pivot_mode = (GeometryNodeStringToCurvesPivotMode)
storage.pivot_mode;
float3 min(FLT_MAX), max(FLT_MIN);
const std::optional<Bounds<float3>> bounds = bounds::min_max(curves.positions());
/* Check if curve is empty. */
if (!curves.bounds_min_max(min, max)) {
if (!bounds.has_value()) {
return {0.0f, 0.0f, 0.0f};
}
const float3 min = bounds->min;
const float3 max = bounds->max;
switch (pivot_mode) {
case GEO_NODE_STRING_TO_CURVES_PIVOT_MODE_MIDPOINT: