griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix part 2 of [#31840] Quick Explode Bugs related to it's fade option.

Browse Source 
This in fact had nothing to see with this operator or its fade option, reports were simply not shown when repeating an operator.

Carefully checked/tracked all calls to wm_operator_exec and WM_operator_repeat, and could not see any reason why this was this way, so I disabled this. Very easy to undo in case ugly problems arize (but I really do not expect any!).
This commit is contained in:
Bastien Montagne
2012-06-19 16:26:01 +00:00
parent 4f044f4ec1
commit 8796c3eff1
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/windowmanager/intern/wm_event_system.c
View File

@@ -582,7 +582,10 @@ static int wm_operator_exec(bContext *C, wmOperator *op, int repeat)
wm->op_undo_depth--;
}
if (retval & (OPERATOR_FINISHED | OPERATOR_CANCELLED) && repeat == 0)
/* XXX Disabled the repeat check to address part 2 of #31840.
* Carefully checked all calls to wm_operator_exec and WM_operator_repeat, don't see any reason
* why this was needed, but worth to note it in case something turns bad. (mont29) */
if (retval & (OPERATOR_FINISHED | OPERATOR_CANCELLED)/* && repeat == 0 */)
wm_operator_reports(C, op, retval, FALSE);
if (retval & OPERATOR_FINISHED) {