griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #141515: Compositor: Crash when tweaking gizmos

Browse Source 
Fix crash when tweaking following gizmos:
- Box Mask
- Ellipse Mask
- Crop

This commit uses the same workaround to trigger an update for gizmos
(see also Sun Beams, Corner Pin and previous versions of the above
mentioned gizmos).

A better solution is needed for gizmo updates. This will be
investigated and submitted separately.

Pull Request: https://projects.blender.org/blender/blender/pulls/141542
This commit is contained in:
Habib Gahbiche
2025-07-07 12:19:08 +02:00
parent c40d8f50b6
commit 8bd8754268
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/editors/space_node/node_gizmo.cc
View File

@@ -423,10 +423,12 @@ static void WIDGETGROUP_node_crop_refresh(const bContext *C, wmGizmoGroup *gzgro
bNode *node = bke::node_get_active(*snode->edittree);
crop_group->update_data.context = (bContext *)C;
bNodeSocket *source_input = bke::node_find_socket(*node, SOCK_IN, "Alpha Crop");
crop_group->update_data.ptr = RNA_pointer_create_discrete(
(ID *)snode->edittree, &RNA_CompositorNodeCrop, node);
reinterpret_cast<ID *>(snode->edittree), &RNA_NodeSocket, source_input);
crop_group->update_data.prop = RNA_struct_find_property(&crop_group->update_data.ptr,
"relative");
"enabled");
BLI_assert(crop_group->update_data.prop != nullptr);
wmGizmoPropertyFnParams params{};
params.value_get_fn = gizmo_node_crop_prop_matrix_get;
@@ -623,9 +625,12 @@ static void WIDGETGROUP_node_mask_refresh(const bContext *C, wmGizmoGroup *gzgro
bNode *node = bke::node_get_active(*snode->edittree);
mask_group->update_data.context = (bContext *)C;
bNodeSocket *source_input = bke::node_find_socket(*node, SOCK_IN, "Mask");
mask_group->update_data.ptr = RNA_pointer_create_discrete(
(ID *)snode->edittree, &RNA_CompositorNodeCrop, node);
mask_group->update_data.prop = RNA_struct_find_property(&mask_group->update_data.ptr, "x");
reinterpret_cast<ID *>(snode->edittree), &RNA_NodeSocket, source_input);
mask_group->update_data.prop = RNA_struct_find_property(&mask_group->update_data.ptr,
"enabled");
BLI_assert(mask_group->update_data.prop != nullptr);
wmGizmoPropertyFnParams params{};
params.value_get_fn = gizmo_node_box_mask_prop_matrix_get;