griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Tests: remove unnecessary fmod in BLI_convexhull_2d_test

Browse Source 
The intention was to accept both 0 and M_PI however this isn't needed
as the result is always M_PI.

See !118186 for details.
This commit is contained in:
Campbell Barton
2024-02-13 18:20:46 +11:00
parent da2ba2f3f6
commit 9ad127780a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/blenlib/tests/BLI_convexhull_2d_test.cc
View File

@@ -226,7 +226,7 @@ TEST(convexhull_2d, Lines_AxisAligned)
}
blender::Array<float2> points_hull = convexhull_2d_as_array(points);
EXPECT_NEAR(std::fmod(convexhull_aabb_fit_hull_2d(points_hull), M_PI), 0.0f, ROTATION_EPS);
EXPECT_NEAR(convexhull_aabb_fit_hull_2d(points_hull), M_PI, ROTATION_EPS);
}
}
@@ -241,7 +241,7 @@ TEST(convexhull_2d, Lines_AxisAligned)
}
blender::Array<float2> points_hull = convexhull_2d_as_array(points);
EXPECT_NEAR(std::fmod(convexhull_aabb_fit_hull_2d(points_hull), M_PI), 0.0f, ROTATION_EPS);
EXPECT_NEAR(convexhull_aabb_fit_hull_2d(points_hull), M_PI, ROTATION_EPS);
}
}
}