griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #146671: Weight Paint gradient tool can cause NaN

Browse Source 
A combination of a linear gradient with the 'Sphere' distance curve
preset could cause NaN values due to evaluating the sqrt of a negative
value. To avoid this, clamp the input value to a lower bound of 0.0f.
This fixes the Smooth, Sphere, and Inverse Square presets.

Pull Request: https://projects.blender.org/blender/blender/pulls/146693
This commit is contained in:
Sean Kim
2025-10-09 21:03:28 +02:00
committed by Sean Kim
parent 73645a1047
commit a0ae015a42
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/sculpt_paint/paint_vertex_weight_ops.cc
View File

@@ -595,10 +595,9 @@ static void gradientVert_update(WPGradient_userData *grad_data, int index)
BLI_assert(grad_data->type == WPAINT_GRADIENT_TYPE_RADIAL);
alpha = len_v2v2(grad_data->sco_start, vs->sco) * grad_data->sco_line_div;
}
/* no need to clamp 'alpha' yet */
/* adjust weight */
alpha = BKE_brush_curve_strength_clamped(grad_data->brush, alpha, 1.0f);
alpha = BKE_brush_curve_strength_clamped(grad_data->brush, std::max(0.0f, alpha), 1.0f);
if (alpha != 0.0f) {
MDeformVert *dv = &grad_data->dvert[index];