griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Shaders: change default IOR from 1.45 to 1.5

Browse Source 
To match OpenPBR and Standard Surface. Most IOR real values are in a range
of 1.3 to 1.6, might as well use the more round and common number.

Pull Request: https://projects.blender.org/blender/blender/pulls/115770
This commit is contained in:
Brecht Van Lommel
2023-12-04 21:12:29 +01:00
committed by Brecht Van Lommel
parent 56cc47ee2e
commit a1804f35f7
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
intern/cycles/scene/shader_nodes.cpp
View File

@@ -2425,7 +2425,7 @@ NODE_DEFINE(GlassBsdfNode)
SOCKET_ENUM(
distribution, "Distribution", distribution_enum, CLOSURE_BSDF_MICROFACET_GGX_GLASS_ID);
SOCKET_IN_FLOAT(roughness, "Roughness", 0.0f);
SOCKET_IN_FLOAT(IOR, "IOR", 0.3f);
SOCKET_IN_FLOAT(IOR, "IOR", 1.5f);
SOCKET_OUT_CLOSURE(BSDF, "BSDF");
@@ -2623,7 +2623,7 @@ NODE_DEFINE(PrincipledBsdfNode)
SOCKET_IN_COLOR(base_color, "Base Color", make_float3(0.8f, 0.8f, 0.8f))
SOCKET_IN_FLOAT(metallic, "Metallic", 0.0f);
SOCKET_IN_FLOAT(roughness, "Roughness", 0.5f);
SOCKET_IN_FLOAT(ior, "IOR", 0.0f);
SOCKET_IN_FLOAT(ior, "IOR", 1.5f);
SOCKET_IN_FLOAT(alpha, "Alpha", 1.0f);
SOCKET_IN_NORMAL(normal, "Normal", zero_float3(), SocketType::LINK_NORMAL);
@@ -5781,7 +5781,7 @@ NODE_DEFINE(FresnelNode)
SOCKET_IN_NORMAL(
normal, "Normal", zero_float3(), SocketType::LINK_NORMAL | SocketType::OSL_INTERNAL);
SOCKET_IN_FLOAT(IOR, "IOR", 1.45f);
SOCKET_IN_FLOAT(IOR, "IOR", 1.5f);
SOCKET_OUT_FLOAT(fac, "Fac");

2
source/blender/nodes/shader/nodes/node_shader_bsdf_glass.cc
View File

@@ -14,7 +14,7 @@ static void node_declare(NodeDeclarationBuilder &b)
.min(0.0f)
.max(1.0f)
.subtype(PROP_FACTOR);
b.add_input<decl::Float>("IOR").default_value(1.45f).min(0.0f).max(1000.0f);
b.add_input<decl::Float>("IOR").default_value(1.5f).min(0.0f).max(1000.0f);
b.add_input<decl::Vector>("Normal").hide_value();
b.add_input<decl::Float>("Weight").unavailable();
b.add_output<decl::Shader>("BSDF");

2
source/blender/nodes/shader/nodes/node_shader_bsdf_principled.cc
View File

@@ -40,7 +40,7 @@ static void node_declare(NodeDeclarationBuilder &b)
.max(1.0f)
.subtype(PROP_FACTOR);
#define SOCK_ROUGHNESS_ID 2
b.add_input<decl::Float>("IOR").default_value(1.45f).min(1.0f).max(1000.0f);
b.add_input<decl::Float>("IOR").default_value(1.5f).min(1.0f).max(1000.0f);
#define SOCK_IOR_ID 3
b.add_input<decl::Float>("Alpha").default_value(1.0f).min(0.0f).max(1.0f).subtype(PROP_FACTOR);
#define SOCK_ALPHA_ID 4

2
source/blender/nodes/shader/nodes/node_shader_fresnel.cc
View File

@@ -8,7 +8,7 @@ namespace blender::nodes::node_shader_fresnel_cc {
static void node_declare(NodeDeclarationBuilder &b)
{
b.add_input<decl::Float>("IOR").default_value(1.45f).min(0.0f).max(1000.0f);
b.add_input<decl::Float>("IOR").default_value(1.5f).min(0.0f).max(1000.0f);
b.add_input<decl::Vector>("Normal").hide_value();
b.add_output<decl::Float>("Fac");
}