griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #143739: Operator redo broken for duplicate move

Browse Source 
In this case the depsgraph isn't necessarily evaluated before the
transform operator executes. We need to make sure there's an evaluated
depsgraph so the evaluated deform positions are updated based on the
duplicate operator (the first step of the operator macro).

Pull Request: https://projects.blender.org/blender/blender/pulls/144037
This commit is contained in:
Hans Goudey
2025-08-06 13:38:49 +02:00
committed by Hans Goudey
parent 4bede1b555
commit b2d0b9535f
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/editors/transform/transform_convert_curves.cc
View File

@@ -272,6 +272,9 @@ static void createTransCurvesVerts(bContext *C, TransInfo *t)
const bool use_proportional_edit = (t->flag & T_PROP_EDIT_ALL) != 0;
const bool use_connected_only = (t->flag & T_PROP_CONNECTED) != 0;
/* Evaluated depsgraph is necessary for taking into account deformation from modifiers. */
Depsgraph *depsgraph = CTX_data_ensure_evaluated_depsgraph(C);
/* Count selected elements per object and create TransData structs. */
for (const int i : trans_data_contrainers.index_range()) {
TransDataContainer &tc = trans_data_contrainers[i];
@@ -352,7 +355,7 @@ static void createTransCurvesVerts(bContext *C, TransInfo *t)
Curves *curves_id = static_cast<Curves *>(object->data);
bke::CurvesGeometry &curves = curves_id->geometry.wrap();
const bke::crazyspace::GeometryDeformation deformation =
bke::crazyspace::get_evaluated_curves_deformation(*CTX_data_depsgraph_pointer(C), *object);
bke::crazyspace::get_evaluated_curves_deformation(*depsgraph, *object);
std::optional<MutableSpan<float>> value_attribute;
bke::SpanAttributeWriter<float> attribute_writer;