griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Avoid allocating extra array in sample nearest node

Browse Source 
The distances array was filled but never used.
This commit is contained in:
Hans Goudey
2023-05-02 15:07:40 -04:00
parent 5b876b810f
commit b3a3b94976
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/nodes/geometry/nodes/node_geo_sample_nearest.cc
View File

@@ -263,19 +263,18 @@ class SampleNearestFunction : public mf::MultiFunction {
case GEO_COMPONENT_TYPE_MESH: {
const MeshComponent &component = *static_cast<const MeshComponent *>(src_component_);
const Mesh &mesh = *component.get_for_read();
Array<float> distances(mask.min_array_size());
switch (domain_) {
case ATTR_DOMAIN_POINT:
get_closest_mesh_points(mesh, positions, mask, indices, distances, {});
get_closest_mesh_points(mesh, positions, mask, indices, {}, {});
break;
case ATTR_DOMAIN_EDGE:
get_closest_mesh_edges(mesh, positions, mask, indices, distances, {});
get_closest_mesh_edges(mesh, positions, mask, indices, {}, {});
break;
case ATTR_DOMAIN_FACE:
get_closest_mesh_polys(mesh, positions, mask, indices, distances, {});
get_closest_mesh_polys(mesh, positions, mask, indices, {}, {});
break;
case ATTR_DOMAIN_CORNER:
get_closest_mesh_corners(mesh, positions, mask, indices, distances, {});
get_closest_mesh_corners(mesh, positions, mask, indices, {}, {});
break;
default:
break;
@@ -286,8 +285,7 @@ class SampleNearestFunction : public mf::MultiFunction {
const PointCloudComponent &component = *static_cast<const PointCloudComponent *>(
src_component_);
const PointCloud &points = *component.get_for_read();
Array<float> distances(mask.min_array_size());
get_closest_pointcloud_points(points, positions, mask, indices, distances);
get_closest_pointcloud_points(points, positions, mask, indices, {});
break;
}
default: