griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #142259: Overlay: Velocity drawing outside of cache range causes crash

Browse Source 
The check for ensuring active frame is in cache range was
wrong and would still try to draw the velocity.

Candidate for 4.5 LTS.

Pull Request: https://projects.blender.org/blender/blender/pulls/142332
This commit is contained in:
Clément Foucault
2025-07-18 15:59:53 +02:00
committed by Clément Foucault
parent f4671fd3ca
commit b77d4a8f60
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/draw/engines/overlay/overlay_fluid.hh
View File

@@ -103,7 +103,7 @@ class Fluids : Overlay {
}
const bool is_active_frame_after_cache_start = state.scene->r.cfra >= fds->cache_frame_start;
const bool is_active_frame_before_cache_end = state.scene->r.cfra >= fds->cache_frame_start;
const bool is_active_frame_before_cache_end = state.scene->r.cfra <= fds->cache_frame_end;
const bool is_active_frame_in_cache_range = is_active_frame_after_cache_start &&
is_active_frame_before_cache_end;
if (!is_active_frame_in_cache_range) {
@@ -132,8 +132,7 @@ class Fluids : Overlay {
int slice_axis = slide_axis_get(*fds);
const bool draw_velocity = (fds->draw_velocity && is_active_frame_after_cache_start);
if (draw_velocity) {
if (fds->draw_velocity) {
int lines_per_voxel = -1;
PassSimple::Sub *sub_pass = nullptr;
switch (fds->vector_draw_type) {